[GHC] #9713: Update comment about C helper for dynamic exports.
#9713: Update comment about C helper for dynamic exports. -------------------------------------+------------------------------------- Reporter: int-e | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.8.3 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Easy (less than 1 | Type of failure: Other hour) | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- The offending comment is in {{{compiler/deSugar/DsForeign.lhs}}}. The RTS API has changed so that {{{rts_evalIO}}} takes a capability as its first argument; so make the comment reflect reality. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9713 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9713: Update comment about C helper for dynamic exports. -------------------------------------+------------------------------------- Reporter: int-e | Owner: Type: task | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.8.3 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Other | hour) Test Case: | Blocked By: Blocking: | Related Tickets: Differential Revisions: | -------------------------------------+------------------------------------- Changes (by int-e): * status: new => patch -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9713#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9713: Update comment about C helper for dynamic exports. -------------------------------------+------------------------------------- Reporter: int-e | Owner: Type: task | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.8.3 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Other | hour) Test Case: | Blocked By: Blocking: | Related Tickets: Differential Revisions: | -------------------------------------+------------------------------------- Comment (by thomie): No knowing anything about this code, I have the following questions/remarks, mostly about the commit message: * Please mention the Trac number. * Patch does more than update a comment, needs better title. * What does it mean that f_helper is a helper in C "approximately"? * In which commit did the RTS API change? * Are there other calls to rts_evalIO anywhere that need updating? * Why did this not get caught by a test? Should one be added? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9713#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9713: Update comment about C helper for dynamic exports. -------------------------------------+------------------------------------- Reporter: int-e | Owner: Type: task | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.8.3 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Other | hour) Test Case: | Blocked By: Blocking: | Related Tickets: Differential Revisions: | -------------------------------------+------------------------------------- Comment (by int-e): Replying to [comment:2 thomie]: * I prepared the patch before writing the ticket, but I've updated the commit message to include the Trac number and a reference to the original patch (from 2011). * The patch only updates comments (note that it is changing a latex style .lhs file), so there's nothing to test. * "approximately" - in reality, the code has to extract the result of the call, and the details of that depend on whether LLVM is used or not, and I'm not sure I understand all of them. Since the emphasis of the comment is the creation of adjustors, I think it's ok to gloss over that. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9713#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9713: Update comment about C helper for dynamic exports. -------------------------------------+------------------------------------- Reporter: int-e | Owner: Type: task | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.8.3 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Other | hour) Test Case: | Blocked By: Blocking: | Related Tickets: Differential Revisions: | -------------------------------------+------------------------------------- Comment (by int-e): In fact there were two relevant API changes, 03a9ff01812afc81eb5236fd3063cbec44cf469e and 8b75acd3ca25165536f18976c8d80cb62ad613e4. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9713#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9713: Update comment about C helper for dynamic exports. -------------------------------------+------------------------------------- Reporter: int-e | Owner: Type: task | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.8.3 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Other | hour) Test Case: | Blocked By: Blocking: | Related Tickets: Differential Revisions: | -------------------------------------+------------------------------------- Comment (by thomie):
note that it is changing a latex style .lhs file Thanks, I missed that. Patch LGTM now.
-- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9713#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9713: Update comment about C helper for dynamic exports.
-------------------------------------+-------------------------------------
Reporter: int-e | Owner:
Type: task | Status: patch
Priority: normal | Milestone:
Component: Compiler | Version: 7.8.3
Resolution: | Keywords:
Operating System: | Architecture: Unknown/Multiple
Unknown/Multiple | Difficulty: Easy (less than 1
Type of failure: Other | hour)
Test Case: | Blocked By:
Blocking: | Related Tickets:
Differential Revisions: |
-------------------------------------+-------------------------------------
Comment (by Austin Seipp
#9713: Update comment about C helper for dynamic exports. -------------------------------------+------------------------------------- Reporter: int-e | Owner: Type: task | Status: closed Priority: normal | Milestone: 7.10.1 Component: Compiler | Version: 7.8.3 Resolution: fixed | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Other | hour) Test Case: | Blocked By: Blocking: | Related Tickets: Differential Revisions: | -------------------------------------+------------------------------------- Changes (by thoughtpolice): * status: patch => closed * resolution: => fixed * milestone: => 7.10.1 Comment: Merged, thanks! -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9713#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC