[GHC] #16091: arith011 broken with integer-simple
#16091: arith011 broken with integer-simple -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.6.3 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- The `arith011` test fails unexpected when using `integer-simple`. The test output is [[https://gitlab.haskell.org/ghc/ghc/-/jobs/4892/raw|quite long]] but here is the end: {{{ # negate 0 = 0 # testReal toRational 0 = 0 % 1 toRational 1 = 1 % 1 toRational 2 = 2 % 1 toRational 3 = 3 % 1 # testIntegral Stderr ( arith011 ): arith011: divide by zero *** unexpected failure for arith011(normal) }}} This is concerning since it suggests a behavioral difference between `integer-simple` and `integer-gmp`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16091> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16091: arith011 broken with integer-simple -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"993782073c0b380908e9541c40c6c5849dbacfec/ghc" 9937820/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="993782073c0b380908e9541c40c6c5849dbacfec" testsuite: Fix a variety of issues when building with integer-simple * Mark arith011 as broken with integer-simple As noted in #16091, arith011 fails when run against integer-simple with a "divide by zero" exception. This suggests that integer-gmp and integer- simple are handling division by zero differently. * This also fixes broken_without_gmp; the lack of types made the previous failure silent, sadly. Improves situation of #16043. * Mark several tests implicitly depending upon integer-gmp as broken with integer-simple. These expect to see Core coming from integer-gmp, which breaks with integer-simple. * Increase runtime timeout multiplier of T11627a with integer-simple I previously saw that T11627a timed out in all profiling ways when run against integer-simple. I suspect this is due to integer-simple's rather verbose heap representation. Let's see whether increasing the runtime timeout helps. Fixes test for #11627. This is all in service of fixing #16043. }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16091#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16091: arith011 broken with integer-simple -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | https://gitlab.haskell.org/ghc/ghc/merge_requests/36 -------------------------------------+------------------------------------- Changes (by harpocrates): * status: new => patch * differential: => https://gitlab.haskell.org/ghc/ghc/merge_requests/36 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16091#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16091: arith011 broken with integer-simple -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | https://gitlab.haskell.org/ghc/ghc/merge_requests/36 -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"bbea972149882b4f5f6b0a1691488a519ba6aaf9/ghc" bbea9721/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="bbea972149882b4f5f6b0a1691488a519ba6aaf9" Division fails fast for `divMod` \w integer-simple We want to match the behaviour of `Integer` as well as `Integer`/`Natural` from `integer-gmp`, namely to have divMod x 0 = _|_ not divMod x 0 = (_|_, _|_) See #16091 for an example of where this matters. }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16091#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16091: arith011 broken with integer-simple -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.6.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | https://gitlab.haskell.org/ghc/ghc/merge_requests/36 -------------------------------------+------------------------------------- Changes (by harpocrates): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16091#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC