[GHC] #13230: Something strange with "Don't use the splitter on Darwin"
#13230: Something strange with "Don't use the splitter on Darwin" -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: rwbarton Type: task | Status: new Priority: high | Milestone: 8.2.1 Component: Compiler | Version: 8.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Commit 266a9dc4cd34008f1162eb276032c85ef8371842 "Don't use the splitter on Darwin" sounds like it should only affect Darwin, but the perf results indicate otherwise, even though perf.haskell.org builds are done on a linux machine: https://perf.haskell.org/ghc/#revision/266a9dc4cd34008f1162eb276032c85ef8371... Total build time went up 13.7% and all nofib object sizes became much larger. I suspect the splitter was disabled completely. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13230> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13230: Something strange with "Don't use the splitter on Darwin" -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: rwbarton Type: task | Status: new Priority: high | Milestone: 8.2.1 Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3070 Wiki Page: | -------------------------------------+------------------------------------- Changes (by rwbarton): * differential: => Phab:D3070 Comment: Using split sections by default (as opposed to split objects) was accidentally disabled, so the perf results were the reverse of https://perf.haskell.org/ghc/#revision/8f71d9581ee0a1826c0105e51a7048f0c7669.... -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13230#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13230: Something strange with "Don't use the splitter on Darwin" -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: rwbarton Type: task | Status: new Priority: high | Milestone: 8.2.1 Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3070 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Matthew Pickering <matthewtpickering@…>): In [changeset:"283acec1d7307fdbd8cd7b3f1d984a036366d6b4/ghc" 283acec/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="283acec1d7307fdbd8cd7b3f1d984a036366d6b4" Make split sections by default work again Commit 266a9dc4c changed = to := in one place in mk/config.mk.in. This broke SupportsSplitSections because the variable LdIsGNULd that it depends on is not defined until later in the file. Test Plan: pushed to a wip/ branch for perf to build Reviewers: DemiMarie, austin, bgamari, mpickering Reviewed By: mpickering Subscribers: mpickering, thomie Differential Revision: https://phabricator.haskell.org/D3070 GHC Trac Issues: #13230 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13230#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13230: Something strange with "Don't use the splitter on Darwin" -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: rwbarton Type: task | Status: closed Priority: high | Milestone: 8.2.1 Component: Compiler | Version: 8.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3070 Wiki Page: | -------------------------------------+------------------------------------- Changes (by mpickering): * status: new => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13230#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC