[GHC] #14972: MacOS panic on TH
#14972: MacOS panic on TH -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.4.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Compile-time Unknown/Multiple | crash or panic Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- I recently did a clean build of master (affdea82bb70e5a912b679a169c6e9a230e4c93e) and, while everything successfully finished, I'm getting panics every time I try to use this GHC for something that involves TH. For example: {{{#!hs {-# language TemplateHaskell #-} pure [] main = pure [] }}} Crashes with {{{ $ ./inplace/bin/ghc-stage2 th.hs [1 of 1] Compiling Main ( th.hs, th.o ) ghc-stage2: loadArchive: Failed reading header from `/Users/atheriault/Documents/code/ghc/libraries/integer-gmp/dist- install/build/gmp' ghc-stage2: panic! (the 'impossible' happened) (GHC version 8.5.20180325 for x86_64-apple-darwin): loadArchive "/Users/atheriault/Documents/code/ghc/libraries /integer-gmp/dist-install/build/gmp": failed Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug }}} Normally I'd assume I haven't correctly configured something, yet I had no problem building and running GHC on this machine a month or so ago... -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14972 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14972: MacOS panic on TH -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.4.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by mpickering): How did you build GHC? This kind of error occurs if you build with nix and don't use `configurePhase` and `buildPhase`. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14972#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14972: MacOS panic on TH -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.4.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by harpocrates): Replying to [comment:1 mpickering]:
How did you build GHC? This kind of error occurs if you build with nix and don't use `configurePhase` and `buildPhase`.
I just followed the instructions from the Build page. Pretty much just {{{ $ ./boot $ ./configure --with-ghc=ghc-8.4.1 $ make -j4 V=0 }}} I've been bisecting, but it is slow progress. The problem is not present in `a2d03c69b782212e6c476cfc1870bae493a4ac89`. I'll report back when I hit a commit. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14972#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14972: MacOS panic on TH -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.4.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Very odd; I wonder if this is related to #14891 (which is sadly present in 8.4.1). -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14972#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14972: MacOS panic on TH -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.4.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by harpocrates): Alright. Without really having looked at the contents of commits, I can say something about the behaviour of certain ranges. * 4631ceb261cb08756b955c6b495d5e719d35ab62 is the last commit which builds and doesn't crash when compiling some TH * 8f0b2f5eadf0fcb47c581907205a9db686214a69-df7ac37d43bdbabbde9b09344f9425e8e5a879ff don't build at all (`No rule to make target 'libraries/integer- gmp/include/HsIntegerGmp.h'`) * f6cf4001574e789865d25f89b362a04ef1ca3df4-affdea82bb70e5a912b679a169c6e9a230e4c93e (and probably later) build but crash when I try to compile anything that involves TH In terms of the way in which the crash happens: I've run into both segfaults and panics. Since the possibly offending commit bumps Cabal, I'm not sure if this isn't just another manifestation of https://github.com/haskell/cabal/issues/5222. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14972#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14972: MacOS panic on TH
-------------------------------------+-------------------------------------
Reporter: harpocrates | Owner: (none)
Type: bug | Status: new
Priority: normal | Milestone:
Component: Compiler | Version: 8.4.1
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
Type of failure: Compile-time | Unknown/Multiple
crash or panic | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s):
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by ezyang):
This is even simpler to reproduce: `ghc --interactive` doesn't work on Mac
OS X:
{{{
MacBook-Pro-97:unifier-ghc ezyang$ ~/Dev/ghc/inplace/bin/ghc-stage2
--interactive
GHCi, version 8.5.20180327: http://www.haskell.org/ghc/ :? for help
ghc-stage2: loadArchive: Failed reading header from
`/Users/ezyang/Dev/ghc/libraries/integer-gmp/dist-install/build/gmp'
ghc-stage2: panic! (the 'impossible' happened)
(GHC version 8.5.20180327 for x86_64-apple-darwin):
loadArchive "/Users/ezyang/Dev/ghc/libraries/integer-gmp/dist-
install/build/gmp": failed
Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug
}}}
This was a 'perf' build of:
{{{
commit b58282a009ae67cbd4befbe062452026c82afd51 (HEAD -> master,
origin/master, origin/HEAD)
Author: Ben Gamari
#14972: MacOS panic on TH -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.4.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by harpocrates): Another observation: if I `make install`, the installed GHC does not run into any of these problems. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14972#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14972: MacOS panic on TH -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.4.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by ezyang): I've diagnosed the proximate cause. In the failing version of the compiler, an inplace build creates a `gmp` directory in `libraries /integer-gmp/dist-install/build/`: {{{ MacBook-Pro-97:ghc-quick1 ezyang$ ls libraries/integer-gmp/dist- install/build/ GHC gmp HSinteger-gmp-1.0.1.0.o include autogen integer-gmp.buildinfo cbits libHSinteger- gmp-1.0.1.0-ghc8.5.20180331.dylib config.log libHSinteger-gmp-1.0.1.0.a config.status }}} Unfortuantely, this changes the behavior of our print file name invocation: {{{ MacBook-Pro-97:ghc-quick1 ezyang$ gcc -fno-stack-protector -DTABLES_NEXT_TO_CODE -B/Users/ezyang/Dev/ghc-quick1/libraries/integer-gmp /dist-install/build --print-file-name gmp /Users/ezyang/Dev/ghc-quick1/libraries/integer-gmp/dist-install/build/gmp }}} This should return `gmp`. When it returns a file path, we attempt to open this location, which clearly will not work: {{{ *** gcc: gcc -fno-stack-protector -DTABLES_NEXT_TO_CODE -B/Users/ezyang/Dev/ghc- quick1/libraries/integer-gmp/dist-install/build --print-file-name gmp addLibrarySearchPath: dll_path = `/Users/ezyang/Dev/ghc-quick1/libraries /integer-gmp/dist-install/build' Loading package integer-gmp-1.0.1.0 ... addDLL: dll_name = '/Users/ezyang/Dev/ghc-quick1/libraries/integer-gmp/dist-install/build /libHSinteger-gmp-1.0.1.0-ghc8.5.20180331.dylib' internal_dlopen: dll_name = '/Users/ezyang/Dev/ghc-quick1/libraries /integer-gmp/dist-install/build/libHSinteger- gmp-1.0.1.0-ghc8.5.20180331.dylib' loadArchive: start loadArchive: Loading archive `/Users/ezyang/Dev/ghc-quick1/libraries /integer-gmp/dist-install/build/gmp' ghc-stage2: loadArchive: Failed reading header from `/Users/ezyang/Dev /ghc-quick1/libraries/integer-gmp/dist-install/build/gmp' loadArchive: done *** Deleting temp files: Deleting: *** Deleting temp dirs: Deleting: ghc-stage2: panic! (the 'impossible' happened) (GHC version 8.5.20180331 for x86_64-apple-darwin): loadArchive "/Users/ezyang/Dev/ghc-quick1/libraries/integer-gmp /dist-install/build/gmp": failed Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug }}} I hazard some change in Cabal caused the 'gmp' directory to be created. Not entirely sure what the correct fix is yet. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14972#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14972: MacOS panic on TH -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.4.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by ezyang): * cc: angerman (added) Comment: angerman, CC'ing you, because the `gmp` folder exists in `build` because of https://github.com/haskell/cabal/pull/4874/commits I think the easiest fix we can do for now is just rename the folder we put the `config.mk` in, but we should work out a way to dodge this footgun in general. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14972#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14972: MacOS panic on TH -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.4.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by angerman): @ezyang, right. So what we actually want is to improve the archive lookup logic. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14972#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14972: MacOS panic on TH -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 8.4.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): D4553 Wiki Page: | -------------------------------------+------------------------------------- Changes (by angerman): * status: new => patch * differential: => D4553 Comment: Differential that ensures we verify whatever `gcc --print-file-name` returns is actually a file, and ignore it if not. (Should ignore folders). @ezyang, thanks for the analysis! -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14972#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14972: MacOS panic on TH -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 8.4.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4553 Wiki Page: | -------------------------------------+------------------------------------- Changes (by ezyang): * differential: D4553 => Phab:D4553 Comment: Hmm. Suppose that `gcc --print-file-name` would have printed a real file name, and instead the existence of `gmp` directory in basedir causes `gcc` to print the `gmp` in `basedir`. Wouldn't we now have lost information that `gcc --print-file-name` would have otherwise given? OTOH I guess there isn't really any way to get the correct information now (unless you remove `basedir`, I suppose) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14972#comment:11 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14972: MacOS panic on TH
-------------------------------------+-------------------------------------
Reporter: harpocrates | Owner: (none)
Type: bug | Status: patch
Priority: normal | Milestone:
Component: Compiler | Version: 8.4.1
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
Type of failure: Compile-time | Unknown/Multiple
crash or panic | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D4553
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#14972: MacOS panic on TH -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.4.2 Component: Compiler | Version: 8.4.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4553 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * milestone: => 8.4.2 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14972#comment:13 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14972: MacOS panic on TH -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.4.2 Component: Compiler | Version: 8.4.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4553 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14972#comment:14 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC