[GHC] #16003: Average and maximum residency numbers in nofib broken
#16003: Average and maximum residency numbers in nofib broken -------------------------------------+------------------------------------- Reporter: sgraf | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: ⊥ Component: NoFib | Version: 8.6.2 benchmark suite | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: 5793 Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Measuring average and maximum residency in nofib is currently broken: {{{ <<ghc: 55717832 bytes, 32 GCs (29 + 3), 0/0 avg/max bytes residency (0 samples), 58859672 bytes GC work, ... }}} I think that [https://github.com/ghc/nofib/blob/f87d446b4e361cc82f219cf78917db9681af69b3/r... this line] in runstdtest.prl was responsible for matching on `-S` output, but since [https://phabricator.haskell.org/rNOFIB4e12b05c76e98aa8e32c9f867519c8187e69e1... this commit], we only do `-s` for performance reasons. There's [https://github.com/ghc/nofib/blob/f87d446b4e361cc82f219cf78917db9681af69b3/r... this bit of outcommented code] that probably does what we want. It seems that residency numbers were the only metrics depending on `-S`. I don't think there's a way to recover average residency with `-s` alone. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16003> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16003: Average and maximum residency numbers in nofib broken -------------------------------------+------------------------------------- Reporter: sgraf | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: ⊥ Component: NoFib benchmark | Version: 8.6.2 suite | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #5793 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by sgraf): * related: 5793 => #5793 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16003#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16003: Average and maximum residency numbers in nofib broken -------------------------------------+------------------------------------- Reporter: sgraf | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: ⊥ Component: NoFib benchmark | Version: 8.6.2 suite | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #5793 | Differential Rev(s): Phab:D5418 Wiki Page: | -------------------------------------+------------------------------------- Changes (by sgraf): * status: new => patch * differential: => Phab:D5418 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16003#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16003: Average and maximum residency numbers in nofib broken -------------------------------------+------------------------------------- Reporter: sgraf | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: ⊥ Component: NoFib benchmark | Version: 8.6.2 suite | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #5793 | Differential Rev(s): Phab:D5418 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Sebastian Graf <sebastian.graf@…>): In [changeset:"f3521319e2c5390e8076fd379ddeeea9d3e7ce12/nofib" f352131/nofib]: {{{ #!CommitTicketReference repository="nofib" revision="f3521319e2c5390e8076fd379ddeeea9d3e7ce12" Fix parsing of maximum residency in runstdtest Summary: `runstdtest` switched from `-S` to `-s` output a while ago. That broke parsing of maximum and average residency numbers. This commit makes sure that at least maximum residency is parsed correctly from `-s` output, while leaving the logic for `-S` output. Reviewers: simonmar, bgamari, simonpj, osa1, AndreasK, O26 nofib Reviewed By: bgamari GHC Trac Issues: #16003 Differential Revision: https://phabricator.haskell.org/D5418 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16003#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16003: Average and maximum residency numbers in nofib broken -------------------------------------+------------------------------------- Reporter: sgraf | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: ⊥ Component: NoFib benchmark | Version: 8.6.2 suite | Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #5793 | Differential Rev(s): Phab:D5418 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16003#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC