#10536: Clear up how to turn off dynamic linking in build.mk -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Build System | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by Thomas Miedema ): In [changeset:"37de4ad76b75d403e6a8dae9539af08c859d46a4/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="37de4ad76b75d403e6a8dae9539af08c859d46a4" Build system: don't set GhcLibWays explicitly in build.mk.sample (#10536) We used to have the following in mk/build.mk.sample: GhcLibWays = $(if $(filter $(DYNAMIC_GHC_PROGRAMS),YES),v dyn,v) This commit removes that statement for the following reasons: 1) It depends on the variable DYNAMIC_GHC_PROGRAMS, which is set later in the file for some BuildFlavours. Although this works because `make` does multiple passes when reading Makefiles, it is confusing to users [1]. Instead, test for DYNAMIC_GHC_PROGRAMS in mk/config.mk.in. 2) Although it looks like that line is about compiling the `dyn` way, its purpose is really to not build the `prof` way. This commit introduces the variable BUILD_PROF_LIBS, to make this more explicit. This simplifies mk/build.mk.sample and mk/validate-settings.mk. Note that setting GhcLibWays explicitly still works, and DYNAMIC_GHC_PROGRAMS=NO in build.mk does not build the `dyn` way. [1] https://mail.haskell.org/pipermail/ghc-devs/2014-December/007725.html Differential Revision: https://phabricator.haskell.org/D1021 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10536#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10536: Clear up how to turn off dynamic linking in build.mk -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Build System | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D1021 -------------------------------------+------------------------------------- Comment (by int-e): Could we still mention `GhcLibWays` in `build.mk.sample`? For example, under `Other settings...`: {{{ # Set library ways directly instead of computing it from BUILD_PROF_LIBS and # DYNAMIC_GHC_PROGRAMS (may result in build failures) #GhcLibWays = v dyn p }}} On the topic of `DYNAMIC_GHC_PROGRAMS`, I believe the logic for enabling the `dyn` way is as follows: Since the flag implies that ghci is linked dynamically, using the dynamic rts, that means ghci requires the `dyn` libraries in order to work. Also regarding the semantics, `DYNAMIC_BY_DEFAULT` is another option which affects the usability of the resulting ghc: on Linux (presumably the story on Windows is different) Cabal doesn't interact with the resulting ghc properly if the vanilla way is enabled in Cabal's configuration, resulting in obscure build failures. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10536#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10536: Clear up how to turn off dynamic linking in build.mk -------------------------------------+------------------------------------- Reporter: thomie | Owner: alpmestan Type: task | Status: new Priority: normal | Milestone: 8.6.1 Component: Build System | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1021 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * owner: (none) => alpmestan Comment: Assigning to Alp to ensure this happens in Hadrian. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10536#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10536: Clear up how to turn off dynamic linking in build.mk -------------------------------------+------------------------------------- Reporter: thomie | Owner: alpmestan Type: task | Status: new Priority: normal | Milestone: 8.6.1 Component: Build System | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1021 Wiki Page: | -------------------------------------+------------------------------------- Comment (by alpmestan): The PR has been merged, this is now covered explicitly in hadrian's documentation. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10536#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler