[GHC] #11060: Failing tests on 32 bit platforms
#11060: Failing tests on 32 bit platforms -------------------------------------+------------------------------------- Reporter: erikd | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Test Suite | Version: 7.11 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Other Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- On 32 bit PowerPC and Arm I've been getting about 20 new test failures (starting about a week ago). For example: {{{ --- ./simplCore/should_compile/T8274.stdout.normalised +++ ./simplCore/should_compile/T8274.run.stdout.normalised @@ -1,10 +1,10 @@ T8274.$trModule2 = TrNameS "main"# T8274.$trModule1 = TrNameS "T8274"# T8274.$tcP1 = TrNameS "P"# - 11095028091707994303## - 9476557054198009608## + 11095028091707994303L## + 9476557054198009608L## T8274.$tcN1 = TrNameS "N"# - 7479687563082171902## - 17616649989360543185## + 7479687563082171902L## + 17616649989360543185L## p = T8274.Positives 42# 4.23# 4.23## '4'# 4## n = T8274.Negatives -4# -4.0# -4.0## \ No newline at end of file *** unexpected failure for T8274(normal) }}} This is simply a matter of a difference between the expected output `123##` vs `123L##`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11060> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11060: Failing tests on 32 bit platforms -------------------------------------+------------------------------------- Reporter: erikd | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Test Suite | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): The relevant part of the expected output of this test prior to being mangled by the testsuite driver is, {{{#!hs T8274.$tcN :: TyCon [GblId[ReflectionId], Caf=NoCafRefs, Str=DmdType m, Unf=Unf{Src=<vanilla>, TopLvl=True, Value=True, ConLike=True, WorkFree=True, Expandable=True, Guidance=IF_ARGS [] 10 50}] T8274.$tcN = TyCon 7479687563082171902## 17616649989360543185## T8274.$trModule }}} So, it appears that the difference here arises from the fact that something formatting a `Data.Typeable.Internal.TyCon` is including an extra `L` while formatting the `Word64#` fingerprints on 32-bit machines. Given that this isn't valid Haskell on 32- nor 64-bit machines, this should likely be fixed. However, I can't for the life of me figure out where this is happening. It would appear that the `Show TyCon` instance is defined in `libraries,base/GHC/Show.hs`, {{{#!hs instance Show TyCon where showsPrec p (TyCon _ _ _ tc_name) = showsPrec p tc_name }}} which clearly doesn't match the output we are seeing here. I've tried looking for `Outputable` instances but the only one I've been able to find is for `typecheck/TyCon.hs`. Perhaps this is being derived by `TcGenDeriv` but I've not seen any logic in there that might be adding this errant `L`. It's all quite perplexing. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11060#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11060: Failing tests on 32 bit platforms -------------------------------------+------------------------------------- Reporter: erikd | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Test Suite | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by thomie): One of the changes in 89458eba5721de1b6b3378415f26e110bab8cc0f might be what you are looking for. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11060#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11060: Failing tests on 32 bit platforms -------------------------------------+------------------------------------- Reporter: erikd | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Test Suite | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1507 Wiki Page: | -------------------------------------+------------------------------------- Changes (by erikd): * differential: => Phab:D1507 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11060#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11060: Failing tests on 32 bit platforms -------------------------------------+------------------------------------- Reporter: erikd | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Test Suite | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1510 Wiki Page: | -------------------------------------+------------------------------------- Changes (by erikd): * differential: Phab:D1507 => Phab:D1510 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11060#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11060: Failing tests on 32 bit platforms -------------------------------------+------------------------------------- Reporter: erikd | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Test Suite | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1510 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"64737f2dfa0ff9ca4f4c056143b3591cedd32652/ghc" 64737f2d/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="64737f2dfa0ff9ca4f4c056143b3591cedd32652" New expected test output for 32 bit platforms Test Plan: Test on Arm and PowerPc. Reviewers: bgamari, thomie, austin Differential Revision: https://phabricator.haskell.org/D1510 GHC Trac Issues: #11060 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11060#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11060: Failing tests on 32 bit platforms -------------------------------------+------------------------------------- Reporter: erikd | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.0.1 Component: Test Suite | Version: 7.11 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1510 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11060#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC