#8769: Minor refactoring of Maybe.lhs --------------------------------------+------------------------------------ Reporter: Iceland_jack | Owner: Type: bug | Status: patch Priority: lowest | Milestone: Component: libraries (other) | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: --------------------------------------+------------------------------------ Changes (by Iceland_jack): * status: new => patch -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8769#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8769: Minor refactoring of Maybe.lhs --------------------------------------+------------------------------------ Reporter: Iceland_jack | Owner: Type: bug | Status: patch Priority: lowest | Milestone: Component: libraries (other) | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: --------------------------------------+------------------------------------ Comment (by Iceland_jack): No reason really, wouldn't it be a matter of replacing every occurrence of `mapCatMaybes` with `mapMaybe` since `Maybes` already exports `Data.Maybe`? Should I add a patch for that? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8769#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8769: Minor refactoring of Maybe.lhs --------------------------------------+------------------------------------ Reporter: Iceland_jack | Owner: Type: bug | Status: patch Priority: lowest | Milestone: Component: libraries (other) | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: --------------------------------------+------------------------------------ Comment (by Iceland_jack): I removed `mapCatMaybes`, `allMaybes` and `maybeToBool` completely from `Maybes`, I decided to keep `firstJust` since the name is clearer than `msum` (should `orElse` be moved to `Data.Maybe`? it seems to be the sole reason for importing `Maybes` much of the time). Did you have any other modules in mind that needed cleanup? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8769#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8769: Minor refactoring of Maybe.lhs --------------------------------------+------------------------------------ Reporter: Iceland_jack | Owner: nomeata Type: bug | Status: patch Priority: lowest | Milestone: Component: libraries (other) | Version: 7.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: --------------------------------------+------------------------------------ Changes (by nomeata): * owner: => nomeata Comment: I don’t think we should be moving stuff to `Data.Maybe` just yet. Also, the non-monadic versions are easier to read, just as you say. I think the patch is good to go. I’ll validate and push. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8769#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler