[GHC] #13414: shebang + literate haskell causes line numbering skew
#13414: shebang + literate haskell causes line numbering skew -------------------------------------+------------------------------------- Reporter: slyfox | Owner: (none) Type: bug | Status: new Priority: low | Milestone: Component: Compiler | Version: 8.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Incorrect Unknown/Multiple | error/warning at compile-time Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Noticed on doctest's Setup.lhs file. Minimal example: {{{#!hs #!/usr/bin/env runhaskell
main = return () }}}
{{{ $ inplace/bin/ghc-stage2 -fforce-recomp -Wall Setup [1 of 1] Compiling Main ( Setup.lhs, Setup.o ) Setup.lhs:1:3: warning: [-Wmissing-signatures] Top-level binding with no type signature: main :: IO () | 1 | #!/usr/bin/env runhaskell | ^^^^ }}} Notice how it points 4 characters a line before '''main'''. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13414> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13414: shebang + literate haskell causes line numbering skew -------------------------------------+------------------------------------- Reporter: slyfox | Owner: (none) Type: bug | Status: new Priority: low | Milestone: Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple error/warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * cc: Rufflewind (added) -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13414#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13414: shebang + literate haskell causes line numbering skew -------------------------------------+------------------------------------- Reporter: slyfox | Owner: (none) Type: bug | Status: new Priority: low | Milestone: Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple error/warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Rufflewind): https://phabricator.haskell.org/D3333 should fix this. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13414#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13414: shebang + literate haskell causes line numbering skew -------------------------------------+------------------------------------- Reporter: slyfox | Owner: (none) Type: bug | Status: new Priority: low | Milestone: Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple error/warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3333 Wiki Page: | -------------------------------------+------------------------------------- Changes (by slyfox): * differential: => Phab:D3333 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13414#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13414: shebang + literate haskell causes line numbering skew -------------------------------------+------------------------------------- Reporter: slyfox | Owner: (none) Type: bug | Status: new Priority: low | Milestone: Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple error/warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3333 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"c77b767098be53087e0b06ba23d613dd7c3bcf8e/ghc" c77b767/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="c77b767098be53087e0b06ba23d613dd7c3bcf8e" unlit: replace the SHEBANG with an empty line This corrects the line numbers for literate code after a shebang. Fixes #13414. Test Plan: validate Reviewers: austin, bgamari, trofi Reviewed By: bgamari, trofi Subscribers: trofi, rwbarton, thomie Differential Revision: https://phabricator.haskell.org/D3333 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13414#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13414: shebang + literate haskell causes line numbering skew -------------------------------------+------------------------------------- Reporter: slyfox | Owner: (none) Type: bug | Status: closed Priority: low | Milestone: 8.2.1 Component: Compiler | Version: 8.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple error/warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3333 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed * milestone: => 8.2.1 Comment: Merged to `ghc-8.2` as bd3c648dc22e7e268c6390db822a704dc61b14b7. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13414#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC