[GHC] #13914: -fignore-asserts flag not handled by recompilation checker
#13914: -fignore-asserts flag not handled by recompilation checker -------------------------------------+------------------------------------- Reporter: osa1 | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Driver | Version: 8.3 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- As demonstrated below, `-fignore-asserts` is not stored in .hi files and not checked by recompilation checker. {{{ $ cat main.hs module Main where import Control.Exception main = do assert False (putStrLn "OK") $ ghc main.hs [1 of 1] Compiling Main ( main.hs, main.o ) Linking main ... $ ./main main: Assertion failed CallStack (from HasCallStack): assert, called at main.hs:6:5 in main:Main $ ghc main.hs -fignore-asserts $ ./main main: Assertion failed CallStack (from HasCallStack): assert, called at main.hs:6:5 in main:Main }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13914> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13914: -fignore-asserts flag not handled by recompilation checker -------------------------------------+------------------------------------- Reporter: osa1 | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Driver | Version: 8.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3698 Wiki Page: | -------------------------------------+------------------------------------- Changes (by osa1): * differential: => Phab:D3698 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13914#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13914: -fignore-asserts flag not handled by recompilation checker -------------------------------------+------------------------------------- Reporter: osa1 | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: Component: Driver | Version: 8.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3698 Wiki Page: | -------------------------------------+------------------------------------- Changes (by osa1): * status: new => patch -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13914#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13914: -fignore-asserts flag not handled by recompilation checker -------------------------------------+------------------------------------- Reporter: osa1 | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: Component: Driver | Version: 8.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3698 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"1a9c3c44ef82803766a8db91a619393c43195ad3/ghc" 1a9c3c44/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="1a9c3c44ef82803766a8db91a619393c43195ad3" Implement recompilation checking for -fignore-asserts Test Plan: Added a test which was previously failing Reviewers: austin, bgamari, simonpj Reviewed By: simonpj Subscribers: simonpj, rwbarton, thomie GHC Trac Issues: #13914 Differential Revision: https://phabricator.haskell.org/D3698 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13914#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13914: -fignore-asserts flag not handled by recompilation checker -------------------------------------+------------------------------------- Reporter: osa1 | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.4.1 Component: Driver | Version: 8.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3698 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed * milestone: => 8.4.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13914#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC