[GHC] #15930: Add @since-annotations to the Foldable methods
#15930: Add @since-annotations to the Foldable methods -------------------------------------+------------------------------------- Reporter: sjakobi | Owner: (none) Type: feature | Status: new request | Priority: normal | Milestone: 8.6.3 Component: Core | Version: 8.6.2 Libraries | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Methods like `sum` were added some time after `Foldable`'s inception. It would be nice to know when exactly. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15930> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15930: Add @since-annotations to the Foldable methods -------------------------------------+------------------------------------- Reporter: sjakobi | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 8.6.3 Component: Core Libraries | Version: 8.6.2 Resolution: | Keywords: newcomers Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * keywords: => newcomers Comment: Indeed. Based on my testing (i.e., [https://github.com/nfrisby/invariant- functors/blob/ed51d2f0343c060076672e41f588447a179babda/src/Data/Functor/Invariant.hs#L581-L594 here]), we need the following `@since` annotations: * Introduced in `base-4.6.0.0`: * `foldr'` * `foldl'` * Introduced in `base-4.8.0.0`: * `toList` * `null` * `length` * `elem` * `maximum` * `minimum` * `sum` * `product` Any volunteers? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15930#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15930: Add @since-annotations to the Foldable methods -------------------------------------+------------------------------------- Reporter: sjakobi | Owner: (none) Type: feature request | Status: patch Priority: normal | Milestone: 8.6.3 Component: Core Libraries | Version: 8.6.2 Resolution: | Keywords: newcomers Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5379 Wiki Page: | -------------------------------------+------------------------------------- Changes (by dminuoso): * status: new => patch * differential: => Phab:D5379 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15930#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15930: Add @since-annotations to the Foldable methods -------------------------------------+------------------------------------- Reporter: sjakobi | Owner: (none) Type: feature request | Status: patch Priority: normal | Milestone: 8.6.3 Component: Core Libraries | Version: 8.6.2 Resolution: | Keywords: newcomers Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5379 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ryan Scott <ryan.gl.scott@…>): In [changeset:"9e3aaf8b58d0f0e12e2d19b6928b6c2461d58dda/ghc" 9e3aaf8b/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="9e3aaf8b58d0f0e12e2d19b6928b6c2461d58dda" Add missing since annotations Reviewers: hvr, bgamari, RyanGlScott Reviewed By: RyanGlScott Subscribers: RyanGlScott, rwbarton, carter GHC Trac Issues: #15930 Differential Revision: https://phabricator.haskell.org/D5379 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15930#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15930: Add @since-annotations to the Foldable methods -------------------------------------+------------------------------------- Reporter: sjakobi | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: 8.8.1 Component: Core Libraries | Version: 8.6.2 Resolution: fixed | Keywords: newcomers Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5379 Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * status: patch => closed * resolution: => fixed * milestone: 8.6.3 => 8.8.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15930#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC