#10313: ApiAnnotations : strings in warnings do not return SourceText -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | ApiAnnotations Type of failure: None/Unknown | Architecture: Blocked By: | Unknown/Multiple Related Tickets: | Test Case: | Blocking: | Differential Revisions: Phab:D907 -------------------------------------+------------------------------------- Changes (by alanz): * differential: => Phab:D907 * milestone: 7.12.1 => 7.10.2 Comment: I have set the milestone to 7.10.2, as this is the last item blocking a full hackage round trip, resulting in 40 or so failing files out of around 50k. It does require a tiny change to Haddock, but is basically just adding `SourceText` fields to the last places they are required. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10313#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10313: ApiAnnotations : strings in warnings do not return SourceText -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: patch Priority: normal | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | ApiAnnotations Type of failure: None/Unknown | Architecture: Blocked By: | Unknown/Multiple Related Tickets: | Test Case: | Blocking: | Differential Revisions: Phab:D907 -------------------------------------+------------------------------------- Comment (by Alan Zimmerman ): In [changeset:"e6191d1cc37e98785af8b309100ea840084fa3ba/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="e6191d1cc37e98785af8b309100ea840084fa3ba" ApiAnnotations : strings in warnings do not return SourceText Summary: The strings used in a WARNING pragma are captured via strings :: { Located ([AddAnn],[Located FastString]) } : STRING { sL1 $1 ([],[L (gl $1) (getSTRING $1)]) } .. The STRING token has a method getSTRINGs that returns the original source text for a string. A warning of the form {-# WARNING Logic , mkSolver , mkSimpleSolver , mkSolverForLogic , solverSetParams , solverPush , solverPop , solverReset , solverGetNumScopes , solverAssertCnstr , solverAssertAndTrack , solverCheck , solverCheckAndGetModel , solverGetReasonUnknown "New Z3 API support is still incomplete and fragile: \ \you may experience segmentation faults!" #-} returns the concatenated warning string rather than the original source. This patch now deals with all remaining instances of getSTRING to bring in a SourceText for each. This updates the haddock submodule as well, for the AST change. Test Plan: ./validate Reviewers: hvr, austin, goldfire Reviewed By: austin Subscribers: bgamari, thomie, mpickering Differential Revision: https://phabricator.haskell.org/D907 GHC Trac Issues: #10313 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10313#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10313: ApiAnnotations : strings in warnings do not return SourceText -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: closed Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.10.1 Resolution: fixed | Keywords: | ApiAnnotations Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D907 -------------------------------------+------------------------------------- Comment (by Sergei Trofimovich ): In [changeset:"b04bed0a391335e70b3c3bdbdccbaa0781697cce/ghc" b04bed0a/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="b04bed0a391335e70b3c3bdbdccbaa0781697cce" renamer: fix module-level deprecation message Noticed today that deprecation warnings are slightly broken in -HEAD: mtl-2.2.1/Control/Monad/Error/Class.hs:46:1: warning: Module ‘Control.Monad.Trans.Error’ is deprecated: ([", U, s, e, , C, o, n, t, r, o, l, ., M, o, n, a, d, ., T, r, a, n, s, ., E, x, c, e, p, t, , i, n, s, t, e, a, d, "], Use Control.Monad.Trans.Except instead) Commit e6191d1cc37e98785af8b309100ea840084fa3ba slightly changed WarningTxt declaration: -data WarningTxt = WarningTxt (Located SourceText) [Located FastString] - | DeprecatedTxt (Located SourceText) [Located FastString] +data WarningTxt = WarningTxt (Located SourceText) + [Located (SourceText,FastString)] + | DeprecatedTxt (Located SourceText) + [Located (SourceText,FastString)] But 'moduleWarn' function was not updated to do the stripping. Signed-off-by: Sergei Trofimovich Reviewers: austin, bgamari, hvr, goldfire, rwbarton, alanz Reviewed By: rwbarton, alanz Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D1096 GHC Trac Issues: #10313 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10313#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler