[GHC] #10700: include/stg/Prim.h isn't C++ compatible
#10700: include/stg/Prim.h isn't C++ compatible -------------------------------------+------------------------------------- Reporter: Fabian | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Build | Version: 7.10.1 System | Keywords: FFI | Operating System: Unknown/Multiple Architecture: | Type of failure: Other Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Revisions: | -------------------------------------+------------------------------------- StgWord hs_cmpxchg8(volatile StgWord8 *x, StgWord old, StgWord new); and a few other declarations in Prim.h causes problems as they use ''new'' as a variable name. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10700> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10700: include/stg/Prim.h isn't C++ compatible -------------------------------------+------------------------------------- Reporter: Fabian | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler (FFI) | Version: 7.10.1 Resolution: | Keywords: FFI, | newcomers Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by thomie): * keywords: FFI => FFI, newcomers * component: Build System => Compiler (FFI) Comment: Maybe you want to write a patch yourself? See the [wiki:Newcomers] info and [wiki:WorkingConventions/FixingBugs]. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10700#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10700: include/stg/Prim.h isn't C++ compatible -------------------------------------+------------------------------------- Reporter: Fabian | Owner: rasen Type: bug | Status: new Priority: normal | Milestone: Component: Compiler (FFI) | Version: 7.10.1 Resolution: | Keywords: FFI, | newcomers Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by rasen): * owner: => rasen -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10700#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10700: include/stg/Prim.h isn't C++ compatible -------------------------------------+------------------------------------- Reporter: Fabian | Owner: rasen Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler (FFI) | Version: 7.10.1 Resolution: | Keywords: FFI, | newcomers Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D1107 -------------------------------------+------------------------------------- Changes (by rasen): * status: new => patch * differential: => Phab:D1107 Comment: The build fails (https://phabricator.haskell.org/harbormaster/build/5215/), but the failure isn't related to the change. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10700#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10700: include/stg/Prim.h isn't C++ compatible -------------------------------------+------------------------------------- Reporter: Fabian | Owner: rasen Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler (FFI) | Version: 7.10.1 Resolution: | Keywords: FFI, | newcomers Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D1107 -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"e7c331af4674dd072a9f1d67feb586679b365b98/ghc" e7c331af/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="e7c331af4674dd072a9f1d67feb586679b365b98" Make headers C++ compatible (fixes #10700) Some headers used `new` as parameter name, which is reserved word in C++. This patch changes these names to `new_`. Test Plan: validate Reviewers: austin, ezyang, bgamari, simonmar Reviewed By: simonmar Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D1107 GHC Trac Issues: #10700 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10700#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10700: include/stg/Prim.h isn't C++ compatible -------------------------------------+------------------------------------- Reporter: Fabian | Owner: rasen Type: bug | Status: closed Priority: normal | Milestone: Component: Compiler (FFI) | Version: 7.10.1 Resolution: fixed | Keywords: FFI, | newcomers Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D1107 -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10700#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10700: include/stg/Prim.h isn't C++ compatible -------------------------------------+------------------------------------- Reporter: Fabian | Owner: rasen Type: bug | Status: merge Priority: normal | Milestone: 7.10.3 Component: Compiler (FFI) | Version: 7.10.1 Resolution: fixed | Keywords: FFI, | newcomers Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D1107 -------------------------------------+------------------------------------- Changes (by simonmar): * status: closed => merge * milestone: => 7.10.3 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10700#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10700: include/stg/Prim.h isn't C++ compatible -------------------------------------+------------------------------------- Reporter: Fabian | Owner: rasen Type: bug | Status: closed Priority: normal | Milestone: 7.10.3 Component: Compiler (FFI) | Version: 7.10.1 Resolution: fixed | Keywords: FFI, | newcomers Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1107 -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed Comment: Merged to `ghc-7.10` as 5c1fff2acdb57300411c3e803fbf6a9caaf2580b. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10700#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10700: include/stg/Prim.h isn't C++ compatible -------------------------------------+------------------------------------- Reporter: Fabian | Owner: rasen Type: bug | Status: closed Priority: normal | Milestone: 7.10.3 Component: Compiler (FFI) | Version: 7.10.1 Resolution: fixed | Keywords: FFI, newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1107 Wiki Page: | -------------------------------------+------------------------------------- Changes (by monoidal): * keywords: FFI, newcomers => FFI, newcomer -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10700#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC