#15088: Test T3234 is fragile -------------------------------------+------------------------------------- Reporter: mpickering | Owner: (none) Type: task | Status: new Priority: lowest | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Keywords: newcomer | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- The test for T3234 is quite fragile as it compares the whole output of `-ddump-simpl-stats`. #3234 should be consulted and then the test modified so that only the relevant part is extracted and compared. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15088> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15088: Test T3234 is fragile -------------------------------------+------------------------------------- Reporter: mpickering | Owner: RolandSenn Type: task | Status: new Priority: lowest | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by RolandSenn): * owner: (none) => RolandSenn Comment: As a newcomer, I'll work on this. If I don't do any progress till end of June 2018, I'll unassign. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15088#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15088: Test T3234 is fragile -------------------------------------+------------------------------------- Reporter: mpickering | Owner: RolandSenn Type: task | Status: new Priority: lowest | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Thanks Roland! Do let us know if you have any questions. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15088#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15088: Test T3234 is fragile -------------------------------------+------------------------------------- Reporter: mpickering | Owner: RolandSenn Type: task | Status: patch Priority: lowest | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: T3234 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by RolandSenn): * testcase: => T3234 * status: new => patch Comment: To fix this issue,I sent a [https://github.com/ghc/ghc/pull/138 pull- request] to the Github repository. As mentioned in the original ticket #3234, the issue was that the rule `fold/build` no longer fired. Hence it's sufficient to check only on the availability of this rule in the output. A more sophisticated test could check on: {{{ 5 RuleFired 1 ++ 1 augment/build 1 foldr/single 1 unpack 1 unpack-list }}} However this would nedd the grep alternative `grep 'foo\|bar` which is part of ''extended'' grep. Please feel free to request any needed changes to this PR. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15088#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15088: Test T3234 is fragile -------------------------------------+------------------------------------- Reporter: mpickering | Owner: RolandSenn Type: task | Status: closed Priority: lowest | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: T3234 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed Comment: Merged. Thanks roland! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15088#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15088: Test T3234 is fragile -------------------------------------+------------------------------------- Reporter: mpickering | Owner: RolandSenn Type: task | Status: closed Priority: lowest | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: T3234 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"91a82de011d3bc1783f849168d90268bc24ceeee/ghc" 91a82de0/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="91a82de011d3bc1783f849168d90268bc24ceeee" testsuite: Make T3234 more robust Just look for the rule firing that we want to see instead of matching on the entire dump. Fixes #15088. }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15088#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC