[GHC] #7756: Remove warning suppressions from compiler/cmm/CmmCommonBlockElim.hs
#7756: Remove warning suppressions from compiler/cmm/CmmCommonBlockElim.hs -----------------------------+---------------------------------------------- Reporter: bosu | Owner: Type: task | Status: new Priority: normal | Component: Compiler Version: 7.7 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Blockedby: Blocking: | Related: -----------------------------+---------------------------------------------- It compiles fine without them now. The patch is attached -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7756> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7756: Remove warning suppressions from compiler/cmm/CmmCommonBlockElim.hs -----------------------------+---------------------------------------------- Reporter: bosu | Owner: Type: task | Status: new Priority: normal | Component: Compiler Version: 7.7 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Blockedby: Blocking: | Related: -----------------------------+---------------------------------------------- Comment(by monoidal): While we are at it, I found some other files where the warnings can be reenabled: Cmm.hs, CmmContFlowOpt.hs, CmmProcPoint.hs, CmmRewriteAssignments.hs, CmmUtils.hs. Since it's closely related I'll attach the diff here. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7756#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7756: Remove warning suppressions from compiler/cmm/CmmCommonBlockElim.hs -----------------------------+---------------------------------------------- Reporter: bosu | Owner: Type: task | Status: patch Priority: normal | Component: Compiler Version: 7.7 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Blockedby: Blocking: | Related: -----------------------------+---------------------------------------------- Changes (by monoidal): * status: new => patch -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7756#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7756: Remove warning suppressions from compiler/cmm/CmmCommonBlockElim.hs -----------------------------+---------------------------------------------- Reporter: bosu | Owner: Type: task | Status: patch Priority: normal | Component: Compiler Version: 7.7 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Blockedby: Blocking: | Related: -----------------------------+---------------------------------------------- Comment(by ezyang@…): commit 9f2644215e39eb9509da819f6f5d4d7f1984d386 {{{ Author: Edward Z. Yang <ezyang@mit.edu> Date: Sat Mar 9 20:16:58 2013 -0800 Remove unnecessary warnings suppressions, fixes ticket #7756; thanks monoidal for submitting. Signed-off-by: Edward Z. Yang <ezyang@mit.edu> compiler/cmm/Cmm.hs | 1 - compiler/cmm/CmmContFlowOpt.hs | 3 +-- compiler/cmm/CmmProcPoint.hs | 1 - compiler/cmm/CmmRewriteAssignments.hs | 3 --- compiler/cmm/CmmUtils.hs | 4 ---- 5 files changed, 1 insertions(+), 11 deletions(-) }}} -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7756#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7756: Remove warning suppressions from compiler/cmm/CmmCommonBlockElim.hs ---------------------------------+------------------------------------------ Reporter: bosu | Owner: Type: task | Status: closed Priority: normal | Component: Compiler Version: 7.7 | Resolution: fixed Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Blockedby: | Blocking: Related: | ---------------------------------+------------------------------------------ Changes (by ezyang): * status: patch => closed * resolution: => fixed Comment: bosu's patch seems unnecessary on HEAD. Others validated and checked in. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7756#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7756: Remove warning suppressions from compiler/cmm/CmmCommonBlockElim.hs -------------------------------+-------------------------------------------- Reporter: bosu | Owner: Type: task | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 7.7 Resolution: fixed | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Difficulty: Unknown Testcase: | Blockedby: Blocking: | Related: -------------------------------+-------------------------------------------- Changes (by simonpj): * difficulty: => Unknown Comment: I've did the one for `CmmCommonBlockElim`, thanks. `git am` didn't recognise the patch, so I did it myself. Simon -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7756#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC