[GHC] #15157: Use a better string type (ByteString?!) for HsDocString
#15157: Use a better string type (ByteString?!) for HsDocString -------------------------------------+------------------------------------- Reporter: sjakobi | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- `HsDocString` is currently defined as {{{ newtype HsDocString = HsDocString FastString }}} Alex Biehl and hvr mentioned that due to `FastString`'s (interning?) overhead it's not a good type to store haddocks. They suggested using `ByteString` instead. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15157 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15157: Use a better string type (ByteString?!) for HsDocString -------------------------------------+------------------------------------- Reporter: sjakobi | Owner: (none) Type: task | Status: patch Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4743 Wiki Page: | -------------------------------------+------------------------------------- Changes (by sjakobi): * status: new => patch * differential: => Phab:D4743 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15157#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15157: Use a better string type (ByteString?!) for HsDocString
-------------------------------------+-------------------------------------
Reporter: sjakobi | Owner: (none)
Type: task | Status: patch
Priority: normal | Milestone: 8.6.1
Component: Compiler | Version: 8.2.2
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D4743
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#15157: Use a better string type (ByteString?!) for HsDocString -------------------------------------+------------------------------------- Reporter: sjakobi | Owner: (none) Type: task | Status: closed Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4743 Wiki Page: | -------------------------------------+------------------------------------- Changes (by sjakobi): * status: patch => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15157#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC