[GHC] #14767: Move Data.Functor.Contravariant into base
#14767: Move Data.Functor.Contravariant into base -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: (none) Type: feature | Status: new request | Priority: normal | Milestone: Component: Compiler | Version: 8.2.2 Keywords: base | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- I propose that `Data.Functor.Contravariant` be moved to `base`. This has been discussed on the mailing list in 2016 and 2017: - https://mail.haskell.org/pipermail/libraries/2016-December/027480.html - https://mail.haskell.org/pipermail/libraries/2017-September/028190.html -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14767> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14767: Move Data.Functor.Contravariant into base -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.2.2 Resolution: | Keywords: base Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by andrewthad): * cc: ekmett (added) -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14767#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14767: Move Data.Functor.Contravariant into base -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.2.2 Resolution: | Keywords: base Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by RyanGlScott): Sounds good to me—the idea seemed popular on the libraries mailing list. Care to offer a patch? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14767#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14767: Move Data.Functor.Contravariant into base -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.2.2 Resolution: | Keywords: base Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by andrewthad): I'll get a patch up soon. Thanks. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14767#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14767: Move Data.Functor.Contravariant into base -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.2.2 Resolution: | Keywords: base Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by andrewthad): I've put up a patch on phabricator as https://phabricator.haskell.org/D4399. There should be two commits in that differential, although I am only able to see one of them in phabricator. Changes still need to be made to `StateVar`, `transformers`, and `contravariant`. I can help with these later down the road if needed. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14767#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14767: Move Data.Functor.Contravariant into base -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.2.2 Resolution: | Keywords: base Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"8c7a1551fcd004c37f4ccd99c7c10395179519f1/ghc" 8c7a1551/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="8c7a1551fcd004c37f4ccd99c7c10395179519f1" Move Data.Functor.Contravariant from the contravariant package to base. Move Data.Functor.Contravariant from the contravariant package to base. Since base is the bottom of the dependency hierarchy, several instances have been removed. They will need to be added to the following packages: transformers, StateVar, and possibly tagged. There may not actually have been any types from tagged that previous had instanced provided by this module though, since it may have only been used for Data.Proxy. Additionally, all CPP has been removed. Derived Typeable instances have been removed (since Typeable is now automatically derived for everything). The language extension Safe is still used, although it is unclear to ATM whether or not it is necessary. This resolves trac issue #14767. Test Plan: validate Reviewers: RyanGlScott, ekmett, hvr, bgamari Reviewed By: RyanGlScott Subscribers: rwbarton, thomie, ekmett, carter, RyanGlScott GHC Trac Issues: #14767 Differential Revision: https://phabricator.haskell.org/D4399 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14767#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14767: Move Data.Functor.Contravariant into base -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: base Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed * milestone: => 8.6.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14767#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14767: Move Data.Functor.Contravariant into base -------------------------------------+------------------------------------- Reporter: andrewthad | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: base Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4399 Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * differential: => Phab:D4399 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14767#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC