[GHC] #12356: StaticPointers support in GHCi

newer
[GHC] #15599: typeclass inference...

GHC

1 Jul 2016 1 Jul '16

8:03 a.m.

#12356: StaticPointers support in GHCi -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: feature | Status: new request | Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: #12000 Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Currently GHCi does not support `-XStaticPointers`, which is quite annoying for those of us who actually use `-XStaticPointers` in day-to-day development. It would be great if GHCi could grow support for this extension. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12356 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Show replies by date

GHC

1 Jul 1 Jul

8:05 a.m.

GHC

8:06 a.m.

GHC

5:36 p.m.

#12356: StaticPointers support in GHCi -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: feature request | Status: new Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #12000 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by facundo.dominguez): When compiling a module, the FloatOut pass puts StaticPtrs in the top level and the tidy-core pass generates a C constructor function which inserts the top-level bindings in the static pointer table (SPT) when the module is loaded. In GHCi, I guess that bindings could be inserted in the SPT when they are linked. I don't know if the FloatOut pass is used when compiling code in GHCi, if not, floating the static pointer values to the top-level would need to be accomplished otherwise. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12356#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

31 Aug 31 Aug

5:25 p.m.

GHC

1 Sep 1 Sep

8:59 a.m.

GHC

9:46 a.m.

#12356: StaticPointers support in GHCi -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: feature request | Status: patch Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #12000, #9878 | Differential Rev(s): Phab:D2504 Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): One particularly hairy problem that arises here is that of breakpoint ticks interacting with FloatOut. Currently we disallow any floating through breakpoint ticks. However, static pointer support requires that we float out static expressions to the top level. I can see two options here, 1. Allow floating of `StaticPtr` values through breakpoints as a special case. 2. Disable breakpoint production while `-XStaticPointers` is enabled. Given that (1) may give rise to some rather surprising behavior in the face of recursive groups (e.g. a recursive group with one `StaticPtr` and a bunch of other bindings; the whole group will need to be floated, killing breakpoint support for all floated code), I suspect that (2) is the only sensible option. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12356#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

2 Sep 2 Sep

1:17 p.m.

GHC

19 Dec 19 Dec

8:13 p.m.

GHC

31 Jan 31 Jan

12:11 a.m.

#12356: StaticPointers support in GHCi -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: feature request | Status: patch Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #12000, #9878 | Differential Rev(s): Phab:D2504 Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Phab:D2504 adds limited support for `StaticPointers` in GHCi. While expressions entered at the REPL still cannot contain `static` expressions, modules loaded into the interpreter may. This should recover the majority of the convenience that one previously lost with `StaticPointers`. Note, however, that there is a bit of a memory leak as static expressions will necessarily never be unloaded, even after the module that introduced them goes out of scope. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12356#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

2 Feb 2 Feb

12:19 a.m.

#12356: StaticPointers support in GHCi -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: feature request | Status: patch Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #12000, #9878 | Differential Rev(s): Phab:D2504 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"eedb3df0c1c28a7abc43705d614239c1c6199a1f/ghc" eedb3df0/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="eedb3df0c1c28a7abc43705d614239c1c6199a1f" Add support for StaticPointers in GHCi Here we add support to GHCi for StaticPointers. This process begins by adding remote GHCi messages for adding entries to the static pointer table. We then collect binders needing SPT entries after linking and send the interpreter a message adding entries with the appropriate fingerprints. Test Plan: `make test TEST=StaticPtr` Reviewers: facundominguez, mboes, simonpj, simonmar, goldfire, austin, hvr, erikd Reviewed By: simonpj, simonmar Subscribers: RyanGlScott, simonpj, thomie Differential Revision: https://phabricator.haskell.org/D2504 GHC Trac Issues: #12356 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12356#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

12:20 a.m.

GHC

21 Jun 21 Jun

12:10 p.m.

#12356: StaticPointers support in GHCi -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #12000, #9878 | Differential Rev(s): Phab:D2504, Wiki Page: | Phab:D3663 -------------------------------------+------------------------------------- Changes (by bgamari): * owner: bgamari => (none) * status: closed => new * differential: Phab:D2504 => Phab:D2504, Phab:D3663 * resolution: fixed => Comment: RyanGlScott points out that this patch inadvertently added a `pprTrace` which blurts out in GHCi. Phab:D3663 fixes this. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12356#comment:12 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

23 Jun 23 Jun

12:57 p.m.

GHC

1:07 p.m.

#12356: StaticPointers support in GHCi -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: feature request | Status: merge Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #12000, #9878 | Differential Rev(s): Phab:D2504, Wiki Page: | Phab:D3663 -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"84cf095dc981ea21fcceddbb71463dd7844754ca/ghc" 84cf095d/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="84cf095dc981ea21fcceddbb71463dd7844754ca" compiler: Eliminate pprTrace in SPT entry addition codepath Test Plan: Load program with StaticPointers into GHCi, ensure no tracing output makes it in. Reviewers: austin Subscribers: rwbarton, thomie, RyanGlScott GHC Trac Issues: #12356 Differential Revision: https://phabricator.haskell.org/D3663 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12356#comment:14 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

2:52 p.m.

#12356: StaticPointers support in GHCi -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #12000, #9878 | Differential Rev(s): Phab:D2504, Wiki Page: | Phab:D3663 -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed Comment: Merged with 0fa0d6c2d64dc41783e04b5887f96a996a181d3b -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12356#comment:15 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

4 Sep 4 Sep

9:31 a.m.

...

:set -XStaticPointers <interactive>: warning: StaticPointers is not supported in GHCi interactive expressions. }}}

-- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12356#comment:16 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

7 Sep 7 Sep

9:34 a.m.

#12356: StaticPointers support in GHCi -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #12000, #9878 | Differential Rev(s): Phab:D2504, Wiki Page: | Phab:D3663 -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"9400a5c6b308fbb5b3a73690610736ca3b5eb0b3/ghc" 9400a5c6/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="9400a5c6b308fbb5b3a73690610736ca3b5eb0b3" ghc: Remove warning of StaticPointers not being supported by GHCi Support for StaticPointers was added in #12356 but I apparently neglected to remove the warning. }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12356#comment:17 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

9:38 a.m.

GHC

10:48 a.m.

#12356: StaticPointers support in GHCi -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #12000, #9878 | Differential Rev(s): Phab:D2504, Wiki Page: | Phab:D3663 -------------------------------------+------------------------------------- Comment (by bgamari): Ahh, never mind; the patch in comment:17 is wrong. As noted in comment:9 we *still* don't support StaticPointers in the REPL. I'll revert and make sure there is a comment mentioning this next to the warning. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12356#comment:19 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

2448

Age (days ago)

3246

Last active (days ago)

List overview

Download

19 comments

1 participants

[GHC] #12356: StaticPointers support in GHCi

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

tags

participants (1)