[GHC] #13609: regression: `ANN` pragmas for TH-less GHCs no longer ignored in GHC 8.2.1 - ghc-tickets - Haskell.org

newer
[GHC] #8443: cannot find normal...

[GHC] #13609: regression: `ANN` pragmas for TH-less GHCs no longer ignored in GHC 8.2.1

older
[GHC] #13577: Compiler performance...

GHC

24 Apr 2017 24 Apr '17

6:37 a.m.

#13609: regression: `ANN` pragmas for TH-less GHCs no longer ignored in GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: new Priority: high | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: GHC rejects Unknown/Multiple | valid program Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Consider {{{#!hs module M where {-# ANN myId "HLint: ignore" #-} myId :: a -> a myId x = x }}} GHC 8.0.2 would simply ignore them: {{{ $ ghc-8.0.2 -c M.hs M.hs:3:1: warning: Ignoring ANN annotation, because this is a stage-1 compiler or doesn't support GHCi }}} however, with a recent GHC 8.2 snapshot this just fails with {{{ $ ghc-8.2 -c M.hs ghc: this operation requires -fexternal-interpreter }}} This is a serious problem because `hlint` annotations are quite popular, and this would require us to retrofit `other-extensions: TemplateHaskell` into the meta-data of quite a few packages on Hackage to declare that a package no longer works with a TH-less GHC (which would basically mean that ports of GHC such as the one for AIX that don't support TH will become very inconvenient to use and require to pester package authors to explicitly guard `ANN` pragmas with CPP... which I'm not looking forward to ;-) ). -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

Show replies by date

GHC

24 Apr 24 Apr

6:40 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 (was: regression: `ANN` pragmas for TH-less GHCs no longer ignored in GHC 8.2.1)

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: new Priority: high | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

6:51 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: new Priority: high | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by hvr): And btw, `-fexternal-interpreter` doesn't work on AIX either, for the same reason there's no GHCi or TH support: `loadArchive` doesn't support XCOFF (which is even worse than Windows' COFF flavour - i.e. not going to happen), and adding support for the dynamic linker on AIX isn't going to happen any time soon either (partly because XCOFF imposes quite a lot of limitations one would have to workaround). -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

9:46 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: new Priority: high | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * cc: shlevy (added) Comment: Commit 27f79255634d9789f367273504545c1ebfad90a0 (Allow use of the external interpreter in stage1) is the culprit. cc'ing shlevy, the author. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

11:45 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: new Priority: high | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by shlevy): Ack, will look at it ASAP -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

25 Apr 25 Apr

9:13 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: new Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * priority: high => highest Comment: This is definitely a release blocker. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

9:30 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: new Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by shlevy): * Attachment "13609.patch" added. Untested fix -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

9:31 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: new Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by shlevy): hvr can you test this ^ ? I can test this evening if not. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

10:13 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: patch Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by hvr): * status: new => patch -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

10:15 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: patch Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by shlevy): https://phabricator.haskell.org/D3496 <- tested this locally, M.hs now works as expected with and without -fexternal-interpreter in stage1. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

10:36 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: patch Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by hvr): I've tested the patch on AIX, and it appears to work well there. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

30 Apr 30 Apr

8:43 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: patch Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3496 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * differential: => Phab:D3496 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

11:21 p.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: patch Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: stage1/T13609 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3496 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * testcase: => stage1/T13609 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:11 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

1 May 1 May

10:52 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: patch Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: stage1/T13609 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3496 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"7567b9ddba7c4304e8d0226e9bf82a054f37ce91/ghc" 7567b9dd/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="7567b9ddba7c4304e8d0226e9bf82a054f37ce91" Ignore ANN pragmas with no TH and no external interpreter. Reviewers: hvr, austin, bgamari, RyanGlScott Reviewed By: bgamari Subscribers: angerman, RyanGlScott, rwbarton, thomie GHC Trac Issues: #13609 Differential Revision: https://phabricator.haskell.org/D3496 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:12 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

10:52 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: patch Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: stage1/T13609 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3496 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"18fbb9d32cbc157e3bbd235e392f1625f77321e3/ghc" 18fbb9d3/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="18fbb9d32cbc157e3bbd235e392f1625f77321e3" testsuite: Add test for #13609 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:13 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

11:10 a.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: patch Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: stage1/T13609 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3496 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"c04bd55a8daaf254436cef02934215d0b4ccfa2f/ghc" c04bd55a/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="c04bd55a8daaf254436cef02934215d0b4ccfa2f" Fix capitalization in message for #13609 I had meant to do this before merging but forgot. }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:14 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

GHC

12:34 p.m.

New subject: [GHC] #13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1

#13609: regression: `ANN` pragmas no longer ignored in TH-less GHC 8.2.1 -------------------------------------+------------------------------------- Reporter: hvr | Owner: (none) Type: bug | Status: closed Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC rejects | Unknown/Multiple valid program | Test Case: stage1/T13609 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3496 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed Comment: Merged to `ghc-8.2` as 944630400117acdf2f97759b7ed8678e8d6cdf92, f8d909ba2ab9ccc89cf59a1097d78da8f82c793f, and f8d909ba2ab9ccc89cf59a1097d78da8f82c793f. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13609#comment:15 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Reply

Sign in to reply online Use email software

2941

Age (days ago)

2948

Last active (days ago)

Download

16 comments

1 participants

tags

participants (1)

GHC