[GHC] #14676: GHCI doesn't recover from bad :add
#14676: GHCI doesn't recover from bad :add -------------------------------------+------------------------------------- Reporter: Juzley | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.2.2 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- In GHCi, when the user attempts to add a module that can not be found, the error message for that module will be repeated for any subsequent :add calls. {{{ ghci> :add Slightly/Misspelled/File.hs <no location info>: error: can't find file: Slightly/Misspelled/File.hs ... ghci> :add Correctly/Spelled/File.hs <no location info>: error: can't find file: Slightly/Misspelled/File.hs }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14676> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14676: GHCI doesn't recover from bad :add -------------------------------------+------------------------------------- Reporter: Juzley | Owner: Juzley Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.2.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by Juzley): * owner: (none) => Juzley -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14676#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14676: GHCI doesn't recover from bad :add -------------------------------------+------------------------------------- Reporter: Juzley | Owner: Juzley Type: bug | Status: new Priority: normal | Milestone: Component: GHCi | Version: 8.2.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by Juzley): * failure: None/Unknown => Other * component: Compiler => GHCi -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14676#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14676: GHCI doesn't recover from bad :add -------------------------------------+------------------------------------- Reporter: Juzley | Owner: Juzley Type: bug | Status: new Priority: normal | Milestone: Component: GHCi | Version: 8.2.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"0bff9e677f0569bc8a7207c20cddddfd67e2448f/ghc" 0bff9e67/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="0bff9e677f0569bc8a7207c20cddddfd67e2448f" Don't add targets that can't be found in GHCi When using the :add command in haxlsh/ghci, a module/file that can't be found is still added to the list of targets, resulting in an error message for the bad module/file for every subsequent usage of the command. The add command should verify that the module/file can be found before adding it to the list of targets. Also add a ":show targets" command to show the currently added list of commands, and an ":unadd" command to remove a target. Test Plan: Add a new GHCi testcase that checks that :add doesn't remember either files or modules that could not be found, and that both the new :show and :unadd commands work as expected. Reviewers: simonmar, bgamari Reviewed By: simonmar Subscribers: rwbarton, thomie, carter GHC Trac Issues: #14676 Differential Revision: https://phabricator.haskell.org/D4321 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14676#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14676: GHCI doesn't recover from bad :add -------------------------------------+------------------------------------- Reporter: Juzley | Owner: Juzley Type: bug | Status: closed Priority: normal | Milestone: 8.6.1 Component: GHCi | Version: 8.2.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed * milestone: => 8.6.1 Comment: Going to merge to `ghc-8.4` as this is a rather annoying usability issue. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14676#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14676: GHCI doesn't recover from bad :add -------------------------------------+------------------------------------- Reporter: Juzley | Owner: Juzley Type: bug | Status: closed Priority: normal | Milestone: 8.6.1 Component: GHCi | Version: 8.2.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Merged with 8f668bdaa1909c28a041db1680585bbf7d833987. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14676#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC