[GHC] #8444: Fix CPP issue with Xcode5 in integer-simple
#8444: Fix CPP issue with Xcode5 in integer-simple -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: new Priority: highest | Milestone: 7.8.1 Component: libraries (other) | Version: 7.7 Keywords: | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: Building GHC Difficulty: Easy (less than 1 | failed hour) | Test Case: Blocked By: | Blocking: Related Tickets: | -------------------------------------+------------------------------------- This works around a build failure with Xcode 5's version of clang, wherein writing WORD_SIZE_IN_BITS.0 results in "64 .0" (note the space). (this is for libraries/integer-simple) -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8444> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8444: Fix CPP issue with Xcode5 in integer-simple -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: closed Priority: highest | Milestone: 7.8.1 Component: libraries | Version: 7.7 (other) | Keywords: Resolution: invalid | Architecture: Unknown/Multiple Operating System: Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Building GHC | hour) failed | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------------+------------------------------------- Changes (by lukexi): * status: new => closed * resolution: => invalid Comment: Sorry, not quite right yet. Will re-open when corrected... -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8444#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8444: Fix CPP issue with Xcode5 in integer-simple -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: new Priority: highest | Milestone: 7.8.1 Component: libraries | Version: 7.7 (other) | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Building GHC | hour) failed | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------------+------------------------------------- Changes (by lukexi): * status: closed => new * resolution: invalid => Comment: OK, here's an approach to route around the problem entirely. Use add-word_size_in_bits_float-to-machdeps.patch and use-word_size_in_bits_float-in-integer-simple.patch (integer-simple-xcode5-clang-cpp-fix.patch doesn't work when clang is passed -traditional, producing 64##.0 :P) -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8444#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8444: Fix CPP issue with Xcode5 in integer-simple -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: patch Priority: highest | Milestone: 7.8.1 Component: libraries | Version: 7.7 (other) | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Building GHC | hour) failed | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------------+------------------------------------- Changes (by thoughtpolice): * status: new => patch -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8444#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8444: Fix CPP issue with Xcode5 in integer-simple -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: patch Priority: highest | Milestone: 7.8.1 Component: libraries | Version: 7.7 (other) | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Building GHC | hour) failed | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------------+------------------------------------- Comment (by Austin Seipp <austin@…>): In [changeset:"f57ba1d74ca434f6025347c70769c9f1889abcc5/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="f57ba1d74ca434f6025347c70769c9f1889abcc5" Placate clang (#8444, #8445) Once again the whitespace rules (and the rules concerning expansion of tokens) have bitten us. Authored-by: Authored-by: Luke Iannini <lukexi@me.com> Signed-off-by: Austin Seipp <austin@well-typed.com> }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8444#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8444: Fix CPP issue with Xcode5 in integer-simple -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: closed Priority: highest | Milestone: 7.8.1 Component: libraries | Version: 7.7 (other) | Keywords: Resolution: fixed | Architecture: Unknown/Multiple Operating System: Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Building GHC | hour) failed | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------------+------------------------------------- Changes (by thoughtpolice): * status: patch => closed * resolution: => fixed Comment: Merged, thanks! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8444#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8444: Fix CPP issue with Xcode5 in integer-simple -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: new Priority: highest | Milestone: 7.8.1 Component: libraries | Version: 7.7 (other) | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Building GHC | hour) failed | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------------+------------------------------------- Changes (by kazu-yamamoto): * status: closed => new * resolution: fixed => Comment: It seems to me that use-word_size_in_bits_float-in-integer-simple.patch is not applied to integer-simple yet. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8444#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8444: Fix CPP issue with Xcode5 in integer-simple -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: new Priority: highest | Milestone: 7.8.1 Component: libraries | Version: 7.7 (other) | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Building GHC | hour) failed | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------------+------------------------------------- Changes (by kazu-yamamoto): * cc: kazu@… (added) -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8444#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8444: Fix CPP issue with Xcode5 in integer-simple -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: closed Priority: highest | Milestone: 7.8.1 Component: libraries | Version: 7.7 (other) | Keywords: Resolution: fixed | Architecture: Unknown/Multiple Operating System: Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Building GHC | hour) failed | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------------+------------------------------------- Changes (by thoughtpolice): * status: new => closed * resolution: => fixed Comment: Thanks Kazu. I forgot to push this. It's done now. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8444#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8444: Fix CPP issue with Xcode5 in integer-simple -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: closed Priority: highest | Milestone: 7.8.1 Component: libraries | Version: 7.7 (other) | Keywords: clang Resolution: fixed | Architecture: Unknown/Multiple Operating System: Unknown/Multiple | Difficulty: Easy (less than 1 Type of failure: Building GHC | hour) failed | Blocked By: Test Case: | Related Tickets: Blocking: | -------------------------------------+------------------------------------- Changes (by hvr): * keywords: => clang -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8444#comment:9> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#8444: Fix CPP issue with Xcode5 in integer-simple -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: closed Priority: highest | Milestone: 7.8.1 Component: libraries | Version: 7.7 (other) | Keywords: clang cpp Resolution: fixed | Architecture: Operating System: Unknown/Multiple | Unknown/Multiple Type of failure: Building GHC | Test Case: failed | Blocking: Blocked By: | Differential Revisions: Related Tickets: | -------------------------------------+------------------------------------- Changes (by hvr): * keywords: clang => clang cpp -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8444#comment:10> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC