[GHC] #12721: Implement sigINT handler for Window's timeout.exe
#12721: Implement sigINT handler for Window's timeout.exe ----------------------------------------+---------------------------- Reporter: Phyx- | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.0.1 Keywords: | Operating System: Windows Architecture: Unknown/Multiple | Type of failure: Other Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: ----------------------------------------+---------------------------- On linux we current register a sigINT handler and kill the child processed. On Windows we don't. This sometimes leaves dangling processes when the testsuite is interrupted. Causing future failures until the dangling processes are killed. We already specifically create a job group and assign the processors to those jobs. All we have to do is register the handler and kill the process if the handler is called. See https://msdn.microsoft.com/en- us/library/windows/desktop/ms686016(v=vs.85).aspx -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12721> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12721: Implement sigINT handler for Window's timeout.exe -------------------------------+---------------------------------------- Reporter: Phyx- | Owner: (none) Type: task | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------+---------------------------------------- Comment (by Azel): I'm willing to have a go at this issue, is anyone already working on it? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12721#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12721: Implement sigINT handler for Window's timeout.exe -------------------------------+---------------------------------------- Reporter: Phyx- | Owner: (none) Type: task | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------+---------------------------------------- Comment (by Phyx-): No it's free for the taking -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12721#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12721: Implement sigINT handler for Window's timeout.exe -------------------------------+---------------------------------------- Reporter: Phyx- | Owner: Azel Type: task | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------+---------------------------------------- Changes (by Azel): * owner: (none) => Azel -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12721#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12721: Implement sigINT handler for Window's timeout.exe -------------------------------+---------------------------------------- Reporter: Phyx- | Owner: Azel Type: task | Status: patch Priority: normal | Milestone: Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4631 Wiki Page: | -------------------------------+---------------------------------------- Changes (by Azel): * status: new => patch * differential: => Phab:D4631 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12721#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12721: Implement sigINT handler for Window's timeout.exe -------------------------------+---------------------------------------- Reporter: Phyx- | Owner: Azel Type: task | Status: patch Priority: normal | Milestone: Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4631 Wiki Page: | -------------------------------+---------------------------------------- Comment (by Tamar Christina <tamar@…>): In [changeset:"2323ffdd552327a8954de8ac37908029ec7cad38/ghc" 2323ffd/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="2323ffdd552327a8954de8ac37908029ec7cad38" Adds CTRL-C handler in Windows's timeout (trac issue #12721) Summary: Uses Win32's System.Win32.Console.CtrlHandler.withConsoleCtrlHandler to add to Windows's version of the timeout executable a CTRL-C/CTRL-BREAK handler which does the close IO port/kill job cleanup, just in case. Signed-off-by: ARJANEN Loïc Jean David <arjanen.loic@gmail.com> Reviewers: Phyx, bgamari Reviewed By: Phyx Subscribers: dfeuer, thomie, carter GHC Trac Issues: #12721 Differential Revision: https://phabricator.haskell.org/D4631 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12721#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12721: Implement sigINT handler for Window's timeout.exe -------------------------------+---------------------------------------- Reporter: Phyx- | Owner: Azel Type: task | Status: closed Priority: normal | Milestone: Component: Test Suite | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Windows | Architecture: Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4631 Wiki Page: | -------------------------------+---------------------------------------- Changes (by Phyx-): * status: patch => closed * resolution: => fixed Comment: Thanks @Azel! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12721#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC