[GHC] #16202: Hadrian install script doesn't update location of haddockHTMLs and haddockInterfaces
#16202: Hadrian install script doesn't update location of haddockHTMLs and haddockInterfaces -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 8.6.3 (Hadrian) | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Installing GHC Unknown/Multiple | failed Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- This is to track part two of the plan here: https://gitlab.haskell.org/ghc/ghc/merge_requests/50#note_1808. When installing a bindist, the make system runs `ghc-cabal` to reconfigure packages and regenerate the package DB. Hadrian, on the other hand, seems to just be copying the package DB as is to its install location. This is mostly OK since most paths only need to be relative to package root. However, it breaks down for the `haddock-interfaces` and `haddock-html` fields, (esp. since documentation can be installed in a completely different location). The following interaction demonstrates the problem. Note how `ghc-pkg` is pointing us to a directory that doesn't even exist! {{{ $ ./hadrian/build.sh -c -j binary-dist $ mv _build/bindist/ghc-8.7.20190117-x86_64-apple-darwin.tar.xz /Users/alec/scratch $ cd /Users/alec/scratch $ tar xpvf ghc-8.7.20190117-x86_64-apple-darwin.tar.xz $ ./configure --prefix=/Users/alec/scratch && make install $ ./bin/ghc-pkg field base haddock-html haddock-html: /Users/alec/scratch/lib/../../docs/html/libraries/base $ ls /Users/alec/scratch/lib/../../docs/html/libraries/base ls: /Users/alec/scratch/lib/../../docs/html/libraries/base: No such file or directory }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16202 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16202: Hadrian install script doesn't update location of haddockHTMLs and haddockInterfaces -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 8.6.3 (Hadrian) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Installing GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by harpocrates): * cc: alpmestan, angerman (added) Comment: I'm really not sure what the best way is to fix this. Obviously we could bring `ghc-cabal` in, but that's a bit overkill. I lean towards manually patching the `.conf` files as part of the install script then running `ghc-pkg recache` at the end. Thoughts? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16202#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16202: Hadrian install script doesn't update location of haddockHTMLs and haddockInterfaces -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 8.6.3 (Hadrian) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Installing GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by alpmestan): Right, I think that would be the best solution for now. We can always revisit this later, when/if we think about a non-hacky solution. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16202#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16202: Hadrian install script doesn't update location of haddockHTMLs and haddockInterfaces -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 8.6.3 (Hadrian) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Installing GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by angerman): Yes. Please, please let us not ever bring back ghc-cabal. Can you see the horror in my eyes? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16202#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16202: Hadrian install script doesn't update location of haddockHTMLs and haddockInterfaces -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: harpocrates Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 8.6.3 (Hadrian) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Installing GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by harpocrates): * owner: (none) => harpocrates Comment: Good to hear! I'll hack up a sed solution that'll live in the generated install script. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16202#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16202: Hadrian install script doesn't update location of haddockHTMLs and haddockInterfaces -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: harpocrates Type: bug | Status: patch Priority: normal | Milestone: Component: Build System | Version: 8.6.3 (Hadrian) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Installing GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | https://gitlab.haskell.org/ghc/ghc/merge_requests/147 -------------------------------------+------------------------------------- Changes (by harpocrates): * status: new => patch * differential: => https://gitlab.haskell.org/ghc/ghc/merge_requests/147 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16202#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16202: Hadrian install script doesn't update location of haddockHTMLs and haddockInterfaces -------------------------------------+------------------------------------- Reporter: harpocrates | Owner: harpocrates Type: bug | Status: closed Priority: normal | Milestone: Component: Build System | Version: 8.6.3 (Hadrian) | Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Installing GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | https://gitlab.haskell.org/ghc/ghc/merge_requests/147 -------------------------------------+------------------------------------- Changes (by harpocrates): * status: patch => closed * resolution: => fixed Comment: Fixed in d26869ac83935432e0dcea1ff591268232daef32. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16202#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16202: Hadrian install script doesn't update location of haddockHTMLs and
haddockInterfaces
-------------------------------------+-------------------------------------
Reporter: harpocrates | Owner: harpocrates
Type: bug | Status: closed
Priority: normal | Milestone:
Component: Build System | Version: 8.6.3
(Hadrian) |
Resolution: fixed | Keywords:
Operating System: Unknown/Multiple | Architecture:
Type of failure: Installing GHC | Unknown/Multiple
failed | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s):
Wiki Page: | https://gitlab.haskell.org/ghc/ghc/merge_requests/147
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
participants (1)
-
GHC