[GHC] #10422: reorder in nativeCodeGen too slow
#10422: reorder in nativeCodeGen too slow -------------------------------------+------------------------------------- Reporter: nomeata | Owner: nomeata Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 (CodeGen) | Operating System: Unknown/Multiple Keywords: | Type of failure: None/Unknown Architecture: | Blocked By: Unknown/Multiple | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- When working on #10397 and after fixing the bottleneck in `elimCommonBlocks` I noticed that `reorder` was taking most of the time. Bad lazy linked lists. I have a fix, will put it on Phabricator for validation shortly -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10422> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10422: reorder in nativeCodeGen too slow -------------------------------------+------------------------------------- Reporter: nomeata | Owner: nomeata Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 (CodeGen) | Keywords: Resolution: | Architecture: Operating System: Unknown/Multiple | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D893 -------------------------------------+------------------------------------- Changes (by nomeata): * status: new => patch * differential: => Phab:D893 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10422#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10422: reorder in nativeCodeGen too slow -------------------------------------+------------------------------------- Reporter: nomeata | Owner: nomeata Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 (CodeGen) | Keywords: Resolution: | Architecture: Operating System: Unknown/Multiple | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D893 -------------------------------------+------------------------------------- Comment (by Joachim Breitner <mail@…>): In [changeset:"8e4dc8fb63b8d3bfee485c1c830776f3ed704f4d/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="8e4dc8fb63b8d3bfee485c1c830776f3ed704f4d" Greatly speed up nativeCodeGen/seqBlocks When working on #10397, I noticed that "reorder" in nativeCodeGen/seqBlocks took more than 60% of the time. With this refactoring, it does not even show up in the profile any more. This fixes #10422. Differential Revision: https://phabricator.haskell.org/D893 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10422#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10422: reorder in nativeCodeGen too slow -------------------------------------+------------------------------------- Reporter: nomeata | Owner: nomeata Type: bug | Status: merge Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 (CodeGen) | Keywords: Resolution: | Architecture: Operating System: Unknown/Multiple | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D893 -------------------------------------+------------------------------------- Changes (by nomeata): * status: patch => merge Comment: carter suggested that this might be 7.10 material. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10422#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10422: reorder in nativeCodeGen too slow -------------------------------------+------------------------------------- Reporter: nomeata | Owner: nomeata Type: bug | Status: merge Priority: normal | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 (CodeGen) | Keywords: Resolution: | Architecture: Operating System: Unknown/Multiple | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D893 -------------------------------------+------------------------------------- Changes (by carter): * milestone: => 7.10.2 Comment: this should be on the table for 7.10.2 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10422#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10422: reorder in nativeCodeGen too slow -------------------------------------+------------------------------------- Reporter: nomeata | Owner: nomeata Type: bug | Status: closed Priority: normal | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 (CodeGen) | Keywords: Resolution: fixed | Architecture: Operating System: Unknown/Multiple | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D893 -------------------------------------+------------------------------------- Changes (by thoughtpolice): * status: merge => closed * resolution: => fixed Comment: Merged to `ghc-7.10`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10422#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC