[GHC] #11018: ApiAnnotations: Add SourceText for unicode tokens
#11018: ApiAnnotations: Add SourceText for unicode tokens -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Keywords: | Operating System: Unknown/Multiple ApiAnnotations | Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- At the moment there is no way to tell if a given token used its unicode variant or its normal one, except to look at the length of the token. This fails for the unicode '*'. Expose the original source text for unicode variants so that API Annotations can capture them specifically. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11018 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11018: ApiAnnotations: Add SourceText for unicode tokens -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: | Keywords: | ApiAnnotations Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by alanz): mpickering, are you planning on tackling this? Looks like I may have some time now if not. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11018#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11018: ApiAnnotations: Add SourceText for unicode tokens -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: | Keywords: | ApiAnnotations Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by mpickering): No. Go for it. For the purpose of this ticket, I will also add that I think adding a flag `IsUnicodeSyntax` is better than adding `SourceText`. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11018#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11018: ApiAnnotations: Add SourceText for unicode tokens -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: | Keywords: | ApiAnnotations Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1473 Wiki Page: | -------------------------------------+------------------------------------- Changes (by alanz): * differential: => Phab:D1473 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11018#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11018: ApiAnnotations: Add SourceText for unicode tokens -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: patch Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: | Keywords: | ApiAnnotations Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1473 Wiki Page: | -------------------------------------+------------------------------------- Changes (by alanz): * status: new => patch -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11018#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11018: ApiAnnotations: Add SourceText for unicode tokens
-------------------------------------+-------------------------------------
Reporter: alanz | Owner: alanz
Type: bug | Status: patch
Priority: normal | Milestone: 8.0.1
Component: Compiler | Version: 7.10.2
Resolution: | Keywords:
| ApiAnnotations
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D1473
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Alan Zimmerman
#11018: ApiAnnotations: Add SourceText for unicode tokens -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: closed Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: fixed | Keywords: | ApiAnnotations Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1473 Wiki Page: | -------------------------------------+------------------------------------- Changes (by alanz): * status: patch => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11018#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC