[GHC] #10190: Add a Monad instance for ((,) w)

#10190: Add a Monad instance for ((,) w) -------------------------------------+------------------------------------- Reporter: fumieval | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: | Version: 7.8.4 libraries/base | Operating System: Unknown/Multiple Keywords: | Type of failure: None/Unknown Architecture: | Blocked By: Unknown/Multiple | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Now Monoid is defined in GHC.Base; We can define a reasonable Monad instance for `(,) w`, as a writer monad. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10190 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10190: Add a Monad instance for ((,) w) -------------------------------------+------------------------------------- Reporter: fumieval | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: libraries/base | Version: 7.8.4 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by fumieval): * status: new => patch -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10190#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10190: Add a Monad instance for ((,) w) -------------------------------------+------------------------------------- Reporter: fumieval | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Core Libraries | Version: 7.8.4 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by fumieval): * cc: core-libraries-committee@… (added) * component: libraries/base => Core Libraries -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10190#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10190: Add a Monad instance for ((,) w) -------------------------------------+------------------------------------- Reporter: fumieval | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Core Libraries | Version: 7.8.4 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by ekmett): No objection from me. This has passed the libraries@ proposal process on at least 2 separate occasions in recent memory, but had been blocked by the fact that Monoid wasn't in scope where the Monad class was defined. We have the compatible Applicative instance. I had honestly thought we already had the instance in 7.10. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10190#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10190: Add a Monad instance for ((,) w) -------------------------------------+------------------------------------- Reporter: fumieval | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Core Libraries | Version: 7.8.4 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by snoyberg): I have no objection to this change. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10190#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10190: Add a Monad instance for ((,) w) -------------------------------------+------------------------------------- Reporter: fumieval | Owner: fumieval Type: feature request | Status: patch Priority: normal | Milestone: 7.12.1 Component: libraries/base | Version: Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by hvr): * owner: => fumieval * type: bug => feature request * version: 7.8.4 => * component: Core Libraries => libraries/base * milestone: => 7.12.1 Comment: Replying to [comment:1 fumieval]: Re your patch, the implementation LGTM, but the meta-information needs improvement: - missing a `libraries/base/changelog.md` entry - commit message needs to reference `#10190` - commit message should contain link(s) to the threads which proposed this addition (and passed) Please also consider using Phabricator, as then we also get validation via the build-bot that your patch doesn't need additional tweaks somewhere (e.g. in the testsuite) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10190#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10190: Add a Monad instance for ((,) w) -------------------------------------+------------------------------------- Reporter: fumieval | Owner: fumieval Type: feature request | Status: patch Priority: normal | Milestone: 7.12.1 Component: libraries/base | Version: Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by fumieval): Sorry, I couldn't find the thread which proposed this instance. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10190#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10190: Add a Monad instance for ((,) w) -------------------------------------+------------------------------------- Reporter: fumieval | Owner: fumieval Type: feature request | Status: patch Priority: normal | Milestone: 7.12.1 Component: libraries/base | Version: Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by ekmett): Here are two of the proposals that went through the libraries@ process over the years on the topic: * https://mail.haskell.org/pipermail/libraries/2011-November/017153.html * https://mail.haskell.org/pipermail/libraries/2013-July/020446.html My google-fu is failing me when it comes to finding the rest quickly. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10190#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10190: Add a Monad instance for ((,) w) -------------------------------------+------------------------------------- Reporter: fumieval | Owner: fumieval Type: feature request | Status: patch Priority: normal | Milestone: 7.12.1 Component: libraries/base | Version: Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by hvr): I'll take it from here, thanks -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10190#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10190: Add a Monad instance for ((,) w)
-------------------------------------+-------------------------------------
Reporter: fumieval | Owner: fumieval
Type: feature request | Status: patch
Priority: normal | Milestone: 7.12.1
Component: libraries/base | Version:
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
Type of failure: None/Unknown | Unknown/Multiple
Blocked By: | Test Case:
Related Tickets: | Blocking:
| Differential Revisions:
-------------------------------------+-------------------------------------
Comment (by Herbert Valerio Riedel

#10190: Add a Monad instance for ((,) w) -------------------------------------+------------------------------------- Reporter: fumieval | Owner: fumieval Type: feature request | Status: closed Priority: normal | Milestone: 7.12.1 Component: libraries/base | Version: Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by hvr): * status: patch => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10190#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10190: Add a Monad instance for ((,) w) -------------------------------------+------------------------------------- Reporter: fumieval | Owner: fumieval Type: feature request | Status: closed Priority: normal | Milestone: 7.12.1 Component: libraries/base | Version: Resolution: fixed | Keywords: report- Operating System: Unknown/Multiple | impact Type of failure: None/Unknown | Architecture: Blocked By: | Unknown/Multiple Related Tickets: | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by hvr): * keywords: => report-impact -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10190#comment:11 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC