[GHC] #8302: Add 'bool' to Data.Bool
#8302: Add 'bool' to Data.Bool -------------------------------------------+------------------------------- Reporter: ocharles | Owner: Type: feature request | Status: new Priority: normal | Milestone: 7.8.1 Component: libraries/base | Version: 7.6.3 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Easy (less than 1 hour) | Type of failure: Blocked By: | None/Unknown Related Tickets: | Test Case: | Blocking: -------------------------------------------+------------------------------- As mentioned in http://www.haskell.org/pipermail/libraries/2013-September/020492.html I propose we add the 'bool' function to 'Data.Bool'. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8302 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8302: Add 'bool' to Data.Bool -------------------------------+------------------------------------------- Reporter: ocharles | Owner: Type: feature | Status: patch request | Milestone: 7.8.1 Priority: normal | Version: 7.6.3 Component: | Keywords: libraries/base | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 hour) Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Changes (by ocharles): * status: new => patch -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8302#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8302: Add 'bool' to Data.Bool -------------------------------+------------------------------------------- Reporter: ocharles | Owner: Type: feature | Status: patch request | Milestone: 7.8.1 Priority: normal | Version: 7.6.3 Component: | Keywords: libraries/base | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 hour) Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by ocharles): I have quickly whipped up a patch that adds the 'bool' function to 'Data.Bool'. This is my first contribution to GHC related stuff, so I may well have done things wrong - please let me know! Unfortunately, I am yet to build the above patch - I rushed this patch out due to the merge window closing on Monday; I will try and dedicate some time tomorrow to building it but if a reviewer already has a setup to do so, that may be quicker. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8302#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8302: Add 'bool' to Data.Bool -------------------------------+------------------------------------------- Reporter: ocharles | Owner: Type: feature | Status: patch request | Milestone: 7.8.1 Priority: normal | Version: 7.6.3 Component: | Keywords: libraries/base | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 hour) Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by schyler): Punting for this. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8302#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8302: Add 'bool' to Data.Bool -------------------------------+------------------------------------------- Reporter: ocharles | Owner: Type: feature | Status: patch request | Milestone: 7.8.1 Priority: normal | Version: 7.6.3 Component: | Keywords: libraries/base | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 hour) Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by nomeata): Looking at this. Why the `INLINE` pragma? Neither `maybe` nor `either` has that. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8302#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8302: Add 'bool' to Data.Bool -------------------------------+------------------------------------------- Reporter: ocharles | Owner: Type: feature | Status: patch request | Milestone: 7.8.1 Priority: normal | Version: 7.6.3 Component: | Keywords: libraries/base | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 hour) Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by ocharles): No specific reason - I just tend to automatically add `INLINE` quite liberally to small definitions. I can remove it if you want; it might be better to be consistent with `maybe` and `either`. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8302#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8302: Add 'bool' to Data.Bool -------------------------------+------------------------------------------- Reporter: ocharles | Owner: Type: feature | Status: patch request | Milestone: 7.8.1 Priority: normal | Version: 7.6.3 Component: | Keywords: libraries/base | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 hour) Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by nomeata): Ok; validate is running right now (although I cannot imagine how it could fail due to this), will push afterwards. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8302#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8302: Add 'bool' to Data.Bool
-------------------------------+-------------------------------------------
Reporter: ocharles | Owner:
Type: feature | Status: patch
request | Milestone: 7.8.1
Priority: normal | Version: 7.6.3
Component: | Keywords:
libraries/base | Architecture: Unknown/Multiple
Resolution: | Difficulty: Easy (less than 1 hour)
Operating System: | Blocked By:
Unknown/Multiple | Related Tickets:
Type of failure: |
None/Unknown |
Test Case: |
Blocking: |
-------------------------------+-------------------------------------------
Comment (by Joachim Breitner
#8302: Add 'bool' to Data.Bool -------------------------------+------------------------------------------- Reporter: ocharles | Owner: Type: feature | Status: closed request | Milestone: 7.8.1 Priority: normal | Version: 7.6.3 Component: | Keywords: libraries/base | Architecture: Unknown/Multiple Resolution: fixed | Difficulty: Easy (less than 1 hour) Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Changes (by nomeata): * status: patch => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8302#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8302: Add 'bool' to Data.Bool
-------------------------------+-------------------------------------------
Reporter: ocharles | Owner:
Type: feature | Status: closed
request | Milestone: 7.8.1
Priority: normal | Version: 7.6.3
Component: | Keywords:
libraries/base | Architecture: Unknown/Multiple
Resolution: fixed | Difficulty: Easy (less than 1 hour)
Operating System: | Blocked By:
Unknown/Multiple | Related Tickets:
Type of failure: |
None/Unknown |
Test Case: |
Blocking: |
-------------------------------+-------------------------------------------
Comment (by Joachim Breitner
participants (1)
-
GHC