[GHC] #14464: Adjust AltCon Ord instance to match linter requirements.
#14464: Adjust AltCon Ord instance to match linter requirements. -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: (none) Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.2.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- There is a Ord instance for AltCon which is incompatible with the Core Linters requirements. Updating it to match the linters requirement seems useful as it allows easy sorting of alternatives. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14464> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14464: Adjust AltCon Ord instance to match linter requirements. -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: AndreasK Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by AndreasK): * owner: (none) => AndreasK -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14464#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14464: Adjust AltCon Ord instance to match linter requirements. -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: AndreasK Type: task | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4198 Wiki Page: | -------------------------------------+------------------------------------- Changes (by AndreasK): * status: new => patch * differential: => Phab:D4198 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14464#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14464: Adjust AltCon Ord instance to match linter requirements. -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: AndreasK Type: task | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4198 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"e14945ce046a000f1542818cd5cb6007cf2e2422/ghc" e14945c/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="e14945ce046a000f1542818cd5cb6007cf2e2422" Adjust AltCon Ord instance to match Core linter requirements. When sorting by the Ord instance put DEFAULT before other constructors. This is in line with what the core linter requests allowing the use of the instance for putting alternatives in the correct order. This implements #14464. Reviewers: bgamari, simonpj Reviewed By: simonpj Subscribers: simonpj, rwbarton, thomie GHC Trac Issues: #14464 Differential Revision: https://phabricator.haskell.org/D4198 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14464#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14464: Adjust AltCon Ord instance to match linter requirements. -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: AndreasK Type: task | Status: closed Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.2.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4198 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed * milestone: => 8.4.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14464#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC