[GHC] #11521: Test failures for the `profasm` way when BUILD_PROF_LIBS=YES
#11521: Test failures for the `profasm` way when BUILD_PROF_LIBS=YES -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 7.11 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- When running `validate --slow`, which also builds libraries the profiling way now (see #11496), a lot of tests are failing for test ways `profasm` and `profthreaded`. To reproduce, set `BUILD_PROF_LIBS=YES` in `mk/build.mk` and run `make` in toplevel directory. Then run: `make test CLEANUP=1 WAY=profasm TEST="T2552 cgrun045 T5626 cgrun051 cgrun016 cgrun059 T2120 T11193 T9078 overflow3 overflow2 overflow1 T10728 T7919 T11049 T5550 conc021 SplicesUsed T5654b-O1 T5654b-O0 T2552 Rules1 T3220 T7837 ColInference3 hpc_fork ffi008 fptrfail01 TH_spliceViewPat overloadedrecfldsrun04 overloadedlabelsrun04 arr004 arr007 arr008 arr003 assert T8089 readFloat stm060 T5628 tough T7411 qq007 qq008 qq009"` (some of the above tests might be failing for other reasons, but most should be about this issue) Here is an example failure: {{{ --- ./codeGen/should_run/cgrun045.stderr.normalised 2016-01-31 16:34:03.831816885 +0100 +++ ./codeGen/should_run/cgrun045.run.stderr.normalised 2016-01-31 16:34:03.831816885 +0100 @@ -1,3 +1,6 @@ cgrun045: hello world! CallStack (from HasCallStack): error, called at cgrun045.hs:<line>:<column> in <package-id>:Main \ No newline at end of file +CallStack (from -prof): + Main.main (cgrun045.hs:6:1-52) + Main.CAF (<entire-module>) \ No newline at end of file *** unexpected failure for cgrun045(profasm) }}} Is this expected behavior? The double callstacks look a little weird to me. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11521 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11521: Test failures for the `profasm` way when BUILD_PROF_LIBS=YES -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by gridaphobe): * cc: simonmar (added) Comment: This is expected, simonmar added the `-prof` stack traces to `error` as well (when available). The rationale is that `HasCallStack` will usually include call-sites close to the error, but not further up the chain, so we augment the trace with `-prof` if we can. The formatting is a bit unfortunate, but I think we have to distinguish the two sources somehow, it's not at all clear how to stitch them together in a consistent and sensible manner. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11521#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11521: Test failures for the `profasm` way when BUILD_PROF_LIBS=YES -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by thomie): Ok, fine. But the tests need fixing somehow. They should pass for all test ways. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11521#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11521: Test failures for the `profasm` way when BUILD_PROF_LIBS=YES -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): One option would be to normalize out these profiling callstacks. You could take care of this pretty easily I believe. Unfortunately this is a very large hammer which makes it harder to test the profiling stack trace feature. It would be nice if the testsuite driver gave us a bit more control over what normalizations were run for which tests. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11521#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11521: Test failures for the `profasm` way when BUILD_PROF_LIBS=YES
-------------------------------------+-------------------------------------
Reporter: thomie | Owner:
Type: bug | Status: new
Priority: normal | Milestone:
Component: Test Suite | Version: 7.11
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s):
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Thomas Miedema
#11521: Test failures for the `profasm` way when BUILD_PROF_LIBS=YES
-------------------------------------+-------------------------------------
Reporter: thomie | Owner:
Type: bug | Status: new
Priority: normal | Milestone:
Component: Test Suite | Version: 7.11
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s):
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Thomas Miedema
#11521: Test failures for the `profasm` way when BUILD_PROF_LIBS=YES -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: bug | Status: merge Priority: normal | Milestone: 8.0.1 Component: Test Suite | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * status: new => merge * milestone: => 8.0.1 Comment: Not quite done yet (still some failing prof tests), but this is a start. To merge 73e409555019d370f3644bdf02b37dd526de4d8a to ghc-8.0, you first need 85daac593c498f581d46f44982ee5dcf1001f611 (#5654). -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11521#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11521: Test failures for the `profasm` way when BUILD_PROF_LIBS=YES -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.0.1 Component: Test Suite | Version: 7.11 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed Comment: Merged. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11521#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC