[GHC] #12728: setnumcapabilities001 sometimes fails on Windows
#12728: setnumcapabilities001 sometimes fails on Windows --------------------------------------+---------------------------------- Reporter: bgamari | Owner: Type: bug | Status: new Priority: high | Milestone: 8.2.1 Component: Runtime System | Version: 8.0.1 Keywords: | Operating System: Windows Architecture: x86_64 (amd64) | Type of failure: Runtime crash Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: --------------------------------------+---------------------------------- I have seen the `setnumcapabilities001` test fail at least once on Windows ([[https://phabricator.haskell.org/harbormaster/build/14178/?l=0]]). It seems that the assertion `ASSERT(n_idle == 0);` in `Schedule.scheduleDoGC` is to blame in this particular case. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12728> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12728: setnumcapabilities001 sometimes fails on Windows -----------------------------------+-------------------------------------- Reporter: bgamari | Owner: Type: bug | Status: new Priority: high | Milestone: 8.2.1 Component: Runtime System | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: x86_64 (amd64) Type of failure: Runtime crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -----------------------------------+-------------------------------------- Description changed by bgamari: @@ -4,1 +4,5 @@ - is to blame in this particular case. + is to blame in this particular case, + {{{ + setnumcapabilities001.exe: internal error: ASSERTION FAILED: file + rts\Schedule.c, line 1636 + }}} New description: I have seen the `setnumcapabilities001` test fail at least once on Windows ([[https://phabricator.haskell.org/harbormaster/build/14178/?l=0]]). It seems that the assertion `ASSERT(n_idle == 0);` in `Schedule.scheduleDoGC` is to blame in this particular case, {{{ setnumcapabilities001.exe: internal error: ASSERTION FAILED: file rts\Schedule.c, line 1636 }}} -- -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12728#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12728: setnumcapabilities001 sometimes fails on Windows -----------------------------------+-------------------------------------- Reporter: bgamari | Owner: simonmar Type: bug | Status: new Priority: high | Milestone: 8.2.1 Component: Runtime System | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: x86_64 (amd64) Type of failure: Runtime crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -----------------------------------+-------------------------------------- Changes (by simonmar): * owner: => simonmar Comment: I think I know what this is, just testing a fix. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12728#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12728: setnumcapabilities001 sometimes fails on Windows -----------------------------------+-------------------------------------- Reporter: bgamari | Owner: simonmar Type: bug | Status: new Priority: high | Milestone: 8.0.2 Component: Runtime System | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: x86_64 (amd64) Type of failure: Runtime crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -----------------------------------+-------------------------------------- Changes (by simonmar): * milestone: 8.2.1 => 8.0.2 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12728#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12728: setnumcapabilities001 sometimes fails on Windows -----------------------------------+-------------------------------------- Reporter: bgamari | Owner: simonmar Type: bug | Status: new Priority: high | Milestone: 8.0.2 Component: Runtime System | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: x86_64 (amd64) Type of failure: Runtime crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2617 Wiki Page: | -----------------------------------+-------------------------------------- Changes (by simonmar): * differential: => Phab:D2617 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12728#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12728: setnumcapabilities001 sometimes fails on Windows -----------------------------------+-------------------------------------- Reporter: bgamari | Owner: simonmar Type: bug | Status: new Priority: high | Milestone: 8.0.2 Component: Runtime System | Version: 8.0.1 Resolution: | Keywords: Operating System: Windows | Architecture: x86_64 (amd64) Type of failure: Runtime crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2617 Wiki Page: | -----------------------------------+-------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"acc98510c5e32474b0bba9fba54e78df2b11078c/ghc" acc9851/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="acc98510c5e32474b0bba9fba54e78df2b11078c" Fix failure in setnumcapabilities001 (#12728) The value of enabled_capabilities can change across a call to requestSync(), and we were erroneously using an old value, causing things to go wrong later. It manifested as an assertion failure, I'm not sure whether there are worse consequences or not, but we should get this fix into 8.0.2 anyway. The failure didn't happen for me because it only shows up on machines with fewer than 4 processors, due to the new logic to enable -qn automatically. I've bumped the test parameter 8 to make it more likely to exercise that code. Test Plan: Ran setnumcapabilities001 many times Reviewers: niteria, austin, erikd, rwbarton, bgamari Reviewed By: bgamari Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2617 GHC Trac Issues: #12728 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12728#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12728: setnumcapabilities001 sometimes fails on Windows -----------------------------------+-------------------------------------- Reporter: bgamari | Owner: simonmar Type: bug | Status: closed Priority: high | Milestone: 8.0.2 Component: Runtime System | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Windows | Architecture: x86_64 (amd64) Type of failure: Runtime crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2617 Wiki Page: | -----------------------------------+-------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12728#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12728: setnumcapabilities001 sometimes fails on Windows -----------------------------------+-------------------------------------- Reporter: bgamari | Owner: simonmar Type: bug | Status: merge Priority: high | Milestone: 8.0.2 Component: Runtime System | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Windows | Architecture: x86_64 (amd64) Type of failure: Runtime crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2617 Wiki Page: | -----------------------------------+-------------------------------------- Changes (by bgamari): * status: closed => merge -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12728#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12728: setnumcapabilities001 sometimes fails on Windows -----------------------------------+-------------------------------------- Reporter: bgamari | Owner: simonmar Type: bug | Status: closed Priority: high | Milestone: 8.0.2 Component: Runtime System | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Windows | Architecture: x86_64 (amd64) Type of failure: Runtime crash | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2617 Wiki Page: | -----------------------------------+-------------------------------------- Changes (by bgamari): * status: merge => closed Comment: Merged to `ghc-8.0` as 2722cd55431452ad7fc7fcae030b1587086dec8f. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12728#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC