[GHC] #13108: Improve poor Access Violation reporting on Windows
#13108: Improve poor Access Violation reporting on Windows -------------------------------------+------------------------------------- Reporter: awson | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Runtime | Version: System | Keywords: | Operating System: Windows Architecture: | Type of failure: Poor/confusing Unknown/Multiple | error message Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Currently all that we have is "Segmentation fault/access violation in generated code" message. My patch adds type (read/write/dep violation) and location information to the diagnostics. This may help tremendously when analyzing the problems. Please, apply. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13108> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13108: Improve poor Access Violation reporting on Windows -------------------------------------+------------------------------------- Reporter: awson | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Runtime System | Version: Resolution: | Keywords: Operating System: Windows | Architecture: Type of failure: Poor/confusing | Unknown/Multiple error message | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by awson): * Attachment "av_diagnostics_improvement.patch" added. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13108> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13108: Improve poor Access Violation reporting on Windows -------------------------------------+------------------------------------- Reporter: awson | Owner: Type: task | Status: patch Priority: normal | Milestone: Component: Runtime System | Version: Resolution: | Keywords: Operating System: Windows | Architecture: Type of failure: Poor/confusing | Unknown/Multiple error message | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by awson): * status: new => patch -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13108#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13108: Improve poor Access Violation reporting on Windows -------------------------------------+------------------------------------- Reporter: awson | Owner: Type: task | Status: patch Priority: normal | Milestone: Component: Runtime System | Version: Resolution: | Keywords: Operating System: Windows | Architecture: Type of failure: Poor/confusing | Unknown/Multiple error message | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * cc: RyanGlScott, Phyx- (added) -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13108#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13108: Improve poor Access Violation reporting on Windows -------------------------------------+------------------------------------- Reporter: awson | Owner: Type: task | Status: patch Priority: normal | Milestone: Component: Runtime System | Version: Resolution: | Keywords: Operating System: Windows | Architecture: Type of failure: Poor/confusing | Unknown/Multiple error message | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2969 Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * differential: => Phab:D2969 Comment: Thanks for the patch, awson! Note that this patch isn't entirely trivial, so in the future it'd be best to just submit it directly to Phabricator. I went ahead and submitted to Phab myself as Phab:D2969 and added you as a subscriber, so if there are changes requested, feel free to commandeer the Diff and fix it. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13108#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13108: Improve poor Access Violation reporting on Windows -------------------------------------+------------------------------------- Reporter: awson | Owner: Type: task | Status: patch Priority: normal | Milestone: Component: Runtime System | Version: Resolution: | Keywords: Operating System: Windows | Architecture: Type of failure: Poor/confusing | Unknown/Multiple error message | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2969 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ryan Scott <ryan.gl.scott@…>): In [changeset:"c13151e5ac774d38d7c5a807692851022c18fe6b/ghc" c13151e/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="c13151e5ac774d38d7c5a807692851022c18fe6b" Improve access violation reporting on Windows Summary: This patch is courtesy of @awson. Currently, whenever GHC catches a segfault on Windows, it simply reports the somewhat uninformative message `Segmentation fault/access violation in generated code`. This patch adds to the message the type of violation (read/write/dep) and location information, which should help debugging segfaults in the future. Fixes #13108. Test Plan: Build on Windows Reviewers: austin, erikd, bgamari, simonmar, Phyx Reviewed By: bgamari, Phyx Subscribers: awson, thomie, #ghc_windows_task_force Differential Revision: https://phabricator.haskell.org/D2969 GHC Trac Issues: #13108 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13108#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13108: Improve poor Access Violation reporting on Windows -------------------------------------+------------------------------------- Reporter: awson | Owner: Type: task | Status: closed Priority: normal | Milestone: 8.2.1 Component: Runtime System | Version: Resolution: fixed | Keywords: Operating System: Windows | Architecture: Type of failure: Poor/confusing | Unknown/Multiple error message | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2969 Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * status: patch => closed * resolution: => fixed * milestone: => 8.2.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13108#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC