[GHC] #10638: quoting and Template Haskell handling for prim and javascript foreign imports broken
#10638: quoting and Template Haskell handling for prim and javascript foreign imports broken -------------------------------------+------------------------------------- Reporter: luite | Owner: Type: bug | Status: new Priority: normal | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Blocked By: Test Case: | Related Tickets: Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- In GHC 7.10.1, Template Haskell support was added for all calling conventions. Unfortunately a few cases are unhandled, which makes the TH code treat the `prim` and `javascript` calling conventions as if they were C calling conventions, adding the `static` keyword and running them through `parseCImport`. This is particularly bad for `javascript` imports, since most JS imports aren't valid C imports, so they get rejected. I'm testing a fix for this that I'll submit later today. I hope this is in time for 7.10.2 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10638 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10638: quoting and Template Haskell handling for prim and javascript foreign imports broken -------------------------------------+------------------------------------- Reporter: luite | Owner: Type: bug | Status: new Priority: normal | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D1070 -------------------------------------+------------------------------------- Changes (by luite): * differential: => Phab:D1070 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10638#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10638: quoting and Template Haskell handling for prim and javascript foreign imports broken -------------------------------------+------------------------------------- Reporter: luite | Owner: Type: bug | Status: new Priority: highest | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D1070 -------------------------------------+------------------------------------- Changes (by hvr): * priority: normal => highest -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10638#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10638: quoting and Template Haskell handling for prim and javascript foreign imports broken -------------------------------------+------------------------------------- Reporter: luite | Owner: Type: bug | Status: patch Priority: highest | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D1070 -------------------------------------+------------------------------------- Changes (by hvr): * status: new => patch -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10638#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10638: quoting and Template Haskell handling for prim and javascript foreign imports broken -------------------------------------+------------------------------------- Reporter: luite | Owner: Type: bug | Status: patch Priority: highest | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D1070 -------------------------------------+------------------------------------- Comment (by bgamari): The backported patch has been merged to `ghc-7.10` as 98587f0c34b15ed307a9a6f8ebc50fb5339b4042. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10638#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10638: quoting and Template Haskell handling for prim and javascript foreign
imports broken
-------------------------------------+-------------------------------------
Reporter: luite | Owner:
Type: bug | Status: patch
Priority: highest | Milestone: 7.10.2
Component: Compiler | Version: 7.10.1
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Revisions: Phab:D1070
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#10638: quoting and Template Haskell handling for prim and javascript foreign imports broken -------------------------------------+------------------------------------- Reporter: luite | Owner: Type: bug | Status: closed Priority: highest | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D1070 -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10638#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10638: quoting and Template Haskell handling for prim and javascript foreign imports broken -------------------------------------+------------------------------------- Reporter: luite | Owner: Type: bug | Status: closed Priority: highest | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D1070 -------------------------------------+------------------------------------- Comment (by simonpj): Is there a regression test for this? Simon -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10638#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10638: quoting and Template Haskell handling for prim and javascript foreign imports broken -------------------------------------+------------------------------------- Reporter: luite | Owner: Type: bug | Status: closed Priority: highest | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D1070 -------------------------------------+------------------------------------- Comment (by luite): Yes it's part of D1070, but it's not backported to the 7.10 branch. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10638#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10638: quoting and Template Haskell handling for prim and javascript foreign imports broken -------------------------------------+------------------------------------- Reporter: luite | Owner: Type: bug | Status: closed Priority: highest | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: th/T10638 Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D1070 -------------------------------------+------------------------------------- Changes (by thomie): * testcase: => th/T10638 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10638#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC