[GHC] #11003: Suggested fix for incorrect directory permissions is wrong
#11003: Suggested fix for incorrect directory permissions is wrong -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: Type: bug | Status: new Priority: high | Milestone: 7.10.3 Component: GHCi | Version: 7.10.2 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Incorrect Unknown/Multiple | warning at compile-time Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- If the current directory is group- or world- writable, I get an error {{{ *** WARNING: /home/blahblah/src/yproj is writable by someone else, IGNORING! Suggested fix: execute 'chmod 644 /home/blahblah/src/yproj' }}} This is extremely bad advice, because `644 = rw-r--r--`, meaning the directory is not executable, so nothing it contains can be accessed, and a user who's insufficiently familiar with Unix permissions will be very confused. The message should instead suggest `755=rwxr-xr-x`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11003> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11003: Suggested fix for incorrect directory permissions is wrong -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: Type: bug | Status: patch Priority: high | Milestone: 7.10.3 Component: GHCi | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1350 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D1350 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11003#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11003: Suggested fix for incorrect directory permissions is wrong -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: Type: bug | Status: patch Priority: high | Milestone: 7.10.3 Component: GHCi | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: #8248 | Differential Rev(s): Phab:D1350 Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * related: => #8248 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11003#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11003: Suggested fix for incorrect directory permissions is wrong -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: Type: bug | Status: patch Priority: high | Milestone: 7.10.3 Component: GHCi | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: #8248 | Differential Rev(s): Phab:D1350 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"0ae6a43ebccca65c3a6b6172e0513802d303e84e/ghc" 0ae6a43/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="0ae6a43ebccca65c3a6b6172e0513802d303e84e" Suggest chmod 755 instead of 644 Previous suggestion would clear executable bit, meaning directory couldn't be entered. Fixes #11003. Test Plan: Read message. Reviewers: austin, thomie, dfeuer Reviewed By: thomie, dfeuer Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D1350 GHC Trac Issues: #11003 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11003#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11003: Suggested fix for incorrect directory permissions is wrong -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: Type: bug | Status: closed Priority: high | Milestone: 7.10.3 Component: GHCi | Version: 7.10.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: #8248 | Differential Rev(s): Phab:D1350 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11003#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11003: Suggested fix for incorrect directory permissions is wrong -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: Type: bug | Status: closed Priority: high | Milestone: 7.10.3 Component: GHCi | Version: 7.10.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: #8248 | Differential Rev(s): Phab:D1350 Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Also merging to `ghc-7.10`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11003#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC