[GHC] #15475: Plugin recompilation check still panics
#15475: Plugin recompilation check still panics -------------------------------------+------------------------------------- Reporter: mpickering | Owner: (none) Type: bug | Status: new Priority: highest | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- I get a panic as follows when trying to use a plugin with the latest commit on the 8.6 branch. {{{ <no location info>: error: ghc: panic! (the 'impossible' happened) (GHC version 8.6.1.20180803 for x86_64-unknown-linux): mkPluginUsage: file not found LiftPlugin /nix/store/q8rg4mca5zqv98arpxd7164pqa72hf1n-ncurses-6.1/lib /libHSlift-plugin-0.1.0.0-LpWZumtLigSEjndVxGCyUH-ghc8.6.1.20180803.so Call stack: CallStack (from HasCallStack): callStackDoc, called at compiler/utils/Outputable.hs:1164:37 in ghc:Outputable pprPanic, called at compiler/deSugar/DsUsage.hs:215:15 in ghc:DsUsage Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug }}} My example is nixified and not very minimal but I can provide it tomorrow if that would help. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15475> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15475: Plugin recompilation check still panics -------------------------------------+------------------------------------- Reporter: mpickering | Owner: (none) Type: bug | Status: new Priority: highest | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by mpickering): Repro: {{{ git clone -b plugin https://github.com/LightAndLight/typed-cfg.git cachix use mpickering nix-shell cabal build }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15475#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15475: Plugin recompilation check still panics -------------------------------------+------------------------------------- Reporter: mpickering | Owner: (none) Type: bug | Status: patch Priority: highest | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5048 Wiki Page: | -------------------------------------+------------------------------------- Changes (by darchon): * status: new => patch * differential: => Phab:D5048 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15475#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15475: Plugin recompilation check still panics -------------------------------------+------------------------------------- Reporter: mpickering | Owner: (none) Type: bug | Status: patch Priority: highest | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5048 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Krzysztof Gogolewski <krz.gogolewski@…>): In [changeset:"b324c5624432f2c3d5b0a689fdff75a1ccc563f5/ghc" b324c562/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="b324c5624432f2c3d5b0a689fdff75a1ccc563f5" Filter plugin dylib locations Summary: Previously we just created a cartesian product of the library paths of the plugin package and the libraries of the package. Of course, some of these combinations result in a filepath of a file doesn't exists, leading to #15475. Instead of making `haskFile` return Nothing in case a file doesn't exist (which would hide errors), we look at all the possible dylib locations and ensure that at least one of those locations is an existing file. If the list turns out to be empty however, we panic. Reviewers: mpickering, bgamari Reviewed By: mpickering Subscribers: monoidal, rwbarton, carter GHC Trac Issues: #15475 Differential Revision: https://phabricator.haskell.org/D5048 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15475#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15475: Plugin recompilation check still panics -------------------------------------+------------------------------------- Reporter: mpickering | Owner: (none) Type: bug | Status: merge Priority: highest | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5048 Wiki Page: | -------------------------------------+------------------------------------- Changes (by monoidal): * status: patch => merge -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15475#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15475: Plugin recompilation check still panics -------------------------------------+------------------------------------- Reporter: mpickering | Owner: (none) Type: bug | Status: closed Priority: highest | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5048 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed Comment: Merged with 13105a1ae870da6936a27cdd1d6a4bd25a661368. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15475#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC