slightly modified hasktags version / Who can commit it?

I've hacked on hasktags again http://mawercer.de/hasktags.hs I'd like to merge changes into the ghc distribution or ask someone to do so. changes: a) full qualified module names are added as well now b) hack: removed empty tokens so that getcons finds [..] rqBody :: RqBody, [..] c) ctag files are sorted now testcase : ============= ======================================================= -- module name should be found module A.B.testcase where -- Request, Request2 -- rqMethod, rqBody, rqPeer should be found as well data Request = Request2 { rqMethod::Method, rqBody :: RqBody, rqPeer :: Host } deriving(Show,Read,Typeable) ============= ======================================================= hasktags distributed with ghc (6.8.2): Request testcase.hs 6 Request2 testcase.hs 6 rqMethod testcase.hs 6 testcase.hs 7 <<< name is missing testcase.hs 8 <<< name is missing my modified version: A.B.testcase testcase.hs 2 <<< module name added Request2 testcase.hs 6 Request testcase.hs 6 rqMethod testcase.hs 6 rqBody testcase.hs 7 rqPeer testcase.hs 8

Marc Weber wrote:
I've hacked on hasktags again http://mawercer.de/hasktags.hs I'd like to merge changes into the ghc distribution or ask someone to do so.
changes: a) full qualified module names are added as well now b) hack: removed empty tokens so that getcons finds [..] rqBody :: RqBody, [..] c) ctag files are sorted now
Have you fixed this? http://hackage.haskell.org/trac/ghc/ticket/1184 Would you mind opening a ticket, or using 'darcs send' to send us a patch? Cheers, Simon

Hi Simon, thanks for pointing me to the ticket (therby telling me that hasktags was not really usable before ?). The ticket can be marked as fixed now I hope. I've tried enhancing it but I don't know wether it still finds everyting in all cases. So more testing is needed. I've included a small testcase within comments which shows that the patch enables hasktags to find twice as much tags as before (type annotations and implementations) Maybe you, Ian or sb. else can apply this patch as well? http://mawercer.de/hasktags_patch2 Sincerly Marc

Now there is http://mawercer.de/hasktags_patch3 (fixed exhausted pattern match when processing literate haskell files) No aborts while tagging the core libraries, some extra libraries and HAppS libs. (45 packages tested)

Hi Marc, On Sun, Feb 17, 2008 at 03:04:59AM +0100, Marc Weber wrote:
Now there is http://mawercer.de/hasktags_patch3
Thanks for the patches, but unfortunately hasktags doesn't build with them. If you want to test building it without building the whole of GHC then I think this should work: autoreconf ./configure cd utils/hasktags/ make depend make Thanks Ian

Hi Ian, thanks for your feedback. I should have taken more care. change line 198 let (tokenLines :: [[Token]]) = to let tokenLines May I ask you to (amend-)record it? I don't mind wether darcs lists me as author of this tiny minor fix. Or is it easier for you to apply another patch? Marc W.

Hi Marc, On Tue, Feb 12, 2008 at 06:38:05PM +0100, Marc Weber wrote:
I've hacked on hasktags again http://mawercer.de/hasktags.hs I'd like to merge changes into the ghc distribution or ask someone to do so.
Thanks! I assume that this is the same as http://mawercer.de/hasktags_patch in which case I've applied it. Thanks Ian
participants (3)
-
Ian Lynagh
-
Marc Weber
-
Simon Marlow