Re: Permitting trailing commas for record syntax ADT declarations
Richard Eisenberg <eir@cis.upenn.edu> writes:
What if we just stopped requiring commas in import/export lists? As far as I can tell, they're not necessary for proper parsing.
+1 John
That would be nice if we had a clean slate, but I don't people are going to change their whole import lists now. Adding a comma at the end is less disruptive. On Fri, Sep 26, 2014 at 11:06 PM, John Wiegley <johnw@newartisans.com> wrote:
Richard Eisenberg <eir@cis.upenn.edu> writes:
What if we just stopped requiring commas in import/export lists? As far as I can tell, they're not necessary for proper parsing.
+1
John _______________________________________________ Glasgow-haskell-users mailing list Glasgow-haskell-users@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-users
On Fri, Sep 26, 2014 at 5:12 PM, Johan Tibell <johan.tibell@gmail.com> wrote:
That would be nice if we had a clean slate, but I don't people are going to change their whole import lists now.
I read the proposal as making all commas optional, not as requiring them to not be present. -- brandon s allbery kf8nh sine nomine associates allbery.b@gmail.com ballbery@sinenomine.net unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net
I don't think that's necessarily is good style. I don't think we want two different ways of doing import lists. The original proposal was to address a quite small but important engineer issue: without allow *one* trailing comma your version control history gets messed up, because the wrong person gets "blamed" for a line of code. The standard programming language way of solving that problem is to allow a trailing comma. On Fri, Sep 26, 2014 at 11:16 PM, Brandon Allbery <allbery.b@gmail.com> wrote:
On Fri, Sep 26, 2014 at 5:12 PM, Johan Tibell <johan.tibell@gmail.com> wrote:
That would be nice if we had a clean slate, but I don't people are going to change their whole import lists now.
I read the proposal as making all commas optional, not as requiring them to not be present.
-- brandon s allbery kf8nh sine nomine associates allbery.b@gmail.com ballbery@sinenomine.net unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net
On Fri, Sep 26, 2014 at 5:21 PM, Johan Tibell <johan.tibell@gmail.com> wrote:
I don't think that's necessarily is good style. I don't think we want two different ways of doing import lists.
Yes; I kinda hate the idea myself, it encourages an unreadable programming style. But it's not the wholesale breaking change you were suggesting, either. -- brandon s allbery kf8nh sine nomine associates allbery.b@gmail.com ballbery@sinenomine.net unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net
To be fair, I'm not sure I like the make-commas-optional approach either. But, the solution occurred to me as possible, so I thought it was worth considering as we're exploring the design space. And, yes, I was suggesting only to make them optional, not to require everyone remove them. Richard On Sep 26, 2014, at 5:34 PM, Brandon Allbery <allbery.b@gmail.com> wrote:
On Fri, Sep 26, 2014 at 5:21 PM, Johan Tibell <johan.tibell@gmail.com> wrote: I don't think that's necessarily is good style. I don't think we want two different ways of doing import lists.
Yes; I kinda hate the idea myself, it encourages an unreadable programming style. But it's not the wholesale breaking change you were suggesting, either.
-- brandon s allbery kf8nh sine nomine associates allbery.b@gmail.com ballbery@sinenomine.net unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net _______________________________________________ Glasgow-haskell-users mailing list Glasgow-haskell-users@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-users
Not a concrete suggestion, but just a related data point / nod to the sanity of the suggestion: I'm not sure I'd remove them entirely either, but FWIW, we don't require commas in fixity declarations in Ermine and it works well. On the other hand, our import lists are rather more complicated than Haskell's due to a need for extensive renaming on import though, so we don't shed the commas, but wind up using layout-based separation there, instead, avoiding conflicts by another means. That ship, however, has sailed for Haskell. ;) -Edward On Mon, Sep 29, 2014 at 9:27 AM, Richard Eisenberg <eir@cis.upenn.edu> wrote:
To be fair, I'm not sure I like the make-commas-optional approach either. But, the solution occurred to me as possible, so I thought it was worth considering as we're exploring the design space.
And, yes, I was suggesting only to make them optional, not to require everyone remove them.
Richard
On Sep 26, 2014, at 5:34 PM, Brandon Allbery <allbery.b@gmail.com> wrote:
On Fri, Sep 26, 2014 at 5:21 PM, Johan Tibell <johan.tibell@gmail.com> wrote:
I don't think that's necessarily is good style. I don't think we want two different ways of doing import lists.
Yes; I kinda hate the idea myself, it encourages an unreadable programming style. But it's not the wholesale breaking change you were suggesting, either.
-- brandon s allbery kf8nh sine nomine associates allbery.b@gmail.com ballbery@sinenomine.net unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net _______________________________________________ Glasgow-haskell-users mailing list Glasgow-haskell-users@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-users
_______________________________________________ Glasgow-haskell-users mailing list Glasgow-haskell-users@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-users
participants (5)
-
Brandon Allbery -
Edward Kmett -
Johan Tibell -
John Wiegley -
Richard Eisenberg