
On Tue, Jan 13, 2009 at 5:45 PM, Phil
mcSimulate :: Double -> Double -> Word64 -> [Dou ble] mcSimulate startStock endTime seedForSeed = fst expiryStock : mcSimulate startStock endTime newSeedForSeed
It is abundantly clear that the startStock and endTime are just being passed around from call to call unchanged – that is their value is constant throughout the the simulation. For the purposes here when I'm only passing 2 'constants' around it doesn't strike me as too odd, but my list of 'constants' is likely to grow as I bolt more functionality onto this. For readability, I understand that I can create new types to encapsulate complex data types into a single type , but I can't help thinking that passing say 9 or 10 'constants' around and around like this 'feels wrong'. If I sit back and think about it, it doesn't strike me as implausible that the compiler will recognize what I'm doing and optimize this out for me, and what I'm doing is thinking about the whole think like a C++ programmer (which I traditionally am) would.
You can factor out constants in a couple ways. If you are just passing constants between a recursive call to the same function, you can factor out the recursive bit into a separate function: something param1 param2 = go where go = ... param1 ... param2 ... etc ... go ... etc = ... Where go takes only the parameters that change, and the rest is handled by its enclosing scope. You might buy a little performance this way too, depending on the compiler's cleverness (I'm not sure how it optimizes these things). If you are passing around many constants between functions, first package them all up in a record data type: data Params = Params { parmFoo :: Int, parmBar :: Double, ... } At this point it is pretty easy just to pass a Parms object around. If you really hate the explicit style, though, you can throw your computation into a Reader Parms (Reader is the monad precisely for this: adding a constant parameter to every function), and then use eg. asks parmFoo to get parameters out. And if none of those strike your fancy, you can look into GHC's "implicit arguments" extension. But that seems to be in the process of a phase out by the community (nothing explicit, it's just that nobody is using them anymore). Luke
However before I allayed my own concerns I wanted to check that in the Haskell world passing around lots of parameters isn't a bad thing – that is, I'm not missing a trick here to make my code more readable or more importantly more performant.
Thanks again,
Phil.
On 13/01/2009 23:24, "Luke Palmer"
wrote: On Tue, Jan 13, 2009 at 3:29 PM, Phil
wrote: My only concern with using this method is - Will 'iterate' not create a full list of type [Double] and then take the final position once the list has been fully realized? For my application this would be undesirable as the list may be millions of items long, and you only ever care about the last iteration (It's a crude Monte Carlo simulator to give it some context). If Haskell is smart enough to look ahead and see as we only need the last element as it is creating the list, therefore garbage collecting earlier items then this would work fine - by I'm guessing that is a step to far for the compiler?
No, doing this type of thing is very typical Haskell, and the garbage collector *will* incrementally throw away early elements of the list.
I had originally implemented this similar to the above (although I didn't know about the 'iterate' keyword
FWIW, iterate is just a function, not a keyword. Could just be terminology mismatch.
So, while the garbage collector will do the right thing, for a list millions of elements long, I suspect you will get stack overflows and/or bad memory performance because the computation is too lazy. One solution is to use a stricter version of !!, which evaluates elements of the list as it whizzes by them. Because the function you're iterating is strict to begin with, you do not lose performance by doing this:
strictIdx :: Int -> [a] -> a strictIdx _ [] = error "empty list" strictIdx 0 (x:xs) = x strictIdx n (x:xs) = x `seq` strictIdx (n-1) xs
(Note that I flipped the arguments, to an order that is nicer for currying)
The reason is that iterate f x0 constructs a list like this:
[ x0, f x0, f (f x0), f (f (f x0)), ... ]
But shares the intermediate elements, so if we were to evaluate the first f x0 to, say, 42, then the thunks are overwritten and become:
[ x0, 42, f 42, f (f 42), ... ]
So iterate f x0 !! 1000000 is f (f (f (f ( ... a million times ... f x0)))), which will be a stack overflow because of each of the calls. What strictIdx does is to evaluate each element as it traverses it, so that each call is only one function deep, then we move on to the next one.
This is the laziness abstraction leaking. Intuition about it develops with time and experience. It would be great if this leak could be patched by some brilliant theorist somewhere.
Luke
- which makes things tidier - a useful tip!), I moved to using the state monad and replicateM_ for the first truncate(endTime/timeStep)-1 elements so that everything but the last result is thrown away, and a final bind to getEvolution would return the result.
Now that the code has been modified so that no result is passed back, using modify and execState, this can be simplified to "replicateM_ truncate(endTime/timeStep)" with no final bind needed. I've tried this and it works fine.
The key reason for using the Monad was to tell Haskell to discard all but the current state. If I'm wrong about please let me know, as I don't want to be guilty of overcomplicating my algorithm, and more importantly it means I'm not yet totally grasping the power of Haskell!
Thanks again,
Phil.
On 13/01/2009 03:13, "David Menendez"
wrote: Thanks Minh - I've updated my code as you suggested. This looks better
On Mon, Jan 12, 2009 at 8:34 PM, Phil
wrote: than my first attempt!
Is it possible to clean this up any more? I find:
( (), (Double, Word64) )
a bit odd syntactically, although I understand this is just to fit the type to the State c'tor so that we don't have to write our own Monad longhand.
If you have a function which transforms the state, you can lift it into the state monad using "modify".
evolveUnderlying :: (Double, Word64) -> (Double, Word64) evolveUnderlying (stock, state) = ( newStock, newState ) where newState = ranq1Increment state newStock = stock * exp ( ( ir - (0.5*(vol*vol)) )*timeStep + ( vol*sqrt(timeStep)*normalFromRngState(state) ) )
getEvolution :: State (Double, Word64) () getEvolution = modify evolveUnderlying
Now, I don't know the full context of what you're doing, but the example you posted isn't really gaining anything from the state monad. Specifically,
execState (replicateM_ n (modify f)) = execState (modify f >> modify f >> ... >> modify f) = execState (modify (f . f . ... . f)) = f . f . ... . f
So you could just write something along these lines,
mcSimulate :: Double -> Double -> Word64 -> [Double] mcSimulate startStock endTime seedForSeed = fst expiryStock : mcSimulate startStock endTime newSeedForSeed where expiryStock = iterate evolveUnderlying (startStock, ranq1Init seedForSeed) !! truncate (endTime/timeStep) newSeedForSeed = seedForSeed + 246524
Coming back to your original question, it is possible to work with nested state monad transformers. The trick is to use "lift" to make sure you are working with the appropriate state.
get :: StateT s1 (State s2) s1 put :: s1 -> StateT s1 (State s2) ()
lift get :: StateT s1 (State s2) s2 lift put :: s2 -> StateT s1 (State s2) ()
A more general piece of advice is to try breaking things into smaller pieces. For example:
getRanq1 :: MonadState Word64 m => m Word64 getRanq1 = do seed <- get put (ranq1Increment seed) return seed
getEvolution :: StateT Double (State Word64) () getEvolution = do seed <- lift getRanq1 modify $ \stock -> stock * exp ( ( ir - (0.5*(vol*vol)) )*timeStep + ( vol*sqrt(timeStep)*normalFromRngState(seed) ) )
_______________________________________________ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe