
On 09/22/2011 02:00 AM, Felipe Almeida Lessa wrote:
On Wed, Sep 21, 2011 at 5:19 PM, Vincent Hanquez
wrote: Also, it seems that cryptohash's Skein is currently broken. The skein package comes with the "golden" KATs sent by the Skein team to the NIST, and passes everything. OTOH, cryptohash's Skein256/Skein512 do not agree with skein's Skein_256_256/Skein_512_512. I've attached a test suite that quickchecks if both implementations give the same answer. My hunch is that you are using the wrong constants, because the first test case (the empty string) already fails: oops darn, thanks for reporting. i'll have a look at that ASAP; It used to work in the past, and i've copied some expected values from the original implementation in my small unit tests (which still pass :-/ ), so i'm a bit puzzle here. Perhaps you have implemented some old version of Skein? I know they have changed the constants some times in the past. yeah that was it. looks like 2 minor revisions were made when i wasn't looking (only the parity constant has change from 0x55.. to 0x19..).
Seems that everything is back in order now, but i'll make sure i put cryptohash's skein under the full KAT test suite in a near future. Thanks, -- Vincent