Define variable types

newer
Re: [Haskell-cafe] Bytestrings vs...

older
Crash using GHCi and GHC API under...

Tsunkiet Man

5 Feb 2009 5 Feb '09

6:37 a.m.

Hello, I'm new to Haskell and it seems like a very nice language to learn. However I'm not really familiar with the errormessages it produces. I am using a Helium interpreter. I've created the following module (however it is just a small sketch). I've written the following code: fac :: Int -> Int fac n = product[1..n] boven :: Int -> Int -> Int boven n k = (fac n) `div` fac k * fac (n-k) bin :: Int -> Int -> Int -> Int bin n k p |(n-k)>0 && k>0 = (boven n k) * (p^k) * (1-p)^(n-k) |(n-k)<0 && k>0 = (boven n k) * (p^k) * (1/((1-p)^(-(n-k)))) |(n-k)<0 && k<0 = (boven n k) * (1/(p^(-k))) * (1/((1-p)^(-(n-k)))) When I load this into my interpreter it says: Compiling ./Test.hs (11,55): Type error in infix application expression : 1 / ((1 - p) ^ (-(n - k))) operator : / type : Float -> Float -> Float does not match : Int -> Int -> Int (12,47): Type error in infix application expression : 1 / (p ^ (-k)) operator : / type : Float -> Float -> Float does not match : Int -> Int -> a (12,62): Type error in infix application expression : 1 / ((1 - p) ^ (-(n - k))) operator : / type : Float -> Float -> Float does not match : Int -> Int -> a Compilation failed with 3 errors Some details that might be usefull: Line 11 is |(n-k)<0 && k>0 = (boven n k) * (p^k) * (1/((1-p)^(-(n-k)))) Line 12 is |(n-k)<0 && k<0 = (boven n k) * (1/(p^(-k))) * (1/((1-p)^(-(n-k)))) So my question is: how can I fix these errors? (I used these lines of codes because it is not possible to use a negative exponent in the Helium interpreter.) Thank you for answering my question! Greetings JTKM

Attachments:

attachment.html (text/html — 2.9 KB)

Show replies by date

Roman Cheplyaka

5 Feb 5 Feb

6:57 a.m.

* Tsunkiet Man [2009-02-05 12:37:22+0100]

...

Hello,

I'm new to Haskell and it seems like a very nice language to learn. However I'm not really familiar with the errormessages it produces. I am using a Helium interpreter. I've created the following module (however it is just a small sketch). I've written the following code:

fac :: Int -> Int fac n = product[1..n]

boven :: Int -> Int -> Int boven n k = (fac n) `div` fac k * fac (n-k)

bin :: Int -> Int -> Int -> Int bin n k p |(n-k)>0 && k>0 = (boven n k) * (p^k) * (1-p)^(n-k) |(n-k)<0 && k>0 = (boven n k) * (p^k) * (1/((1-p)^(-(n-k)))) |(n-k)<0 && k<0 = (boven n k) * (1/(p^(-k))) * (1/((1-p)^(-(n-k))))

When I load this into my interpreter it says:

Compiling ./Test.hs (11,55): Type error in infix application expression : 1 / ((1 - p) ^ (-(n - k))) operator : / type : Float -> Float -> Float does not match : Int -> Int -> Int (12,47): Type error in infix application expression : 1 / (p ^ (-k)) operator : / type : Float -> Float -> Float does not match : Int -> Int -> a (12,62): Type error in infix application expression : 1 / ((1 - p) ^ (-(n - k))) operator : / type : Float -> Float -> Float does not match : Int -> Int -> a

You can't use fractional division (/) with integers. You can convert integers to fractions using fromIntegral. E.g.: 1 / fromIntegral ((1 - p) ^ (-(n - k))) (literals like 1 doesn't need to be converted because they are polymorphic) -- Roman I. Cheplyaka :: http://ro-che.info/ "Don't let school get in the way of your education." - Mark Twain

Miguel Mitrofanov

7:21 a.m.

Note also that Helium ISN'T Haskell; it lacks hell of a lot of Haskell98 features (not to mention common extensions). 05.02.09, 14:57, "Roman Cheplyaka" :

...

...
Hello,

I'm new to Haskell and it seems like a very nice language to learn. However I'm not really familiar with the errormessages it produces. I am using a Helium interpreter. I've created the following module (however it is just a small sketch). I've written the following code:

fac :: Int -> Int fac n = product[1..n]

boven :: Int -> Int -> Int boven n k = (fac n) `div` fac k * fac (n-k)

bin :: Int -> Int -> Int -> Int bin n k p |(n-k)>0 && k>0 = (boven n k) * (p^k) * (1-p)^(n-k) |(n-k)<0 && k>0 = (boven n k) * (p^k) * (1/((1-p)^(-(n-k)))) |(n-k)<0 && k<0 = (boven n k) * (1/(p^(-k))) * (1/((1-p)^(-(n-k))))

When I load this into my interpreter it says:

Compiling ./Test.hs (11,55): Type error in infix application expression : 1 / ((1 - p) ^ (-(n - k))) operator : / type : Float -> Float -> Float does not match : Int -> Int -> Int (12,47): Type error in infix application expression : 1 / (p ^ (-k)) operator : / type : Float -> Float -> Float does not match : Int -> Int -> a (12,62): Type error in infix application expression : 1 / ((1 - p) ^ (-(n - k))) operator : / type : Float -> Float -> Float does not match : Int -> Int -> a You can't use fractional division (/) with integers. You can convert integers to fractions using fromIntegral. E.g.: 1 / fromIntegral ((1 - p) ^ (-(n - k))) (literals like 1 doesn't need to be converted because they are

* Tsunkiet Man [2009-02-05 12:37:22+0100] polymorphic) -- Roman I. Cheplyaka :: http://ro-che.info/ "Don't let school get in the way of your education." - Mark Twain _______________________________________________ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe

Daniel Fischer

7:16 a.m.

Am Donnerstag, 5. Februar 2009 12:37 schrieb Tsunkiet Man:

...

Hello,

I'm new to Haskell and it seems like a very nice language to learn. However I'm not really familiar with the errormessages it produces. I am using a Helium interpreter. I've created the following module (however it is just a small sketch). I've written the following code:

fac :: Int -> Int fac n = product[1..n]

boven :: Int -> Int -> Int boven n k = (fac n) `div` fac k * fac (n-k)

You want parentheses there: boven n k = fac n `div` (fac k * fac (n-k))

...

bin :: Int -> Int -> Int -> Int bin n k p |(n-k)>0 && k>0 = (boven n k) * (p^k) * (1-p)^(n-k)

|(n-k)<0 && k>0 = (boven n k) * (p^k) * (1/((1-p)^(-(n-k)))) |(n-k)<0 && k<0 = (boven n k) * (1/(p^(-k))) *

(1/((1-p)^(-(n-k))))

When I load this into my interpreter it says:

Compiling ./Test.hs (11,55): Type error in infix application expression : 1 / ((1 - p) ^ (-(n - k))) operator : / type : Float -> Float -> Float does not match : Int -> Int -> Int (12,47): Type error in infix application expression : 1 / (p ^ (-k)) operator : / type : Float -> Float -> Float does not match : Int -> Int -> a (12,62): Type error in infix application expression : 1 / ((1 - p) ^ (-(n - k))) operator : / type : Float -> Float -> Float does not match : Int -> Int -> a Compilation failed with 3 errors

Some details that might be usefull:

Line 11 is |(n-k)<0 && k>0 = (boven n k) * (p^k) * (1/((1-p)^(-(n-k)))) Line 12 is |(n-k)<0 && k<0 = (boven n k) * (1/(p^(-k))) * (1/((1-p)^(-(n-k))))

So my question is: how can I fix these errors?

Haskell doesn't do automatic type conversion, so you have to explicitly convert from one numerical type to another. Ints can only be divided using div (or quot), not by (/) which is the division operator of Fractional types (Float, Double, Rational...). However, I'm rather convinced the type signature you gave for bin is not what you want, I think p should be a floating point number, as should the resulting probability. That would give the type signature bin :: Int -> Int -> Float -> Float and the use of (/) is then legitimate. But you then must convert the binomial coefficient to a floating point number to be able to multiply it: bin n k p = fromIntegral (boven n k) * p^^k * (1-p)^^(n-k) Note I've used a different exponentiation operator, (^^), which supports negative exponents, thus avoid the branches. Since (^^) is Haskell98, Helium should have it. Another thing is the fact that the factorials will soon overflow using Int, so you should better use Integer and Double instead of Int and Float.

...

(I used these lines of codes because it is not possible to use a negative exponent in the Helium interpreter.)

Thank you for answering my question!

Greetings JTKM

HTH, Daniel

Roel van Dijk

7:23 a.m.

This is not really an answer to your question, but I think you could write a slightly more efficient function to calculate the binomial coefficient: fac :: Integer -> Integer fac n = product [1..n] -- |Product of all positive integers less than or equal to n but -- larger than s facFrom :: Integer -> Integer -> Integer facFrom s n | s > n = if s == 1 then 1 else 0 | otherwise = product [max (s + 1) 1 .. n] boven :: Integer -> Integer -> Integer boven n k = facFrom (n - k) n `div` fac k This exploits the fact that "fac n" contains the computation for "fac (n - k)". 2009/2/5 Tsunkiet Man :

...

Hello,

I'm new to Haskell and it seems like a very nice language to learn. However I'm not really familiar with the errormessages it produces. I am using a Helium interpreter. I've created the following module (however it is just a small sketch). I've written the following code:

fac :: Int -> Int fac n = product[1..n]

boven :: Int -> Int -> Int boven n k = (fac n) `div` fac k * fac (n-k)

bin :: Int -> Int -> Int -> Int bin n k p |(n-k)>0 && k>0 = (boven n k) * (p^k) * (1-p)^(n-k) |(n-k)<0 && k>0 = (boven n k) * (p^k) * (1/((1-p)^(-(n-k)))) |(n-k)<0 && k<0 = (boven n k) * (1/(p^(-k))) * (1/((1-p)^(-(n-k))))

When I load this into my interpreter it says:

Compiling ./Test.hs (11,55): Type error in infix application expression : 1 / ((1 - p) ^ (-(n - k))) operator : / type : Float -> Float -> Float does not match : Int -> Int -> Int (12,47): Type error in infix application expression : 1 / (p ^ (-k)) operator : / type : Float -> Float -> Float does not match : Int -> Int -> a (12,62): Type error in infix application expression : 1 / ((1 - p) ^ (-(n - k))) operator : / type : Float -> Float -> Float does not match : Int -> Int -> a Compilation failed with 3 errors

Some details that might be usefull:

Line 11 is |(n-k)<0 && k>0 = (boven n k) * (p^k) * (1/((1-p)^(-(n-k)))) Line 12 is |(n-k)<0 && k<0 = (boven n k) * (1/(p^(-k))) * (1/((1-p)^(-(n-k))))

So my question is: how can I fix these errors?

(I used these lines of codes because it is not possible to use a negative exponent in the Helium interpreter.)

Thank you for answering my question!

Greetings JTKM _______________________________________________ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe

Martijn van Steenbergen

7:41 a.m.

Hallo Tsunkiet, Looking at http://www.cs.uu.nl/wiki/bin/view/Helium/ATourOfTheHeliumPrelude it seems you're looking for the /. operator, which is division on floating points. The / you're using only works on integers. Groetjes, Martijn. Tsunkiet Man wrote:

...

Hello,

I'm new to Haskell and it seems like a very nice language to learn. However I'm not really familiar with the errormessages it produces. I am using a Helium interpreter. I've created the following module (however it is just a small sketch). I've written the following code:

fac :: Int -> Int fac n = product[1..n]

boven :: Int -> Int -> Int boven n k = (fac n) `div` fac k * fac (n-k)

bin :: Int -> Int -> Int -> Int bin n k p |(n-k)>0 && k>0 = (boven n k) * (p^k) * (1-p)^(n-k) |(n-k)<0 && k>0 = (boven n k) * (p^k) * (1/((1-p)^(-(n-k)))) |(n-k)<0 && k<0 = (boven n k) * (1/(p^(-k))) * (1/((1-p)^(-(n-k))))

When I load this into my interpreter it says:

Compiling ./Test.hs (11,55): Type error in infix application expression : 1 / ((1 - p) ^ (-(n - k))) operator : / type : Float -> Float -> Float does not match : Int -> Int -> Int (12,47): Type error in infix application expression : 1 / (p ^ (-k)) operator : / type : Float -> Float -> Float does not match : Int -> Int -> a (12,62): Type error in infix application expression : 1 / ((1 - p) ^ (-(n - k))) operator : / type : Float -> Float -> Float does not match : Int -> Int -> a Compilation failed with 3 errors

Some details that might be usefull:

Line 11 is |(n-k)<0 && k>0 = (boven n k) * (p^k) * (1/((1-p)^(-(n-k)))) Line 12 is |(n-k)<0 && k<0 = (boven n k) * (1/(p^(-k))) * (1/((1-p)^(-(n-k))))

So my question is: how can I fix these errors?

(I used these lines of codes because it is not possible to use a negative exponent in the Helium interpreter.)

Thank you for answering my question!

Greetings JTKM

------------------------------------------------------------------------

_______________________________________________ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe

5950

Age (days ago)

5950

Last active (days ago)

List overview

Download

5 comments

6 participants

participants (6)

Daniel Fischer
Martijn van Steenbergen
Miguel Mitrofanov
Roel van Dijk
Roman Cheplyaka
Tsunkiet Man