Who can send a patche to vim project?

Hi cafe, Who can send a patche to vim project? I'd like to update vim syntax file (haskell.vim) to fix numeric literals. I read the vim `CONTRIBUTING.md` file [1]. It instructs me to contact the maintainer of each files. In the header of `haskell.vim`, the maintainor of `haskell.vim` is haskell-cafe@ML. [2] Who is the maintainer of `haskell.vim`? I'd like to make fix on numeric literals extension: [3] * BinaryLiterals * HexFloatLiterals * NumericUnderscores I prepared two kinds of patches. * Exact pattern version [4] * Fast (but approximate) pattern version [5] I visually checked patches with the these files [6][7]. Could you send a patch of [4] or [5] to vim project? P.S. I have already sent patches to two projects. * `language-haskell` for atom and linguist [8] You can already use it on atom. Linghist (which is used from github) will apply it soon. * `pygments` [9] It is pending review. [1]: https://github.com/vim/vim/blob/master/CONTRIBUTING.md#syntax-indent-and-oth... [2]: https://github.com/vim/vim/blob/master/runtime/syntax/haskell.vim#L3 [3]: https://github.com/ghc-proposals/ghc-proposals/blob/master/proposals/0009-nu... [4]: https://github.com/vim/vim/compare/master...takenobu-hs:syntax-haskell-liter... [5]: https://github.com/vim/vim/compare/master...takenobu-hs:syntax-haskell-liter... [6]: https://github.com/takenobu-hs/ghc/blob/squashed-numeric-underscores/testsui... [7]: https://github.com/takenobu-hs/ghc/blob/squashed-numeric-underscores/testsui... [8]: https://github.com/atom-haskell/language-haskell/commit/f90eb7d8662493536f54... [9]: https://bitbucket.org/birkenfeld/pygments-main/issues/1399/update-haskell-wi... Regards, Takenobu

Hi cafe,
I'll directly contact the vim-dev maillist :)
Thanks,
Takenobu
2017-12-11 21:16 GMT+09:00 Takenobu Tani
Hi cafe,
Who can send a patche to vim project?
I'd like to update vim syntax file (haskell.vim) to fix numeric literals. I read the vim `CONTRIBUTING.md` file [1]. It instructs me to contact the maintainer of each files. In the header of `haskell.vim`, the maintainor of `haskell.vim` is haskell-cafe@ML. [2] Who is the maintainer of `haskell.vim`?
I'd like to make fix on numeric literals extension: [3] * BinaryLiterals * HexFloatLiterals * NumericUnderscores
I prepared two kinds of patches. * Exact pattern version [4] * Fast (but approximate) pattern version [5]
I visually checked patches with the these files [6][7].
Could you send a patch of [4] or [5] to vim project?
P.S. I have already sent patches to two projects.
* `language-haskell` for atom and linguist [8] You can already use it on atom. Linghist (which is used from github) will apply it soon.
* `pygments` [9] It is pending review.
[1]: https://github.com/vim/vim/blob/master/CONTRIBUTING.md# syntax-indent-and-other-runtime-files [2]: https://github.com/vim/vim/blob/master/runtime/syntax/haskell.vim#L3 [3]: https://github.com/ghc-proposals/ghc-proposals/blob/ master/proposals/0009-numeric-underscores.rst#new-syntax-this-proposal [4]: https://github.com/vim/vim/compare/master...takenobu-hs: syntax-haskell-literal-exact [5]: https://github.com/vim/vim/compare/master...takenobu-hs: syntax-haskell-literal-fast
[6]: https://github.com/takenobu-hs/ghc/blob/squashed-numeric- underscores/testsuite/tests/parser/should_run/NumericUnderscores0.hs [7]: https://github.com/takenobu-hs/ghc/blob/squashed-numeric- underscores/testsuite/tests/parser/should_run/NumericUnderscores1.hs
[8]: https://github.com/atom-haskell/language-haskell/commit/ f90eb7d8662493536f54898e52b4c7b1dc96de41 [9]: https://bitbucket.org/birkenfeld/pygments-main/ issues/1399/update-haskell-with-lexer-for-numeric
Regards, Takenobu

Hi cafe,
I share the results of the patch for numeric literal extensions to vim
porject.
This patch has been released in v.8.0.1402 [1][2][3].
Since v.8.0.1402, you can use syntax highlighting for `BinaryLiterals`,
`HexFloatLiterals` and `NumericUnderscores`.
To the person who sends the next patch.
The patch submit procedure of `haskell.vim` is as follows:
1. Share the contents of the patch to haskell-cafe ML (maintainer).
2. Send pull-request to vim project on github.
P.S.
This syntax highlight on Atom, VScode and Vim are already ready.
Linghist (which is used from github) will apply it at new year release.
Pygments (which is used from trac, readthedocs, pandoc, ...) is pending
review.
[1]: https://github.com/vim/vim/releases/tag/v8.0.1402
[2]:
https://github.com/vim/vim/commit/f0b03c4e98f8a7184d8b4a5d702cbcd602426923#d...
[3]: https://github.com/vim/vim/pull/2455
Regards,
Takenobu
2017-12-12 21:29 GMT+09:00 Takenobu Tani
Hi cafe,
I'll directly contact the vim-dev maillist :)
Thanks, Takenobu
2017-12-11 21:16 GMT+09:00 Takenobu Tani
: Hi cafe,
Who can send a patche to vim project?
I'd like to update vim syntax file (haskell.vim) to fix numeric literals. I read the vim `CONTRIBUTING.md` file [1]. It instructs me to contact the maintainer of each files. In the header of `haskell.vim`, the maintainor of `haskell.vim` is haskell-cafe@ML. [2] Who is the maintainer of `haskell.vim`?
I'd like to make fix on numeric literals extension: [3] * BinaryLiterals * HexFloatLiterals * NumericUnderscores
I prepared two kinds of patches. * Exact pattern version [4] * Fast (but approximate) pattern version [5]
I visually checked patches with the these files [6][7].
Could you send a patch of [4] or [5] to vim project?
P.S. I have already sent patches to two projects.
* `language-haskell` for atom and linguist [8] You can already use it on atom. Linghist (which is used from github) will apply it soon.
* `pygments` [9] It is pending review.
[1]: https://github.com/vim/vim/blob/master/CONTRIBUTING.md#synta x-indent-and-other-runtime-files [2]: https://github.com/vim/vim/blob/master/runtime/syntax/haskell.vim#L3 [3]: https://github.com/ghc-proposals/ghc-proposals/blob/master/ proposals/0009-numeric-underscores.rst#new-syntax-this-proposal [4]: https://github.com/vim/vim/compare/master...takenobu-hs:synt ax-haskell-literal-exact [5]: https://github.com/vim/vim/compare/master...takenobu-hs:synt ax-haskell-literal-fast
[6]: https://github.com/takenobu-hs/ghc/blob/squashed-numeric-und erscores/testsuite/tests/parser/should_run/NumericUnderscores0.hs [7]: https://github.com/takenobu-hs/ghc/blob/squashed-numeric-und erscores/testsuite/tests/parser/should_run/NumericUnderscores1.hs
[8]: https://github.com/atom-haskell/language-haskell/commit/f90e b7d8662493536f54898e52b4c7b1dc96de41 [9]: https://bitbucket.org/birkenfeld/pygments-main/issues/1399/ update-haskell-with-lexer-for-numeric
Regards, Takenobu
participants (1)
-
Takenobu Tani