ignore optimizer phase information for INLINE pragmas as available in GHC
In low-level packages like bytestring and storablevector we have pragmas like {-# INLINE [1] func #-} The attached patch ignores the number, that specifies the optimizer phase where inlining shall happen. Ignoring that information is certainly not the best way, since an "inline only in phase x" may be meant as "better inline too seldom than too often". But this way I might get bytestring compiled without many modifications. At least I like to give a warning, when phase information is ignored, but I could not get that for now. Now when compiling Data.ByteString I am lost at: ./Data/ByteString.hs:1942 - Error: Unknown name: illegalOperationErrorType ./Data/ByteString.hs:1942 - Error: Unknown name: mkIOError cabal: Error: some packages failed to install: bytestring-0.9.1.5 failed during the building phase. The exception was: I don't know what the current state of exceptions in JHC is.
Thanks! Patch applied! John -- John Meacham - ⑆repetae.net⑆john⑈ - http://notanumber.net/
On Sat, 14 Nov 2009, John Meacham wrote:
Thanks! Patch applied!
Where do you apply the patches? 'darcs send' says that I could still submit the recent patches to http://repetae.net/repos/jhc, and http://repetae.net/dw/darcsweb.cgi?r=jhc;a=summary does not show them, too. :-(
On Sat, Nov 14, 2009 at 11:43:28PM +0100, Henning Thielemann wrote:
Where do you apply the patches? 'darcs send' says that I could still submit the recent patches to http://repetae.net/repos/jhc, and http://repetae.net/dw/darcsweb.cgi?r=jhc;a=summary does not show them, too. :-(
The way it works is 'darcs send' will send them to the list, then my mail program flags them for me, once I review them I apply them and push them out, but there could be a delay if I am processing several patches at once. Since your patches were just sent as attachments I didn't see that they were patches at first. But they should be up in the public repo now. Thanks! John -- John Meacham - ⑆repetae.net⑆john⑈ - http://notanumber.net/
participants (2)
-
Henning Thielemann -
John Meacham