November 2017 - Libraries

Deprecating fromIntegral
by Niklas Hambüchen 12 Aug '20

12 Aug '20

This is not a joke. I just found a bug in base (https://ghc.haskell.org/trac/ghc/ticket/14262) import System.IO hWaitForInput stdin 4294968296 This code should wait for 49.something days, but it waits for 1 second. It is caused by a quick use of `fromIntegral` to "convert" `Int -> CInt` (where CInt = Int32), causing an overflow. I argue that `fromIntegral` causes unnoticed data corruption without any warning, and thus are worse than partial functions. In this case, this data corruption occurs in the most fundamental code that we all use and have to rely upon (`base`). So I propose that we add a deprecation pragma to `fromIntegral` (however, keeping it forever, like Java does, as there's no benefit to removing it, we just want that people use safer functions over time), and instead provide a `safeFromIntegral` that can only widen ranges, and one or more `unsafeFromIntegral` or appropriately named functions that can error, wrap, return Maybe, or have whatever desired behaviour when the input value doesn't fit into the output type. For some inspiration, `foundation` provides ideas in that direction: http://hackage.haskell.org/package/basement-0.0.2/docs/Basement-From.html http://hackage.haskell.org/package/basement-0.0.2/docs/Basement-IntegralCon… It is a bit funny how we argue that Haskell is good for high assurance programming, and we build all sorts of fancy constructs to eliminate more run-time errors, when in fact we do worse than C in detecting errors in the most basic types a computer can use, such as converting between 64-bit and 32-bit integers. Let's fix that. It avoids real problems in real production systems that are difficult to debug when they happen (who writes a unit test checking that a timeout of 50 days still works? This is the kind of stuff where you have to rely on -- very basic -- types). I'd like to probe support for such a change before doing any work on it. Niklas

18 58

Removing bitSize
by David Feuer 04 Feb '18

04 Feb '18

The long-deprecated bitSize method of the Bits class is slated to be removed in base-4.11 (GHC 8.4). There is one remaining question: should we replace it with a *function* by that name with a FiniteBits constraint? I don't feel very strongly either way, but Ryan Scott seems in favor and Edward Kmett seems opposed. So it seems best to bring it to the libraries list and let the CLC make the call. If the function is added, it would look like this: bitSize :: FiniteBits a => a -> Int bitSize = finiteBitSize The biggest downside I see is that we might one day want to reuse the name for something with a better type, such as bitSize :: forall proxy a. FiniteBits a => proxy a -> Int bitSize _ = finiteBitSize (undefined :: a) or bitSize :: forall a. FiniteBits a => Tagged a Int bitSize = Tagged (finiteBitSize (undefined :: a)) or (with type applications) bitSize :: forall a. FiniteBits a => Int bitSize = finiteBitSize (undefined :: a) Thanks, David Feuer

5 5

Maintenance of streaming and streaming-bytestring
by Andrew Martin 11 Dec '17

11 Dec '17

David Feuer brought this up two weeks ago [0]. The maintainer of streaming and streaming-bytestring has been unreachable, and provided his continued absence, I would like to become a maintainer of these two libraries. I have put up PRs fixing issues [1] and I've offered on the issue tracker to become a comaintainer [2]. I use this library a lot at work, so I have an interest in keeping it in good shape. [0] https://mail.haskell.org/pipermail/libraries/2017-August/028141.html [1] https://github.com/michaelt/streaming-bytestring/pull/11 [2] https://github.com/michaelt/streaming-bytestring/issues/19 -- -Andrew Thaddeus Martin

6 12

Proposal? foldAlt :: (Foldable t, Alternative f) => t a -> f a
by Fumiaki Kinoshita 29 Nov '17

29 Nov '17

We found this quite useful, but we are not 100% about the name and documentation. -- | Try—in the 'Alternative' sense—to return all the values in a 'Foldable' -- container. -- -- @ -- foldAlt ≡ 'listToMaybe' :: [a] -> 'Maybe' a -- foldAlt ≡ 'maybeToList' :: 'Maybe' a -> [a] -- foldAlt ≡ 'MaybeT' . 'return' :: ('Monad' m) => 'Maybe' a -> 'MaybeT' m a -- foldAlt ≡ 'Pipes.ListT' . 'Pipes.each' :: ('Monad' m) => [a] -> 'Pipes.ListT' m a -- foldAlt ≡ id :: 'Maybe' a -> 'Maybe' a -- @ foldAlt :: (Foldable t, Alternative f) => t a -> f a foldAlt = getAlt . foldMap (Alt . pure) {-# INLINE foldAlt #-} I propose adding this to either `Data.Foldable` or `Control.Applicative`. Any thoughts?

4 3

Monoid Instance for ReaderT
by Andrew Martin 28 Nov '17

28 Nov '17

There's a thread from earlier this year where someone asked about a Monoid instance for ReaderT: https://mail.haskell.org/pipermail/haskell-cafe/2017-March/126588.html Several other people showed interest in the instance, but in the end, the request was dismissed since there are other valid monoid instances for ReaderT. Conseqently, the PR was closed ( https://hub.darcs.net/ross/transformers/issue/38) This final comment ( https://mail.haskell.org/pipermail/haskell-cafe/2017-March/126605.html) concludes with: > In the absence of a principled reason to prefer one over the others and a general consensus, I think it’s better not to choose. This is the point I'd like to argue. There were three possible monoid instances for ReaderT discussed. They are: instance (Applicative m, Monoid a) => Monoid (ReaderT r m a) instance (Alternative m) => Monoid (ReaderT r m a) instance (Monoid (m a)) => Monoid (ReaderT r m a) I believe there is good reason to prefer the first instance over the other two. The third instance requires FlexibleContexts. This takes it outside the realm of Haskell98 and Haskell2010, which the transformers library stays within. In fact, transformers pioneered the Eq1, Ord1, etc. classes that ended up in base specifically to avoid FlexibleContexts, and deviating from this now seems against the spirit of the library, since transformers intends that it is able to be built with any Haskell compiler, not just GHC. The Alternative-based instance is reasonable, but we already have another instance that for ReaderT that is implemented this way: the Alternative instance! Here it is: instance Alternative m => Alternative (ReaderT r m) Here I'm going to loosely adapt an argument that Gabriel Gonzalez makes when defending his Monoid instance for ListT ( https://www.reddit.com/r/haskell/comments/4r5bcj/listtransformer_a_beginner… ): > Also, with the Alternative class the only thing you can do is concatenate collections (there's no way to write the cartesian product because the whole class is higher-kinded) so it's meaning is always unambiguous. However, with the Monoid class there are two possible behaviors (append or cartesian product). Given that the Alternative class has to be append, I prefer to give the Monoid class the other behavior. From the end user's perspective, if you use Alternative you always know exactly what you are getting so there is no disadvantage to using Alternative. > The other reason that it's nice to give the Monoid class the other behavior is that it works really nicely when chaining monoid instances as described in this post. The Alternative instance for ReaderT has to be Alternative-based. There is no way around this. Given that we have two possibilities for the Monoid instance, I would prefer to see the one that gives us something different from an instance we already have. Why is it beneficial to have the different behavior instead of the existing behavior? In part, it's because we now have a greater number of behaviors from the typeclasses that most people are familiar with. Additionally, we actually end up in a better situation when the Monoid instance isn't what we need. Let's consider two scenarios to measure the inconvenience that a user faces when the Monoid instance isn't the one that they want: 1) The Monoid instance for ReaderT, WriterT, StateT, etc. is Monoid-based but we wish are in a scenario where we want the Alternative-based one. 2) The Monoid instance for ReaderT, WriterT, StateT, etc. is Alternative-based but we wish are in a scenario where we want the Monoid-based one. In scenario (1), the workaround is trivial. In Data.Monoid, we have Alt, which recovers a Monoid instance from an Alternative instance: newtype Alt f a = Alt {getAlt :: f a} instance Alternative f => Monoid (Alt f a) where mempty = Alt empty mappend = coerce ((<|>) :: f a -> f a -> f a) The same Alt data type is reusable with ReaderT, WriterT, and StateT to recover the Alternative-based instance we wanted: myActions :: [ReaderT IO ()] runUntilSuccess :: ReaderT IO () runUntilSuccess = coerce (fold (coerce myActions :: [Alt (ReaderT IO) ()])) But what about scenario (2)? Let's say that we now instead want the Monoid-based instance that requires all of the actions to succeed. myActions :: [ReaderT IO ()] runAll :: ReaderT IO () runAll = ... What do we put in place of the ellipsis? We can just write it out by hand, but it would be nicer if this Monoid instance was reusable in some way. Let's say that we introduce a newtype wrapper for the Monoid-based Monoid instance: newtype MonoidReaderT m a = MonoidReaderT ... instance (Applicative m, Monoid a) => Monoid (MonoidReaderT m a) But now if we want something like this for StateT or WriterT, they're going to need their own newtype wrappers as well. That's unfortunate. In scenario (1), we needed a single newtype wrapper (that already exists in base!) to recover everything that we lost. In scenario (2), we need a newtype wrapper per type. So, by providing an instance that gives us more behaviors from haskell's blessed set of typeclasses, we end up in a better situation when we need to recover what we don't have. Finally, and this is the weakest part of my argument since it's pure speculation, I think that the Monoid-based instance is more useful in practice. For some loosely analogous historical precedent, I would point to the Monoid instance for IO. In July 2014, Edward Kmett pointed out that one issue with admitting a Monoid instance for IO was that two possible instances existed ( https://mail.haskell.org/pipermail/glasgow-haskell-users/2014-July/025124.h…) One of them monoidally concatenated the results, and the one was identical to IO's Alternative instance. Sounds familiar. Ultimately though, in November 2014, when Gabriel Gonzalez proposed the instance that monoidally concatenated results, nobody objected ( https://mail.haskell.org/pipermail/libraries/2014-November/024310.html) Every person who responded on the mailing list wanted the Monoid-based instance, not the one that was a copy of Alternative. (And it's always recoverable via Alt in the event that someone does want it). So, and again I want to stress that I consider this a weaker part of the argument since it's more rooted in human preferences rather than logic, I think the Monoid-based instance is just generally more useful in practice. In my own experience, I often have wanted the Monoid-based instances, but I have never wanted the Alternative-based instances With all that said, I would like to ask that the Monoid-based Monoid instances for ReaderT, WriterT, StateT, AccumT, etc. be considered. I would also appreciate any feedback or further discussion of this issue. -- -Andrew Thaddeus Martin

3 5

Storing lifted and unlifted pointer types in the same Array#
by Reiner Pope 20 Nov '17

20 Nov '17

Hi libraries@, In GHC.Prim, it is documented that Array# and ArrayArray# have the same runtime representation. I'd like to exploit this to put unlifted and lifted pointers into the same array (for example, unlifted pointers at even indices and lifted pointers at odd indices). The reason I want to do this is to save some array header words, and also to improve the cache locality of my data, so that a read of a (lifted, unlifted) pointer pair only needs to touch a single cache line rather than two. I believe it is safe to do this (put unlifted and lifted pointers in the same array), as long as I always read at the same liftedness and type that I ran the write at for that index. Can you confirm? Specifically, I'm expecting to use a code pattern like the following, to read an unlifted value from an Array#, by coercing the Array# to ArrayArray#, then doing the unlifted read there: coerceToArrayArray :: Array# a -> ArrayArray# coerceToArrayArray = unsafeCoerce# coerceToUnlifted :: forall (b :: TYPE 'UnliftedRep). ArrayArray# -> b coerceToUnlifted = unsafeCoerce# indexUnliftedFromArray :: forall a (b :: TYPE 'UnliftedRep). Array# a -> Int# -> b indexUnliftedFromArray arr i = coerceToUnlifted (indexArrayArrayArray# (coerceToArrayArray arr) i) Similarly, I'm expecting to do writes by coercing the array to a MutableArrayArray# and doing the writes to that. Reiner

3 2

Proposal: add ordNub somewhere in containers
by Gershom B 13 Nov '17

13 Nov '17

There have been many discussions over the years about adding an efficient order preserving nub somewhere to our core libraries. It always comes down to the same issue: an efficient nub wants to be backed by an efficient `Set`, but the API of the `nub` itself doesn't make reference to any other data structures besides lists. So it feels a bit conceptually strange to put an efficient nub anywhere besides `Data.List` even though it can't go there without inverting our dependency tree in a weird way or inlining an efficient set implementation into the middle of it. Nonetheless, the convenience of having a good `nub` lying around in a core library is undeniable, and after writing the "usual" one in my code for the zillionth time, I decided to raise an issue about it: https://github.com/haskell/containers/issues/439 I was promptly directed here to make a proper proposal. So, here: 1) I propose two new functions, `ordNub` and `intNub` with the standard implementation (from https://github.com/nh2/haskell-ordnub) import qualified Data.Set as Set ordNub :: (Ord a) => [a] -> [a] ordNub l = go Set.empty l where go _ [] = [] go s (x:xs) = if x `Set.member` s then go s xs else x : go (Set.insert x s) xs and the same implementation, but specialized to `Int` and using `IntSet`s. The rationale for the names is that the former has a long history of use in folklore, and the latter is the obvious specialization of it. 2) I propose these functions be added to a new module in the `containers` library: `Data.Containers.ListUtils`. This can also potentially in the future add efficient list intersection, etc. as documented on the above reference link. The rationale for the new module is that it can provide a meaningful home for such functions which operate on lists, but require other data structures to be implemented efficiently... Discussion period: 2 weeks. --Gershom

13 25

Inaccurate docs for atomically
by Andrew Martin 12 Nov '17

12 Nov '17

In the stm package, the docs for atomically read: > You cannot use 'atomically' inside an 'unsafePerformIO' or 'unsafeInterleaveIO'. Any attempt to do so will result in a runtime error. (Reason: allowing this would effectively allow a transaction inside a transaction, depending on exactly when the thunk is evaluated.) This doesn't seem to be true. The following program runs fine: import Control.Monad.STM import Control.Concurrent.STM.TVar import System.IO.Unsafe main :: IO () main = do v <- atomically $ newTVar (7 :: Int) print $ unsafePerformIO $ atomically $ do readTVar v I suspect that the runtime only gives you an error if you actually create a nested transaction. Is my understanding correct? -Andrew Thaddeus Martin

4 6

Pattern synonym that provides `Typeable` constraint
by Baldur Blöndal 11 Nov '17

11 Nov '17

https://github.com/ghc/ghc/blob/4bb54a4522d44a81b2c47233f482 52bd73c38279/testsuite/tests/polykinds/T14270.hs https://github.com/sweirich/dth/blob/2bb0c9aa9adb514b787ea56 295419fae55dc3734/examples/dynamic/DataDynamic.hs This is a pattern synonym to construct but more importantly to deconstruct an explicit `TypeRep a` into a `Typeable a` constraint > asTypeable :: TypeRep a -> Dict (Typeable a) > asTypeable rep = > withTypeable rep > Dict > > pattern Typeable :: () => Typeable a => TypeRep a > pattern Typeable <- (asTypeable -> Dict) > where Typeable = typeRep Similar discussion for SingI [1], same benefits: + (Nice) direct alternative to CPS `withTypeable` + Reusable in other pattern synonyms [1] https://github.com/goldfirere/singletons/issues/273

1 0

ThreadId to Int
by Andrew Martin 01 Nov '17

01 Nov '17

ThreadId has a Show instance that makes uses the FFI to turn a ThreadId to a CInt: instance Show ThreadId where showsPrec d t = showString "ThreadId " . showsPrec d (getThreadId (id2TSO t)) foreign import ccall unsafe "rts_getThreadId" getThreadId :: ThreadId# -> CInt Can getThreadId be exported? This would make it possible to write a Hashable instance for ThreadId, and it would make it possible to use a ThreadId to index into an array (with modulus of course). -Andrew Thaddeus Martin

4 4