April 2018 - Libraries

Re: Proposal: Add a wrapped applicative type to Data.Monoid
by Ryan Scott 11 Apr '18

11 Apr '18

One thing that is not clear to me: is this Ap type intended to be a catch-all for defining instances that are "lifted" through an Applicative? Or are you deliberately restricting that to the Semigroup and Monoid instances? For instance, I noticed that you currently derive Ap's Eq, Ord, Read, and Show instances, which would give: instance Eq (f a) => Eq (Ap f a) instance Ord (f a) => Ord (Ap f a) instance Read (f a) => Read (Ap f a) instance Show (f a) => Show (Ap f a) Would you not want this instead, to be in line with the Semigroup and Monoid instances? instance (Applicative f, Eq a) => Eq (Ap f a) instance (Applicative f, Ord a) => Ord (Ap f a) instance (Applicative f, Read a) => Read (Ap f a) instance (Applicative f, Show a) => Show (Ap f a) I would be fine with either option, but if we should be clear about Ap's intentions when we end up documenting it. Ryan S.

3 3

Remove mtimesDefault or move it to Data.Monoid
by Simon Jakobi 06 Apr '18

06 Apr '18

Hi! I was surprised to find two functions that appear to do the same thing in Data.Semigroup: stimesMonoid :: (Integral b, Monoid a) => b -> a -> a [1] mtimesDefault :: (Integral b, Monoid a) => b -> a -> a [2] Both are essentially versions of the default stimes implementation that allow 0 as a multiplier. I think it's confusing to have two functions with nearly the same semantics but different implementations exported from the same module. As stimesMonoid seems to fit well into the group of different stimes implementations exported from Data.Semigroup, I propose that either 1. mtimesDefault be deleted (after a suitable deprecation period) or (particularly, if there still are plans to make mtimes a member of Monoid) 2. mtimesDefault be moved to Data.Monoid (possibly with a deprecated re-export from Data.Semigroup) In case 2, I also think mtimesDefault should be made an alias of stimesMonoid. Cheers, Simon [1] http://hackage.haskell.org/package/base-4.11.0.0/docs/Data-Semigroup.html#v… [2] http://hackage.haskell.org/package/base-4.11.0.0/docs/Data-Semigroup.html#v…

1 1

Proposal: Add inductively-defined Nat to base
by Daniel Cartwright 06 Apr '18

06 Apr '18

The proposed addition is simple, add the following to base: data Nat = Zero | Succ Nat, i.e. Peano Nats - commonly used along with -XDataKinds. I will list the pros/cons I see below: Pros: - This datatype is commonly defined throughout many packages throughout Hackage. It would be good for it to have a central location - The inductive definition of 'Nat' is useful for correctness (e.g. safeHead :: Vec a (Succ n) -> a; safeHead (Cons a as) = a;) - -XDependentHaskell is likely to bring this into base anyway - I believe that it might be possible to eliminate a Peano Nat at some stage during/after typechecking. I'm not well-versed in GHC implementation, but something along the lines of possibly converting an inductive Nat to a GMP Integer using some sort of specialisation (Succ -> +1)? Another interesting, related approach (and this is a very top-level view, and perhaps not totally sensical) would be something like a function 'f', that given a data structure and a number system, outputs the representation of that data structure in that number system (Nat is isomorphic to List (), so f : List () -> Binary -> BinaryListRep) Cons: - -XDependentHaskell will most likely obviate any benefit brought about by type families defined in base that directly involve Nat - Looking at base, I'm not sure where this would go. Having it in its own module seems a tad strange. I am open to criticism concerning the usefulness of the idea, or if anyone sees a Pro(s)/Con(s) that I am missing.

9 13

Re: Proposal for Data.Graph : Improve graph creation complexity when nodes have "consecutive" keys
by Ivan Lazar Miljenovic 03 Apr '18

03 Apr '18

(Sending this back to the libraries@ list as well.) On 2 April 2018 at 23:59, Olivier S. <olivier.sohn(a)gmail.com> wrote: > > 2018-04-02 14:34 GMT+02:00 Ivan Lazar Miljenovic > <ivan.miljenovic(a)gmail.com>: >> >> On 2 April 2018 at 21:30, Olivier S. <olivier.sohn(a)gmail.com> wrote: >> > >> > Hello, >> > >> > I'm resending this proposal, which is simplified w.r.t the first one, >> > and >> > where I removed a wrong analysis of a benchmark. >> > >> > - Proposal I : Optimize the time complexity of (key -> Maybe Vertex) >> > lookups >> > and graph creation when keys are Integral and consecutive. >> > >> > (The related PR for proposal I is [1], including benchmarks showing the >> > performance improvements.) >> > >> > Currently, (key -> Maybe Vertex) lookups returned by graphFromEdges >> > consist >> > of a binary search on an array, with a time complexity of O(log V) (I >> > will >> > use V for "Count of vertices", E for "Count of edges"). >> >> At the risk of bikeshedding, can you please use |V| and |E| to refer >> to the order and size of the graph respectively? > > > Do you mean in the haddock documentation for complexities or here? I don't > know which is mor readable, O( (V+E) * log V ) or O( (|V|+|E|) * log |V| ). > Anyway it would be a quick change in the PR, I'm not particularly attached > to the notation. Both. |V| and |E| are more standard for this, as V and E represent the vertices and edges themselves. >> > When key is Integral, and keys (of nodes passed to the graph creation >> > function) form a set of /consecutive/ values (for example : [4,5,6,7] or >> > [5,6,4,7]), we can have an O(1) lookup by substracting the value of the >> > smallest key, and checking for bounds. >> >> I'm not sure I follow this part; are you ignoring order in these lists >> (you're referring to sets but using list notation)? >> > > I'm not ignoring the order, let me try to give a more precise definition: > > keys is a list of consecutive keys iff it verifies: > > -- (1) keys contains no duplicates > Set.size (Set.fromList keys) == length keys > > -- (2) there is no "gap" between values, when sorted: > sort keys == [minimum keys .. maximum keys] > > > The O(1) lookup is at line 516 of Data/Graph.hs in > https://github.com/haskell/containers/pull/549/files (key_vertex) > >> > >> > Hence, graph creation complexity is improved, and user algorithms using >> > (key >> > -> Maybe Vertex) lookups will see their complexity reduced by a factor >> > of >> > up-to O(log V). >> > >> > The PR introduces this lookup and uses it for functions >> > graphFromEdgesWithConsecutiveKeys and >> > graphFromEdgesWithConsecutiveAscKeys. >> > >> > Here is a summary of complexities for (graph creation, lookup function) >> > as >> > they stand in the current state of the PR: >> > >> > - graphFromEdges (the currently existing function): >> > O( (V+E) * log V ), O(log V) >> > - graphFromEdgesWithConsecutiveKeys (new function): >> > O( E + (V*log V) ), O(1) >> > - graphFromEdgesWithConsecutiveAscKeys (new function) : >> > O( V+E ), O(1) >> > >> > - Proposal II : Deprecate `graphFromEdges` taking [(node, key, [key])] >> > in >> > favor of `graphFromMap` taking (Map key (node,[key])) >> > >> > If we pass the same key twice in the list we pass to 'graphFromEdges' it >> > is >> > undefined which node for that key will actually be used. >> > Introducing 'graphFromMap', taking a (Map key (node,[key]) would >> > alleviate >> > this issue, through the type used. >> >> Off the top of my head, I'm not a big fan of this. If we're going to >> improve this, then I'd prefer to do so in such a way that allowed for >> usage with IntMap > > > Yes, IntMap seems to be better wrt performances than Map. Quoting the doc of > IntMap: > > This data structure performs especially well on binary operations like union > and intersection. However, my benchmarks show that it is also (much) faster > on insertions and deletions when compared to a generic size-balanced map > implementation (see Data.Map). > > >> >> (is there an existing type-class that covers >> association list-style data structures?). > > > > There is the Map type-class (which I just discovered) in : > > https://hackage.haskell.org/package/collections-api-1.0.0.0/docs/Data-Colle… Except that it's in another library ;-) > With instances defined here, but only for Lazy versions Data.Map and > Data.IntMap: Note that the data structures for the Lazy and Strict variants of [Int]Map are the same, it's just the strictness of the functions that operate on them that differ. > > https://hackage.haskell.org/package/collections-base-instances-1.0.0.0/docs… > > Also, the type-class class doesn't have toAscList (or toList) functions > (which is what we would use in the implementation). > > So if we want to rely on this we would need to implement toAscList, and > probably add instances for Strict maps (Data.IntMap.Strict, Data.Map.Strict) > >> >> Ideally you could also use >> HashMap from unordered-containers as well, but since we ultimately >> want `type Vertex = Int` I'm not sure if that's worth it; IntMap, >> however, is. >> > > I see another problem with HashMap : it doesn't provide a toAscList function > where the keys are sorted, so we would have to sort them, incurring a fixed > O(V log V) cost, whereas with Map and IntMap the user has the possibility to > create the map from an ascending list (fromAscList), in O(V) time and we can > get the list back also (toAscList) in O(V) time. > >> > >> > Also, using a Map makes the implementation a bit more "natural" : there >> > is >> > no need for sorting by key, as Map.toAscList gives exactly the sorted >> > list >> > we want. >> > >> > We could also deprecate graphFromEdgesWithConsecutiveKeys and >> > graphFromEdgesWithConsecutiveAscKeys (introduced in proposal I) in favor >> > of >> > graphFromConsecutiveMap. >> > >> > About the naming, I propose two different schemes: >> > >> > Either: >> > - graphFromEdges (takes a List, deprecated, existing >> > function) >> > - graphFromEdgesInMap (takes a Map) >> > - graphFromEdgesInConsecutiveMap (takes a Map with consecutive keys) >> > Or: >> > - graphFromEdges (takes a List, deprecated, existing >> > function) >> > - graphFromMap >> > - graphFromConsecutiveMap >> > with these, to reflect the Map / List duality in the naming scheme: >> > - graphFromList (takes a List, deprecated, redirects >> > to >> > graphFromEdges) >> > - graphFromConsecutiveList (takes a List, deprecated, redirects >> > to >> > graphFromEdgesWithConsecutiveKeys) >> > - graphFromConsecutiveAscList (takes a List, deprecated, redirects >> > to >> > graphFromEdgesWithConsecutiveAscKeys) >> > >> > Cheers, >> > Olivier Sohn >> > >> > [1] https://github.com/haskell/containers/pull/549 >> > >> > >> > _______________________________________________ >> > Libraries mailing list >> > Libraries(a)haskell.org >> > http://mail.haskell.org/cgi-bin/mailman/listinfo/libraries >> > >> >> >> >> -- >> Ivan Lazar Miljenovic >> Ivan.Miljenovic(a)gmail.com >> http://IvanMiljenovic.wordpress.com > > -- Ivan Lazar Miljenovic Ivan.Miljenovic(a)gmail.com http://IvanMiljenovic.wordpress.com

2 7

Proposal for Data.Graph : Improve graph creation complexity when nodes have "consecutive" keys
by Olivier S. 03 Apr '18

03 Apr '18

Hello, I'm resending this proposal, which is simplified w.r.t the first one, and where I removed a wrong analysis of a benchmark. - Proposal I : Optimize the time complexity of (key -> Maybe Vertex) lookups and graph creation when keys are Integral and consecutive. (The related PR for proposal I is [1], including benchmarks showing the performance improvements.) Currently, (key -> Maybe Vertex) lookups returned by graphFromEdges consist of a binary search on an array, with a time complexity of O(log V) (I will use V for "Count of vertices", E for "Count of edges"). When key is Integral, and keys (of nodes passed to the graph creation function) form a set of /consecutive/ values (for example : [4,5,6,7] or [5,6,4,7]), we can have an O(1) lookup by substracting the value of the smallest key, and checking for bounds. Hence, graph creation complexity is improved, and user algorithms using (key -> Maybe Vertex) lookups will see their complexity reduced by a factor of up-to O(log V). The PR introduces this lookup and uses it for functions graphFromEdgesWithConsecutiveKeys and graphFromEdgesWithConsecutiveAscKeys. Here is a summary of complexities for (graph creation, lookup function) as they stand in the current state of the PR: - graphFromEdges (the currently existing function): O( (V+E) * log V ), O(log V) - graphFromEdgesWithConsecutiveKeys (new function): O( E + (V*log V) ), O(1) - graphFromEdgesWithConsecutiveAscKeys (new function) : O( V+E ), O(1) - Proposal II : Deprecate `graphFromEdges` taking [(node, key, [key])] in favor of `graphFromMap` taking (Map key (node,[key])) If we pass the same key twice in the list we pass to 'graphFromEdges' it is undefined which node for that key will actually be used. Introducing 'graphFromMap', taking a (Map key (node,[key]) would alleviate this issue, through the type used. Also, using a Map makes the implementation a bit more "natural" : there is no need for sorting by key, as Map.toAscList gives exactly the sorted list we want. We could also deprecate graphFromEdgesWithConsecutiveKeys and graphFromEdgesWithConsecutiveAscKeys (introduced in proposal I) in favor of graphFromConsecutiveMap. About the naming, I propose two different schemes: Either: - graphFromEdges (takes a List, deprecated, existing function) - graphFromEdgesInMap (takes a Map) - graphFromEdgesInConsecutiveMap (takes a Map with consecutive keys) Or: - graphFromEdges (takes a List, deprecated, existing function) - graphFromMap - graphFromConsecutiveMap with these, to reflect the Map / List duality in the naming scheme: - graphFromList (takes a List, deprecated, redirects to graphFromEdges) - graphFromConsecutiveList (takes a List, deprecated, redirects to graphFromEdgesWithConsecutiveKeys) - graphFromConsecutiveAscList (takes a List, deprecated, redirects to graphFromEdgesWithConsecutiveAscKeys) Cheers, Olivier Sohn [1] https://github.com/haskell/containers/pull/549

2 2

Proposal: function from Maybe to Alternative
by Li-yao Xia 01 Apr '18

01 Apr '18

Hello Libraries, I previously proposed adding a `liftMaybe :: Applicative m => Maybe a -> MaybeT m a` to transformers, on its issue tracker [1]. But its generalization to `Alternative m => Maybe a -> m a` seems like a nice addition to the base library, inside `Control.Applicative` (or `Data.Maybe`). My proposal is the following: 1) In base, add `liftMaybe = maybe empty pure :: Alternative m => Maybe a -> m a` to `Control.Applicative`. 2) In transformers, reexport it from `Control.Monad.Trans.Maybe`. There was another thread [2] on this ML also about the same combinator, and the main question appears to be whether it crosses the Fairbairn threshold. I can give some more arguments. I think it's worth giving it a name, even if there is a three-word definition (`liftMaybe = maybe empty pure`). I've found myself looking for it a few times, and that short definition is the result of a bit of code-golfing that not everyone is familiar with. Some may end up with more verbose reimplementations instead. Its absence stands out even more, as it is also the MaybeT counterpart to the functions `except`, `state`, `reader`, etc. which exist for other monad transformers. A few minor remarks. There is some asymmetry with the solution as I proposed it: this one function `liftMaybe` would correspond to two functions for every other transformer, one in the transformers library (`except`, `state`, etc.), one in mtl (`liftEither`, `state`, etc.). In contrast, the mtl-style class associated with `MaybeT` is `Alternative`. Since it is part of the standard library, it's not as useful to define a specialized version in `Control.Monad.Trans.Maybe` as it is for the other transformers. If we still decide to add a specialized function, a slightly lazier implementation is possible: liftMaybe :: Applicative m => Maybe a -> MaybeT m a liftMaybe = MaybeT . pure Cheers, Li-yao [1] https://hub.darcs.net/ross/transformers/issue/49 [2] https://mail.haskell.org/pipermail/libraries/2012-February/017548.html

1 0