Firstly, you shouldn't be committing into the containers library from your working copy. You're not the maintainer. Secondly, if you have patches to propose, you have to: * prepare a single patch for review by this list. * propose it, via a ticket, and attach the patch. * send the patch to this list for comments. * after the time is up, if there was consensus, you can recommend to Ian it be pushed. Never, ever just push your private code directly to the containers library. So, for example, you should have a proposal to rewrite all the balance functions, and a patch that shows what you change. If we all agree, then Ian or Simon can commit it. Ian : can you fix this? -- Don fox:
Hi,
I am terribly sorry if I did it wrong.
I posted the tickets to libraries, there were some discussion about some of them.
After sorting the INLINE => INLINABLE issue (I agree that in a hurry) I pushed all the tickets (I was working on top of my repo).
Once again, if I should have waited more, sorry. Rollback if I overstepped my authority.
Sorry, Milan
Milan just pushed all the following patches directly to the containers repo, and closed all the tickets associated with the effort.
* Fix warnings in Data.Map and Data.Set. * Finish the started worker/wrapper transformation. * Merge all the OPTIONS and LANGUAGE module pragmas. * Remove most INLINE from Map, Set, IntMap and IntSet. * Comment tests and benchmarks on foldlWithKey' * Worker/wrapper transformation for Data.IntSet. * Compile only the benchmark source, not the Data/*.hs. * Add criterion-based benchmark for IntSet.hs * Add a testsuite for Data.IntSet. * Further improve Data.Set balance function * Further improve Data.Map balance function * Changing delta to 3 in Data.Set. * Changing delta to 3 in Data.Map. * Correct Data.Set Arbitrary instance never to return unbalanced trees. * Correct Data.Map Arbitrary instance never to return unbalanced trees. * Improve Data.Set benchmark. * Improve benchmark infrastructure and Data.Map benchmark * Improve the performance of Data.Set balance function * Improve the performance of Data.Map balance function. * Improve performance of Data.Set union and difference operations * Improve performance of Data.Map union* and difference operations * Make the Set store the elements evaluated (bang added).
Have *any* of these patches been proposed for review? containers is a critical library, and under libraries@ maintainance. This is not what you do prior to a release.
Ian, Simon M.: did you get a chance to sign off on this?
-- Don
_______________________________________________ Libraries mailing list Libraries@haskell.org http://www.haskell.org/mailman/listinfo/libraries