Re: Proposal: add ifM and whenM to Control.Monad

i'm slightly meh about that Idea because i'll keep on misreading it as "milf" rather than "mif" On Sun, Apr 20, 2014 at 6:22 PM, Mario Pastorelli < pastorelli.mario@gmail.com> wrote:

when' and unless' are good names in my opinion. In Haskell libs ' is often used to define a similar function to another one.

For if' we could use the third convention. Its type is:

if :: Bool -> a -> a -> a

and by prefixing 'm' we can change it to be monadic:

mif :: (Monad m) => m Bool -> m a -> m a -> m a

that stands for monadic if. I don't like the idea of having different name notations for ifM and whenM/unlessM but that's true also for if-then-else and when/unless. I personally don't like the name 'mif' but I don't see many other solutions. Maybe the name 'if' isn't appropriate and it's better to change it into something else?

On 04/20/2014 11:48 PM, Edward Kmett wrote:

if' is a commonly used name in user code for what is now called bool, but it also gets used all over the place for 'if' inside of EDSLs.

On Sun, Apr 20, 2014 at 5:45 PM, Mario Pastorelli < pastorelli.mario@gmail.com> wrote:

...

I see. Another solution is to use if', when' and unless'.

On 04/20/2014 11:42 PM, Edward Kmett wrote:

My mistake. These rules are still in Control.Monad. I just scrolled right past them.

-Edward

On Sun, Apr 20, 2014 at 5:04 PM, Edward Kmett wrote:

...

The principled objection to giving these combinators the "obvious" names in Control.Monad is that that module has historically held to a detailed convention that these proposed names unfortunately don't fit. =/

The functions in this library use the following naming conventions:

...

- A postfix 'M' always stands for a function in the Kleisli category: The monad type constructor m is added to function results (modulo currying) and nowhere else. So, for example,

filter :: (a -> Bool) -> [a] -> [a] filterM :: (Monad m) => (a -> m Bool) -> [a] -> m [a]

- A postfix '_' changes the result type from (m a) to (m ()). Thus, for example:

sequence :: Monad m => [m a] -> m [a] sequence_ :: Monad m => [m a] -> m ()

- A prefix 'm' generalizes an existing function to a monadic form. Thus, for example:

sum :: Num a => [a] -> a msum :: MonadPlus m => [m a] -> m a

That said, if we do adopt them, they probably should get the ifM, whenM, unlessM names.

I don't think the convention has been documented in Control.Monad itself for years.

-Edward

On Sun, Apr 20, 2014 at 4:26 PM, Mario Pastorelli < pastorelli.mario@gmail.com> wrote:

...

Hi Herbert,

in general I like pattern matching but not when boolean values are involved. Your code is nice but, in my opinion, still far from the elegance of

f = unlessM (doesDirectoryExist path) $ do

putStrLn $ "Creating directory " ++ path createDirectory path

In particular, note that I don't have to take care of the False case and the code doesn't have boilerplate.

While your solution is more general, I would like to point out that when and unless are so useful that they got their own functions in the library instead of relying on pattern matching. I consider ifM, whenM and unlessM as alternate versions of existing functions.

On 04/20/2014 09:59 PM, Herbert Valerio Riedel wrote:

...

Hi Mario,

On 2014-04-20 at 21:10:03 +0200, Mario Pastorelli wrote:

...

I would like to propose the addition of two new combinators to Control.Monad:

ifM :: (Monad m) => m Bool -> m a -> m a -> m a whenM :: (Monad m) => m Bool -> m () -> m ()

[...]

f = do

...

dirDoesntExist <- not <$> doesDirectoryExist path when dirDoesntExist $ do putStrLn $ "Creating directory " ++ path createDirectory path

While I'm neutral on this proposal, I'd like to remind that LambdaCase may be useful to avoid temporary variables as well (and is even more useful for types other than Bool):

f = doesDirectoryExist path >>= \case True -> return () False -> do putStrLn $ "Creating directory " ++ path createDirectory path Cheers, hvr

_______________________________________________ Libraries mailing list Libraries@haskell.org http://www.haskell.org/mailman/listinfo/libraries

_______________________________________________ Libraries mailing list Libraries@haskell.org http://www.haskell.org/mailman/listinfo/libraries