Re: [darcs patch] filepath: normalise trailing dot

On 17 February 2010 01:50, Neil Mitchell wrote:

Hi Conrad,

Your proposal seems sensible (+1). Although in the past some people complained about normalising away .'s being a bug in some corner cases, so if anyone can find one of them I withdraw my support.

Creating a trac ticket is important so that the patch doesn't get lost.

Hi, apologies for the high latency, here is a trac ticket: http://hackage.haskell.org/trac/ghc/ticket/3975 Conrad.

Thanks, Neil

On Thu, Feb 11, 2010 at 8:22 AM, Conrad Parker wrote:

...

Hi,

the attached darcs patch modifies the behaviour of normalise to handle trailing dots in a path. The previous behaviour yielded this:

Prelude System.FilePath> normalise "../." "../." Prelude System.FilePath> normalise ".././" ".././" Prelude System.FilePath> normalise ".././.." "../.."

This patch modifies dropDots such that the check for (".":[]) only occurs once for the path, after which a driver function dropDots' is used which skips this check. Hence "." can be removed from the end of a longer path, but a path of just "." is unchanged.

(my trac account is pending verification, I'll reply with a trac ticket # later if needed)

cheers,

Conrad.

_______________________________________________ Libraries mailing list Libraries@haskell.org http://www.haskell.org/mailman/listinfo/libraries