On Fri, Apr 22, 2011 at 5:44 AM, Ian Lynagh
Hi Jason,
On Sun, Apr 03, 2011 at 01:28:13PM -0700, Jason Dagit wrote:
[PATCH 1/2] add calloc and callocBytes to Foreign.Marshal.Alloc
The procedure for proposing a change to the core library APIs is described here: http://www.haskell.org/haskellwiki/Library_submissions
Thanks. I admit I did not read that before sending these patches but now I need further clarification. It says to send a patch and I did that. I made the changes against the latest version of base (well, it was the latest version when I sent the patch almost 3 weeks ago). It's very hard for me to test portability. I don't have hugs on any machines. The most I could do there is test on a few OSs with ghc. I've done my best to follow the style and create documentation. As for testing, I put them on hackage where I've used them in at least one package successfully. My rationale is simple. Sometimes you need calloc instead of malloc and there was no existing binding so I created one. It seems like it should live in base. That wiki page doesn't say how long the discussion period should be or give advice on how to determine the size. What would you recommend for this patch? So it sounds like the things I missed were: * putting "Proposal:" in the subject line * setting a discussion period * attaching my patch to the trac instance (can I send a pull request on github instead?) In summary, I need clarification on: * Can I send a pull request or do I need to continue using git's patch sending commands? * How long of a discussion window do I set? Thanks, Jason