Backwards breaking change for setEnv

Hello all, I wanted to bring this bug to the attention of the CLC https://ghc.haskell.org/trac/ghc/ticket/12494#ticket I propose that we change 'setEnv k ""' to set the environment variable to an empty string, rather than delete the environment variable. The existing behavior was motivated by a Windows "quirk" that actually doesn't exist (details in ticket.) Thanks, Edward

Yes please!
On Mon, Aug 15, 2016 at 11:17 PM, Edward Z. Yang
Hello all,
I wanted to bring this bug to the attention of the CLC
https://ghc.haskell.org/trac/ghc/ticket/12494#ticket
I propose that we change 'setEnv k ""' to set the environment variable to an empty string, rather than delete the environment variable. The existing behavior was motivated by a Windows "quirk" that actually doesn't exist (details in ticket.)
Thanks, Edward _______________________________________________ Libraries mailing list Libraries@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/libraries

I like your suggestion, sounds good to me. The delete semantic always
seemed like a gotcha rather than a feature
On Tuesday, August 16, 2016, Edward Z. Yang
Hello all,
I wanted to bring this bug to the attention of the CLC
https://ghc.haskell.org/trac/ghc/ticket/12494#ticket
I propose that we change 'setEnv k ""' to set the environment variable to an empty string, rather than delete the environment variable. The existing behavior was motivated by a Windows "quirk" that actually doesn't exist (details in ticket.)
Thanks, Edward _______________________________________________ Libraries mailing list Libraries@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/libraries

On 17 August 2016 at 03:26, Carter Schonwald
I like your suggestion, sounds good to me. The delete semantic always seemed like a gotcha rather than a feature
Just in case someone is depending on that behaviour though, would it be better to deprecate this function and define a new one with the non-delete semantics?
On Tuesday, August 16, 2016, Edward Z. Yang
wrote: Hello all,
I wanted to bring this bug to the attention of the CLC
https://ghc.haskell.org/trac/ghc/ticket/12494#ticket
I propose that we change 'setEnv k ""' to set the environment variable to an empty string, rather than delete the environment variable. The existing behavior was motivated by a Windows "quirk" that actually doesn't exist (details in ticket.)
Thanks, Edward _______________________________________________ Libraries mailing list Libraries@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/libraries
_______________________________________________ Libraries mailing list Libraries@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/libraries
-- Ivan Lazar Miljenovic Ivan.Miljenovic@gmail.com http://IvanMiljenovic.wordpress.com

We could survey folks via Reddit and see. Anecdotally I think it's been more of a gotcha for some folks. On Tuesday, August 16, 2016, Ivan Lazar Miljenovic < ivan.miljenovic@gmail.com> wrote:
On 17 August 2016 at 03:26, Carter Schonwald
javascript:;> wrote: I like your suggestion, sounds good to me. The delete semantic always seemed like a gotcha rather than a feature
Just in case someone is depending on that behaviour though, would it be better to deprecate this function and define a new one with the non-delete semantics?
On Tuesday, August 16, 2016, Edward Z. Yang
javascript:;> wrote:
Hello all,
I wanted to bring this bug to the attention of the CLC
https://ghc.haskell.org/trac/ghc/ticket/12494#ticket
I propose that we change 'setEnv k ""' to set the environment variable to an empty string, rather than delete the environment variable. The existing behavior was motivated by a Windows "quirk" that actually doesn't exist (details in ticket.)
Thanks, Edward _______________________________________________ Libraries mailing list Libraries@haskell.org javascript:; http://mail.haskell.org/cgi-bin/mailman/listinfo/libraries
_______________________________________________ Libraries mailing list Libraries@haskell.org javascript:; http://mail.haskell.org/cgi-bin/mailman/listinfo/libraries
-- Ivan Lazar Miljenovic Ivan.Miljenovic@gmail.com javascript:; http://IvanMiljenovic.wordpress.com

The downside to that option is that it takes us to a less optimal name for all time, and the state of things is much more confusing to users in the interim. Normally I'm the one to advocate for the ridiculously cautious plan. ;) Here, I'd actually be curious to see if we can actually find code on hackage using the current behavior. -Edward On Tue, Aug 16, 2016 at 5:59 PM, Ivan Lazar Miljenovic < ivan.miljenovic@gmail.com> wrote:
On 17 August 2016 at 03:26, Carter Schonwald
wrote: I like your suggestion, sounds good to me. The delete semantic always seemed like a gotcha rather than a feature
Just in case someone is depending on that behaviour though, would it be better to deprecate this function and define a new one with the non-delete semantics?
On Tuesday, August 16, 2016, Edward Z. Yang
wrote: Hello all,
I wanted to bring this bug to the attention of the CLC
https://ghc.haskell.org/trac/ghc/ticket/12494#ticket
I propose that we change 'setEnv k ""' to set the environment variable to an empty string, rather than delete the environment variable. The existing behavior was motivated by a Windows "quirk" that actually doesn't exist (details in ticket.)
Thanks, Edward _______________________________________________ Libraries mailing list Libraries@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/libraries
_______________________________________________ Libraries mailing list Libraries@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/libraries
-- Ivan Lazar Miljenovic Ivan.Miljenovic@gmail.com http://IvanMiljenovic.wordpress.com _______________________________________________ Libraries mailing list Libraries@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/libraries
participants (5)
-
Bryan O'Sullivan
-
Carter Schonwald
-
Edward Kmett
-
Edward Z. Yang
-
Ivan Lazar Miljenovic