darcs patch: fix failure to compile with cabal included with ghc 6.6

David Roundy

16 May 2007 16 May '07

12:19 p.m.

I'm not sure if this is sufficient, or even a good idea, but removing this type signature makes Setup.hs able to run on my system with an older cabal. David Wed May 16 09:18:47 PDT 2007 David Roundy * fix failure to compile with cabal included with ghc 6.6

Attachments:

fix-failure-to-compile-with-cabal-included-with-ghc-6_6.dpatch (text/x-darcs-patch — 628 bytes)

Show replies by date

David Roundy

16 May 16 May

12:23 p.m.

New subject: darcs patch: fix failure to compile with cabal included with ghc 6.6

On Wed, May 16, 2007 at 09:19:50AM -0700, David Roundy wrote:

...

I'm not sure if this is sufficient, or even a good idea, but removing this type signature makes Setup.hs able to run on my system with an older cabal.

David

Wed May 16 09:18:47 PDT 2007 David Roundy * fix failure to compile with cabal included with ghc 6.6

It doesn't look like this patch will do me much good, since as far as I can tell, include/HsX11Config.h.in isn't included in the darcs repository, but is required for building X11. It'd probably be a good idea to add it. -- David Roundy Department of Physics Oregon State University

Ross Paterson

12:43 p.m.

New subject: darcs patch: fix failure to compile with cabal included with ghc 6.6

On Wed, May 16, 2007 at 09:23:02AM -0700, David Roundy wrote:

...

It doesn't look like this patch will do me much good, since as far as I can tell, include/HsX11Config.h.in isn't included in the darcs repository, but is required for building X11. It'd probably be a good idea to add it.

It's a generated file -- when building this package with Cabal directly from darcs it's necessary to run autoreconf before doing anything else.

David Roundy

1 p.m.

New subject: darcs patch: fix failure to compile with cabal included with ghc 6.6

On Wed, May 16, 2007 at 05:43:33PM +0100, Ross Paterson wrote:

...

On Wed, May 16, 2007 at 09:23:02AM -0700, David Roundy wrote:

...
It doesn't look like this patch will do me much good, since as far as I can tell, include/HsX11Config.h.in isn't included in the darcs repository, but is required for building X11. It'd probably be a good idea to add it.

It's a generated file -- when building this package with Cabal directly from darcs it's necessary to run autoreconf before doing anything else.

Sorry about that, I did read that README, but read it a little too quickly and ran autoconf rather than autoreconf. Sorry about that! -- David Roundy Department of Physics Oregon State University

Bryan O'Sullivan

17 May 17 May

2:03 a.m.

David Roundy wrote:

...

Sorry about that, I did read that README, but read it a little too quickly and ran autoconf rather than autoreconf. Sorry about that!

I get bitten by forgetting to run autoreconf all the time :-(

Ian Lynagh

20 May 20 May

1:20 p.m.

New subject: darcs patch: fix failure to compile with cabal included with ghc 6.6

Hi David, On Wed, May 16, 2007 at 09:19:50AM -0700, David Roundy wrote:

...

...
{ hunk ./Setup.hs 47

type Hook a = PackageDescription -> LocalBuildInfo -> UserHooks -> a -> IO ()

-add_ghc_options :: [String] -> Hook a -> Hook a

Thanks for the patch! I've applied something similar, with a comment as to why it's done. Thanks Ian

6575

Age (days ago)

6579

Last active (days ago)

List overview

Download

5 comments

4 participants

participants (4)

Bryan O'Sullivan
David Roundy
Ian Lynagh
Ross Paterson