Send patches to me against the new X11 repo at http://code.haskell.org/X11 martine:

On Sat, Jan 2, 2010 at 5:32 AM, Gwern Branwen wrote:

...

On Sat, Jan 2, 2010 at 1:08 AM, Evan Martin wrote:

...

I'd like to make a patch for the X11 package.

I found http://hackage.haskell.org/package/X11 , which references http://code.haskell.org/X11/ , which appears to be empty.  Did something go wrong?

If it helps any, the change is trivial (just want to get at the Visual pointer from another package, much in the way Display and Screen are exposed). I'd be happy to make a Darcs format patch if you'd prefer that.

The old repo is at *darcs*.haskell.org; it's apparently being moved to c.h.o (so as to be able to give more people the commit-bit), but hasn't yet been actually moved.

Thanks. Same patch now attached.

Having written this, what would probably be even cleaner is to have - Graphics.X11.Xlib.Types expose abstract Display, Visual etc and their typeclass instances - an extra Graphics.X11.Xlib.Internals that provides functions to go from Display -> Ptr Display, etc

However, this would be both a non-backwards-compatible change (currently Display is exposed as a newtype) and I lack the Haskell-fu to write such a change (like, the newtype would need to go into .Internals but then the deriving declaration should be in .Types?).

Sat Jan 2 08:21:30 PST 2010 Evan Martin * Expose Visual pointer

We already expose the underlying Ptr for Display; I'd like to be able to get at the Ptr for Visual as well.

New patches:

[Expose Visual pointer Evan Martin **20100102162130 Ignore-this: 104a378b987382b583a1add6cf6fb460

We already expose the underlying Ptr for Display; I'd like to be able to get at the Ptr for Visual as well.

] hunk ./Graphics/X11/Xlib/Types.hsc 18

-- #hide module Graphics.X11.Xlib.Types( - Display(..), Screen(..), Visual, GC, GCValues, SetWindowAttributes, + Display(..), Screen(..), Visual(..), GC, GCValues, SetWindowAttributes, Image(..), Point(..), Rectangle(..), Arc(..), Segment(..), Color(..), Pixel, Position, Dimension, Angle, ScreenNumber, Buffer ) where

Context:

[Remove weird character in comment. May fix building with hsc2hs on 6.12 Spencer Janssen **20091125002712 Ignore-this: ef1b32d6bb9ed22cb09a63b35a64d231 ] [Add XGetModifierMapping binding Spencer Janssen **20091103214200 Ignore-this: c22c6efc472d3a2d9bdd6c81b7d84f4d ] [KeyCode should be a byte, not a Unicode Char Spencer Janssen **20091103211642 Ignore-this: e53bc8b64fd12247ce907c710e293b67 ] [Escape path / from haddock Adam Vogt **20091115212213 Ignore-this: 2ccd8b59a6c75beb609abf3e7b4ca722 ] [De-orphan the Read Rectangle instance Adam Vogt **20091115212115 Ignore-this: 2ac94627adef450b7aec291a50878f43 ] [ExportScreenDataConstructor arsenm2@rpi.edu**20091107202100 Ignore-this: 4b8c1886a9f0acfcfb13fa7f421d0c13 ] [Move build-type from wrong stanza Don Stewart **20091005014719] [Add minimum cabal version Don Stewart **20091005014343] [Refactor cabal file. And enable support for syb generics. Don Stewart **20091005013359] [We can relax the versioning constraint on base. Don Stewart **20091004231553] [Bump configure.ac to 1.4.6 Don Stewart **20091004225102] [haskell-x11: export Cursor in Xlib.hs Andres Salomon **20090915162318 Ignore-this: 77e1afa7994d1d0a3396dac2f7b37d27

Whoops, I forgot to export the cursors along w/ the rest of Xlib.

] [Some extra fields, bump the version. Don Stewart **20090915161044] [haskell-x11: add and export the list of cursors Andres Salomon **20090915155708 Ignore-this: 995cede8cdd8830a2c0bb6c63b8229b9

Pulled in from X11/cursorfont.h, export things like xC_X_cursor and xC_left_ptr for things like createFontCursor to use.

] [TAG 1.4.5 Spencer Janssen **20081203050348 Ignore-this: d8112e4ff25ec56fe5ac2cdc9fa1ead ] [Bump version to 1.4.5 Spencer Janssen **20081203050251 Ignore-this: 665f8093d82bef9e6b13bf1e4db74e1d ] [Bump configure.ac to 1.4.4 as well Spencer Janssen **20081203050154 Ignore-this: ef3fabf26fc7dbfdb6dfaa92073e3c9e ] [Fix memory leak in getWMHints Spencer Janssen **20081125221512 Ignore-this: dacc19acbb60e13d945509cde0551bc8 ] [more precise X11 deps Don Stewart **20081011211930] [TAG 1.4.3 Spencer Janssen **20080921082528] [Bump version to 1.4.3 Spencer Janssen **20080921054954] [getCommand Marco Túlio Gontijo e Silva **20080712154521] [X implementation dependent keysyms from X.org zythmer@gmail.com**20080528004224

Added all of the X keysyms from X.org except the groups XK_MISCELLANY and XK_LATIN1 as well as skipped XK_VoidSymbol since it is not in any group. The above groups and symbol are already in Graphics.X11.Types ] [Make sure both --with-xinerama and --without-xinerama works Lennart Kolmodin **20080524112224 Use the builtin variable with_xinerama instead of our want_xinerama. This gives us ability to use both --with-xinerama and --without-xinerama. ] [Use -auto-all when profiling Don Stewart **20080413112039] [Update configure.ac with new version number Lennart Kolmodin **20080331184021] [Add setKeyEvent to Graphics.X11.Xlib.Extras Jérémy Bobbio **20080328214753] [TAG 1.4.2 Spencer Janssen **20080327193813] [Bump version number to 1.4.2 Spencer Janssen **20080327193755] [Handle a NULL retrun from XGetWMHints correctly, fixes a segfault bug Spencer Janssen **20080327192702] [update version info Don Stewart **20080307190921] [comments Don Stewart **20080307190910] [Remove -O2 from ghc-options Spencer Janssen **20071216001612] [TAG 1.4.1 Spencer Janssen **20071211042441] [Bump version to 1.4.1 Spencer Janssen **20071211042430] [Check the return value of XGetWindowProperty, this fixes crash bugs when the requested Window/Property does not exist Spencer Janssen **20071211041940] [Update installation instructions to use newer Cabal's --configure-option Alec Berryman **20071120214634] [Remove obsolete INSTALL file; installation instructions are in README Alec Berryman **20071120203353] [Remove redundant XIconifyWindow binding Spencer Janssen **20071208084849] [Added haddock docs to setErrorHandler; added XIconifyWindow and XMapRaised bindings hoelz@wisc.edu**20071202043806] [use a working header file for XSetErrorHandler Lukas Mai **20071129174529] [Implemented a full binding to XSetErrorHandler hoelz@wisc.edu**20071127011847] [TAG 1.4.0 Don Stewart **20071125032528] [bump X11 version to 1.4.0 Don Stewart **20071125032135] [add copyright info and year for Graphics/X11/Xlib/Extras.hsc Don Stewart **20071121024752] [bump to snapshot tag Don Stewart **20071111200531] [Fix bug in the type of functions dealing with properties Mats Jansborg **20071101190154

The documentation for XGetWindowProperty and XChangeProperty states that the data must be represented as an array of char, short and long for a format of 8, 16 and 32 respectively. Previously Word8, Word16 and Word32 were used, resulting in bugs on platforms where char is not 8 bits, short 16 bits and long 32 bits wide. ] [home instead of $USER Don Stewart **20071101212016] [space in CPPFLAGS will break .buildinfo file Don Stewart **20071031172720] [add CPPFLAGS and LDFLAGS to buildinfo file Don Stewart **20071031172436] [formatting Don Stewart **20071031171257] [license header for Xinerama Don Stewart **20071031165900] [untabify Don Stewart **20071031165743] [#!-able Setup.lhs Don Stewart *-20071030173235] [bump version Don Stewart **20071030213949] [Bump version number Ian Lynagh **20071027124814] [#!-able Setup.lhs Don Stewart **20071030173235] [TAG X11-1.3.0 Don Stewart **20071030172832] [wall police Don Stewart **20071030171430] [cabal tweaks Don Stewart **20071030171341] [wall police Don Stewart **20071029205511] [Bug fix: not storing height in XSizeHints.resize_inc Don Stewart **20071029202844] [-Wall police Don Stewart **20071029202542] [clean up warnings Don Stewart **20071029201214] [wrong header included, hidden by -fasm Don Stewart **20071029184208] [no .lhs Setup script Don Stewart **20071029183618] [Xutils.h -> Xutil.hs Don Stewart **20071029183435] [more info in readme Don Stewart **20071029182528] [more typos in the merged .cabal file Don Stewart **20071029182349] [duplicate line in .cabal file Don Stewart **20071029181942] [Merge in X11-extras package, bump to 1.3.0. Adds Xinerama and X event support. Don Stewart **20071029175855] [TAG 1.2.3 Don Stewart **20071012181748] Patch bundle hash: 1d5bd93f53f363a8d3703a443424750517f6ad58

_______________________________________________ Libraries mailing list Libraries@haskell.org http://www.haskell.org/mailman/listinfo/libraries